[block:block-5.9 41/41] net/sunrpc/xprtsock.c:392:9: sparse: sparse: incompatible types in conditional expression (different base types):

[block:block-5.9 41/41] net/sunrpc/xprtsock.c:392:9: sparse: sparse: incompatible types in conditional expression (different base types):

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3640 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git block-5.9
head:   fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
commit: fc703681a3cfa4178fb69ee6a90feb2ffb250e5f [41/41] block: allow for_each_bvec to support zero len bvec
config: powerpc64-randconfig-s032-20200902 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-191-g10164920-dirty
        git checkout fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> net/sunrpc/xprtsock.c:392:9: sparse: sparse: incompatible types in conditional expression (different base types):
>> net/sunrpc/xprtsock.c:392:9: sparse:    bool
>> net/sunrpc/xprtsock.c:392:9: sparse:    void
--
>> net/sunrpc/svcsock.c:236:9: sparse: sparse: incompatible types in conditional expression (different base types):
>> net/sunrpc/svcsock.c:236:9: sparse:    bool
>> net/sunrpc/svcsock.c:236:9: sparse:    void

# https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
git remote add block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch --no-tags block block-5.9
git checkout fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
vim +392 net/sunrpc/xprtsock.c

277e4ab7d530bf Trond Myklebust 2018-09-14  381  
6a829eb8619fbd Trond Myklebust 2019-01-03  382  #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
6a829eb8619fbd Trond Myklebust 2019-01-03  383  static void
6a829eb8619fbd Trond Myklebust 2019-01-03  384  xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
6a829eb8619fbd Trond Myklebust 2019-01-03  385  {
6a829eb8619fbd Trond Myklebust 2019-01-03  386  	struct bvec_iter bi = {
6a829eb8619fbd Trond Myklebust 2019-01-03  387  		.bi_size = count,
6a829eb8619fbd Trond Myklebust 2019-01-03  388  	};
6a829eb8619fbd Trond Myklebust 2019-01-03  389  	struct bio_vec bv;
6a829eb8619fbd Trond Myklebust 2019-01-03  390  
6a829eb8619fbd Trond Myklebust 2019-01-03  391  	bvec_iter_advance(bvec, &bi, seek & PAGE_MASK);
6a829eb8619fbd Trond Myklebust 2019-01-03 @392  	for_each_bvec(bv, bvec, bi, bi)
6a829eb8619fbd Trond Myklebust 2019-01-03  393  		flush_dcache_page(bv.bv_page);
6a829eb8619fbd Trond Myklebust 2019-01-03  394  }
6a829eb8619fbd Trond Myklebust 2019-01-03  395  #else
6a829eb8619fbd Trond Myklebust 2019-01-03  396  static inline void
6a829eb8619fbd Trond Myklebust 2019-01-03  397  xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
6a829eb8619fbd Trond Myklebust 2019-01-03  398  {
6a829eb8619fbd Trond Myklebust 2019-01-03  399  }
6a829eb8619fbd Trond Myklebust 2019-01-03  400  #endif
6a829eb8619fbd Trond Myklebust 2019-01-03  401  

:::::: The code at line 392 was first introduced by commit
:::::: 6a829eb8619fbdde6d7d627ad582fe119805f39d SUNRPC: Fix TCP receive code on archs with flush_dcache_page()

:::::: TO: Trond Myklebust <trondmy@gmail.com>
:::::: CC: Anna Schumaker <Anna.Schumaker@Netapp.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33734 bytes --]

Re: [block:block-5.9 41/41] net/sunrpc/xprtsock.c:392:9: sparse: sparse: incompatible types in conditional expression (different base types):

[Ming Lei]

[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]

On Thu, Sep 03, 2020 at 04:51:44AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git block-5.9
> head:   fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
> commit: fc703681a3cfa4178fb69ee6a90feb2ffb250e5f [41/41] block: allow for_each_bvec to support zero len bvec
> config: powerpc64-randconfig-s032-20200902 (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.2-191-g10164920-dirty
>         git checkout fc703681a3cfa4178fb69ee6a90feb2ffb250e5f
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> net/sunrpc/xprtsock.c:392:9: sparse: sparse: incompatible types in conditional expression (different base types):
> >> net/sunrpc/xprtsock.c:392:9: sparse:    bool
> >> net/sunrpc/xprtsock.c:392:9: sparse:    void
> --
> >> net/sunrpc/svcsock.c:236:9: sparse: sparse: incompatible types in conditional expression (different base types):
> >> net/sunrpc/svcsock.c:236:9: sparse:    bool
> >> net/sunrpc/svcsock.c:236:9: sparse:    void

The above sparse warning can be killed by the following delta patch, and it
isn't a problem actually:

diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index 9c4fab5f22a7..dd74503f7e5e 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -127,7 +127,7 @@ static inline void bvec_iter_skip_zero_bvec(struct bvec_iter *iter)
        for (iter = (start);                                            \
             (iter).bi_size &&                                          \
                ((bvl = bvec_iter_bvec((bio_vec), (iter))), 1); \
-            (bvl).bv_len ? bvec_iter_advance((bio_vec), &(iter),       \
+            (bvl).bv_len ? (void)bvec_iter_advance((bio_vec), &(iter), \
                     (bvl).bv_len) : bvec_iter_skip_zero_bvec(&(iter)))

Jens, do you need me to post a new version with above change?


Thanks, 
Ming