All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/gfx10: Delete some duplicated argument to '|'
@ 2020-09-03  2:17 Ye Bin
  2020-09-03  6:34 ` Huang Rui
  0 siblings, 1 reply; 3+ messages in thread
From: Ye Bin @ 2020-09-03  2:17 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, amd-gfx; +Cc: Ye Bin

1. gfx_v10_0_soft_reset GRBM_STATUS__SPI_BUSY_MASK
2. gfx_v10_0_update_gfx_clock_gating AMD_CG_SUPPORT_GFX_CGLS

Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 2db195ec8d0c..d502e30f67d9 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -7055,8 +7055,7 @@ static int gfx_v10_0_soft_reset(void *handle)
 		   GRBM_STATUS__BCI_BUSY_MASK | GRBM_STATUS__SX_BUSY_MASK |
 		   GRBM_STATUS__TA_BUSY_MASK | GRBM_STATUS__DB_BUSY_MASK |
 		   GRBM_STATUS__CB_BUSY_MASK | GRBM_STATUS__GDS_BUSY_MASK |
-		   GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK
-		   | GRBM_STATUS__BCI_BUSY_MASK)) {
+		   GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK)) {
 		grbm_soft_reset = REG_SET_FIELD(grbm_soft_reset,
 						GRBM_SOFT_RESET, SOFT_RESET_CP,
 						1);
@@ -7449,7 +7448,6 @@ static int gfx_v10_0_update_gfx_clock_gating(struct amdgpu_device *adev,
 	    (AMD_CG_SUPPORT_GFX_MGCG |
 	     AMD_CG_SUPPORT_GFX_CGLS |
 	     AMD_CG_SUPPORT_GFX_CGCG |
-	     AMD_CG_SUPPORT_GFX_CGLS |
 	     AMD_CG_SUPPORT_GFX_3D_CGCG |
 	     AMD_CG_SUPPORT_GFX_3D_CGLS))
 		gfx_v10_0_enable_gui_idle_interrupt(adev, enable);
-- 
2.25.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu/gfx10: Delete some duplicated argument to '|'
  2020-09-03  2:17 [PATCH] drm/amdgpu/gfx10: Delete some duplicated argument to '|' Ye Bin
@ 2020-09-03  6:34 ` Huang Rui
  2020-09-03 18:02   ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Huang Rui @ 2020-09-03  6:34 UTC (permalink / raw)
  To: Ye Bin; +Cc: alexander.deucher, christian.koenig, amd-gfx

On Thu, Sep 03, 2020 at 10:17:56AM +0800, Ye Bin wrote:
> 1. gfx_v10_0_soft_reset GRBM_STATUS__SPI_BUSY_MASK
> 2. gfx_v10_0_update_gfx_clock_gating AMD_CG_SUPPORT_GFX_CGLS
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index 2db195ec8d0c..d502e30f67d9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -7055,8 +7055,7 @@ static int gfx_v10_0_soft_reset(void *handle)
>  		   GRBM_STATUS__BCI_BUSY_MASK | GRBM_STATUS__SX_BUSY_MASK |
>  		   GRBM_STATUS__TA_BUSY_MASK | GRBM_STATUS__DB_BUSY_MASK |
>  		   GRBM_STATUS__CB_BUSY_MASK | GRBM_STATUS__GDS_BUSY_MASK |
> -		   GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK
> -		   | GRBM_STATUS__BCI_BUSY_MASK)) {
> +		   GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK)) {
>  		grbm_soft_reset = REG_SET_FIELD(grbm_soft_reset,
>  						GRBM_SOFT_RESET, SOFT_RESET_CP,
>  						1);
> @@ -7449,7 +7448,6 @@ static int gfx_v10_0_update_gfx_clock_gating(struct amdgpu_device *adev,
>  	    (AMD_CG_SUPPORT_GFX_MGCG |
>  	     AMD_CG_SUPPORT_GFX_CGLS |
>  	     AMD_CG_SUPPORT_GFX_CGCG |
> -	     AMD_CG_SUPPORT_GFX_CGLS |
>  	     AMD_CG_SUPPORT_GFX_3D_CGCG |
>  	     AMD_CG_SUPPORT_GFX_3D_CGLS))
>  		gfx_v10_0_enable_gui_idle_interrupt(adev, enable);
> -- 
> 2.25.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cray.huang%40amd.com%7C8215921a33564f5d7eba08d84fb1e505%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637346973382780465&amp;sdata=91fBV5jvWLukcSerSI8WPwWc4bzWDJb3ZW86qDJ9kwI%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu/gfx10: Delete some duplicated argument to '|'
  2020-09-03  6:34 ` Huang Rui
@ 2020-09-03 18:02   ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2020-09-03 18:02 UTC (permalink / raw)
  To: Huang Rui; +Cc: Deucher, Alexander, amd-gfx list, Christian Koenig, Ye Bin

Applied.  Thanks!

Alex

On Thu, Sep 3, 2020 at 2:35 AM Huang Rui <ray.huang@amd.com> wrote:
>
> On Thu, Sep 03, 2020 at 10:17:56AM +0800, Ye Bin wrote:
> > 1. gfx_v10_0_soft_reset GRBM_STATUS__SPI_BUSY_MASK
> > 2. gfx_v10_0_update_gfx_clock_gating AMD_CG_SUPPORT_GFX_CGLS
> >
> > Signed-off-by: Ye Bin <yebin10@huawei.com>
>
> Reviewed-by: Huang Rui <ray.huang@amd.com>
>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> > index 2db195ec8d0c..d502e30f67d9 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> > @@ -7055,8 +7055,7 @@ static int gfx_v10_0_soft_reset(void *handle)
> >                  GRBM_STATUS__BCI_BUSY_MASK | GRBM_STATUS__SX_BUSY_MASK |
> >                  GRBM_STATUS__TA_BUSY_MASK | GRBM_STATUS__DB_BUSY_MASK |
> >                  GRBM_STATUS__CB_BUSY_MASK | GRBM_STATUS__GDS_BUSY_MASK |
> > -                GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK
> > -                | GRBM_STATUS__BCI_BUSY_MASK)) {
> > +                GRBM_STATUS__SPI_BUSY_MASK | GRBM_STATUS__GE_BUSY_NO_DMA_MASK)) {
> >               grbm_soft_reset = REG_SET_FIELD(grbm_soft_reset,
> >                                               GRBM_SOFT_RESET, SOFT_RESET_CP,
> >                                               1);
> > @@ -7449,7 +7448,6 @@ static int gfx_v10_0_update_gfx_clock_gating(struct amdgpu_device *adev,
> >           (AMD_CG_SUPPORT_GFX_MGCG |
> >            AMD_CG_SUPPORT_GFX_CGLS |
> >            AMD_CG_SUPPORT_GFX_CGCG |
> > -          AMD_CG_SUPPORT_GFX_CGLS |
> >            AMD_CG_SUPPORT_GFX_3D_CGCG |
> >            AMD_CG_SUPPORT_GFX_3D_CGLS))
> >               gfx_v10_0_enable_gui_idle_interrupt(adev, enable);
> > --
> > 2.25.4
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cray.huang%40amd.com%7C8215921a33564f5d7eba08d84fb1e505%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637346973382780465&amp;sdata=91fBV5jvWLukcSerSI8WPwWc4bzWDJb3ZW86qDJ9kwI%3D&amp;reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-03 18:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03  2:17 [PATCH] drm/amdgpu/gfx10: Delete some duplicated argument to '|' Ye Bin
2020-09-03  6:34 ` Huang Rui
2020-09-03 18:02   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.