From: Christoph Hellwig <hch@lst.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
drbd-dev@lists.linbit.com, linux-ide@vger.kernel.org,
linux-raid@vger.kernel.org,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-s390@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
target-devel@vger.kernel.org
Subject: Re: [PATCH 2/9] block: add a bdev_is_partition helper
Date: Thu, 3 Sep 2020 10:26:09 +0200 [thread overview]
Message-ID: <20200903082609.GA23498@lst.de> (raw)
In-Reply-To: <CAPDyKFrkcpziGFPmSd8Kx4bzhoN6zxF1E8MagLQSa4sBmnicOg@mail.gmail.com>
On Thu, Sep 03, 2020 at 10:19:34AM +0200, Ulf Hansson wrote:
> On Thu, 3 Sep 2020 at 07:42, Christoph Hellwig <hch@lst.de> wrote:
> >
> > Add a littler helper to make the somewhat arcane bd_contains checks a
> > little more obvious.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Not sure why we have both "bd_contains" and "bd_partno", nevertheless,
> feel free to add:
Right now both are needed for how blkdev_get/put work. But I plan to
eventual kill off bd_contains after some major surgery to that code.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
drbd-dev@lists.linbit.com, linux-ide@vger.kernel.org,
linux-raid@vger.kernel.org,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-s390@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
target-devel@vger.kernel.org
Subject: Re: [PATCH 2/9] block: add a bdev_is_partition helper
Date: Thu, 03 Sep 2020 08:26:09 +0000 [thread overview]
Message-ID: <20200903082609.GA23498@lst.de> (raw)
In-Reply-To: <CAPDyKFrkcpziGFPmSd8Kx4bzhoN6zxF1E8MagLQSa4sBmnicOg@mail.gmail.com>
On Thu, Sep 03, 2020 at 10:19:34AM +0200, Ulf Hansson wrote:
> On Thu, 3 Sep 2020 at 07:42, Christoph Hellwig <hch@lst.de> wrote:
> >
> > Add a littler helper to make the somewhat arcane bd_contains checks a
> > little more obvious.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Not sure why we have both "bd_contains" and "bd_partno", nevertheless,
> feel free to add:
Right now both are needed for how blkdev_get/put work. But I plan to
eventual kill off bd_contains after some major surgery to that code.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
linux-s390@vger.kernel.org,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
linux-ide@vger.kernel.org, dm-devel@redhat.com,
target-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 2/9] block: add a bdev_is_partition helper
Date: Thu, 3 Sep 2020 10:26:09 +0200 [thread overview]
Message-ID: <20200903082609.GA23498@lst.de> (raw)
In-Reply-To: <CAPDyKFrkcpziGFPmSd8Kx4bzhoN6zxF1E8MagLQSa4sBmnicOg@mail.gmail.com>
On Thu, Sep 03, 2020 at 10:19:34AM +0200, Ulf Hansson wrote:
> On Thu, 3 Sep 2020 at 07:42, Christoph Hellwig <hch@lst.de> wrote:
> >
> > Add a littler helper to make the somewhat arcane bd_contains checks a
> > little more obvious.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Not sure why we have both "bd_contains" and "bd_partno", nevertheless,
> feel free to add:
Right now both are needed for how blkdev_get/put work. But I plan to
eventual kill off bd_contains after some major surgery to that code.
next prev parent reply other threads:[~2020-09-03 8:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 5:40 clean up is partition checks Christoph Hellwig
2020-09-03 5:40 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:40 ` Christoph Hellwig
2020-09-03 5:40 ` [PATCH 1/9] Documentation/hdio: fix up obscure bd_contains references Christoph Hellwig
2020-09-03 5:40 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:40 ` Christoph Hellwig
2020-09-03 5:40 ` [PATCH 2/9] block: add a bdev_is_partition helper Christoph Hellwig
2020-09-03 5:40 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:40 ` Christoph Hellwig
2020-09-03 8:19 ` Ulf Hansson
2020-09-03 8:19 ` Ulf Hansson
2020-09-03 8:26 ` Christoph Hellwig [this message]
2020-09-03 8:26 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 8:26 ` Christoph Hellwig
2020-09-03 5:40 ` [PATCH 3/9] md: compare bd_disk instead of bd_contains Christoph Hellwig
2020-09-03 5:40 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:40 ` Christoph Hellwig
2020-09-09 0:55 ` Song Liu
2020-09-09 0:55 ` Song Liu
2020-09-03 5:40 ` [PATCH 4/9] md: don't detour through bd_contains for the gendisk Christoph Hellwig
2020-09-03 5:40 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:40 ` Christoph Hellwig
2020-09-09 0:55 ` Song Liu
2020-09-09 0:55 ` Song Liu
2020-09-03 5:41 ` [PATCH 5/9] drbd: " Christoph Hellwig
2020-09-03 5:41 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:41 ` Christoph Hellwig
2020-09-03 5:41 ` [PATCH 6/9] drbd: don't set ->bd_contains Christoph Hellwig
2020-09-03 5:41 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:41 ` Christoph Hellwig
2020-09-03 5:41 ` [PATCH 7/9] target/iblock: fix holder printing in iblock_show_configfs_dev_params Christoph Hellwig
2020-09-03 5:41 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:41 ` Christoph Hellwig
2020-09-03 5:41 ` [PATCH 8/9] block: use bd_partno in bdevname Christoph Hellwig
2020-09-03 5:41 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:41 ` Christoph Hellwig
2020-09-03 5:41 ` [PATCH 9/9] vsprintf: use bd_partno in bdev_name Christoph Hellwig
2020-09-03 5:41 ` [Drbd-dev] " Christoph Hellwig
2020-09-03 5:41 ` Christoph Hellwig
2020-09-15 5:45 ` clean up is partition checks Christoph Hellwig
2020-09-15 5:45 ` [Drbd-dev] " Christoph Hellwig
2020-09-15 5:45 ` Christoph Hellwig
2020-09-25 14:19 ` Jens Axboe
2020-09-25 14:19 ` [Drbd-dev] " Jens Axboe
2020-09-25 14:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903082609.GA23498@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.