From: Joerg Roedel <jroedel@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, Daniel Vetter <daniel@ffwll.ch>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header
Date: Fri, 4 Sep 2020 12:13:01 +0200 [thread overview]
Message-ID: <20200904101301.GC28643@suse.de> (raw)
In-Reply-To: <20200828161212.71294-1-andriy.shevchenko@linux.intel.com>
On Fri, Aug 28, 2020 at 07:12:11PM +0300, Andy Shevchenko wrote:
> Static analyzer is not happy about intel_iommu_gfx_mapped declaration:
>
> .../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?
>
> Move its declaration to Intel IOMMU header file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/drm/intel-gtt.h | 5 +----
> include/linux/intel-iommu.h | 1 +
> 2 files changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header
Date: Fri, 4 Sep 2020 12:13:01 +0200 [thread overview]
Message-ID: <20200904101301.GC28643@suse.de> (raw)
In-Reply-To: <20200828161212.71294-1-andriy.shevchenko@linux.intel.com>
On Fri, Aug 28, 2020 at 07:12:11PM +0300, Andy Shevchenko wrote:
> Static analyzer is not happy about intel_iommu_gfx_mapped declaration:
>
> .../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?
>
> Move its declaration to Intel IOMMU header file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/drm/intel-gtt.h | 5 +----
> include/linux/intel-iommu.h | 1 +
> 2 files changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-04 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 16:12 [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header Andy Shevchenko
2020-08-28 16:12 ` Andy Shevchenko
2020-09-01 5:01 ` Lu Baolu
2020-09-01 5:01 ` Lu Baolu
2020-09-04 10:13 ` Joerg Roedel [this message]
2020-09-04 10:13 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904101301.GC28643@suse.de \
--to=jroedel@suse.de \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.