From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250
Date: Sun, 6 Sep 2020 14:44:07 +0200 [thread overview]
Message-ID: <20200906124407.GA4829@kozik-lap> (raw)
In-Reply-To: <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com>
On Fri, Sep 04, 2020 at 08:47:10AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 03.09.2020 20:14, Krzysztof Kozlowski wrote:
> > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node
> > for exynos3250") added assigned clocks under Clock Management Unit to
> > fix hangs when accessing ISP registers.
> >
> > However the dtschema expects "clocks" property if "assigned-clocks" are
> > used. Add reference to input clock, the parent used in
> > "assigned-clock-parents" to silence the dtschema warnings:
> >
> > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Add clocks property.
> >
> > This is a v2 for:
> > https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6
> > ---
> > arch/arm/boot/dts/exynos3250.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> > index a1e93fb7f694..89b160280469 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > @@ -214,6 +214,7 @@
> > compatible = "samsung,exynos3250-cmu";
> > reg = <0x10030000 0x20000>;
> > #clock-cells = <1>;
> > + clocks = <&cmu CLK_FIN_PLL>;
>
> This is not a correct input clock for this CMU. Please assign it to
> xusbxti, xxti or xtcxo in the respective board dts, as this is a board
> property.
Makes sense, although all this is kind of a hack as neither the bindings
nor the driver take the input clock.
Best regards,
Krzysztof
>
> > assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>,
> > <&cmu CLK_MOUT_ACLK_266_SUB>;
> > assigned-clock-parents = <&cmu CLK_FIN_PLL>,
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250
Date: Sun, 6 Sep 2020 14:44:07 +0200 [thread overview]
Message-ID: <20200906124407.GA4829@kozik-lap> (raw)
In-Reply-To: <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com>
On Fri, Sep 04, 2020 at 08:47:10AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 03.09.2020 20:14, Krzysztof Kozlowski wrote:
> > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node
> > for exynos3250") added assigned clocks under Clock Management Unit to
> > fix hangs when accessing ISP registers.
> >
> > However the dtschema expects "clocks" property if "assigned-clocks" are
> > used. Add reference to input clock, the parent used in
> > "assigned-clock-parents" to silence the dtschema warnings:
> >
> > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Add clocks property.
> >
> > This is a v2 for:
> > https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6
> > ---
> > arch/arm/boot/dts/exynos3250.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> > index a1e93fb7f694..89b160280469 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > @@ -214,6 +214,7 @@
> > compatible = "samsung,exynos3250-cmu";
> > reg = <0x10030000 0x20000>;
> > #clock-cells = <1>;
> > + clocks = <&cmu CLK_FIN_PLL>;
>
> This is not a correct input clock for this CMU. Please assign it to
> xusbxti, xxti or xtcxo in the respective board dts, as this is a board
> property.
Makes sense, although all this is kind of a hack as neither the bindings
nor the driver take the input clock.
Best regards,
Krzysztof
>
> > assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>,
> > <&cmu CLK_MOUT_ACLK_266_SUB>;
> > assigned-clock-parents = <&cmu CLK_FIN_PLL>,
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-06 12:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200903181437eucas1p16b97d1c425672700bac7ece19084584c@eucas1p1.samsung.com>
2020-09-03 18:14 ` [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 Krzysztof Kozlowski
2020-09-03 18:14 ` Krzysztof Kozlowski
2020-09-03 18:14 ` [PATCH v2 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid Krzysztof Kozlowski
2020-09-03 18:14 ` Krzysztof Kozlowski
2020-09-04 7:02 ` Marek Szyprowski
2020-09-04 7:02 ` Marek Szyprowski
2020-09-06 12:56 ` Krzysztof Kozlowski
2020-09-06 12:56 ` Krzysztof Kozlowski
2020-09-03 18:14 ` [PATCH v2 3/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos5422 Odroid XU3 Krzysztof Kozlowski
2020-09-03 18:14 ` Krzysztof Kozlowski
2020-09-04 10:20 ` Sylwester Nawrocki
2020-09-04 10:20 ` Sylwester Nawrocki
2020-09-06 13:06 ` Krzysztof Kozlowski
2020-09-06 13:06 ` Krzysztof Kozlowski
2020-09-04 6:47 ` [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 Marek Szyprowski
2020-09-04 6:47 ` Marek Szyprowski
2020-09-06 12:44 ` Krzysztof Kozlowski [this message]
2020-09-06 12:44 ` Krzysztof Kozlowski
2020-09-07 8:35 ` Sylwester Nawrocki
2020-09-07 8:35 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906124407.GA4829@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.