All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Vicente Bergas <vicencb@gmail.com>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-iio@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] IIO: rockchip: add missing dependencies for saradc
Date: Sun, 6 Sep 2020 16:20:10 +0100	[thread overview]
Message-ID: <20200906162010.30094d61@archlinux> (raw)
In-Reply-To: <20200901204054.5334-1-vicencb@gmail.com>

On Tue,  1 Sep 2020 22:40:54 +0200
Vicente Bergas <vicencb@gmail.com> wrote:

> This driver uses the triggered buffer functionality
> but was not requiring it.
> 
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>

Fix should now be in tree. I don't think the IIO_TRIGGER select
is necessary (and isn't in current fixed version) but if I'm wrong
on that please shout!  Logically it shouldn't be required as the
driver doesn't provide a trigger, but we may have something missing
a stub somewhere.

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..cd90f60cdfd9 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
>  	tristate "Rockchip SARADC driver"
>  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
>  	depends on RESET_CONTROLLER
> +	select IIO_BUFFER
> +	select IIO_TRIGGER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the SARADC found in SoCs from
>  	  Rockchip.


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Vicente Bergas <vicencb@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-iio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Hartmut Knaack" <knaack.h@gmx.de>
Subject: Re: [PATCH] IIO: rockchip: add missing dependencies for saradc
Date: Sun, 6 Sep 2020 16:20:10 +0100	[thread overview]
Message-ID: <20200906162010.30094d61@archlinux> (raw)
In-Reply-To: <20200901204054.5334-1-vicencb@gmail.com>

On Tue,  1 Sep 2020 22:40:54 +0200
Vicente Bergas <vicencb@gmail.com> wrote:

> This driver uses the triggered buffer functionality
> but was not requiring it.
> 
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>

Fix should now be in tree. I don't think the IIO_TRIGGER select
is necessary (and isn't in current fixed version) but if I'm wrong
on that please shout!  Logically it shouldn't be required as the
driver doesn't provide a trigger, but we may have something missing
a stub somewhere.

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..cd90f60cdfd9 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
>  	tristate "Rockchip SARADC driver"
>  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
>  	depends on RESET_CONTROLLER
> +	select IIO_BUFFER
> +	select IIO_TRIGGER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the SARADC found in SoCs from
>  	  Rockchip.


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2020-09-06 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 20:40 [PATCH] IIO: rockchip: add missing dependencies for saradc Vicente Bergas
2020-09-01 20:40 ` Vicente Bergas
2020-09-06 15:20 ` Jonathan Cameron [this message]
2020-09-06 15:20   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906162010.30094d61@archlinux \
    --to=jic23@kernel.org \
    --cc=heiko@sntech.de \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.