From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: himadrispandya@gmail.com, dvyukov@google.com, linux-usb@vger.kernel.org
Cc: alsa-devel@alsa-project.org, johan.hedberg@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
marcel@holtmann.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, stern@rowland.harvard.ed,
linux-bluetooth@vger.kernel.org,
Alexander Tsoy <alexander@tsoy.me>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH v2 11/11] ALSA: remove calls to usb_pipe_type_check for control endpoints
Date: Mon, 7 Sep 2020 16:51:08 +0200 [thread overview]
Message-ID: <20200907145108.3766613-12-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20200907145108.3766613-1-gregkh@linuxfoundation.org>
A USB device will always haev a bi-directional endpoint 0, that's just
how the devices work, so no need to check for that in a few quirk tests
as it will always pass.
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Alexander Tsoy <alexander@tsoy.me>
Cc: alsa-devel@alsa-project.org
Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2:
- new patch, was not in v1 series, suggested by Alan.
sound/usb/quirks.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index fc3aab04a0bc..35da4aa918c7 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -875,8 +875,6 @@ static int snd_usb_nativeinstruments_boot_quirk(struct usb_device *dev)
{
int ret;
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
0xaf, USB_TYPE_VENDOR | USB_RECIP_DEVICE,
1, 0, NULL, 0, 1000);
@@ -984,8 +982,6 @@ static int snd_usb_axefx3_boot_quirk(struct usb_device *dev)
dev_dbg(&dev->dev, "Waiting for Axe-Fx III to boot up...\n");
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
/* If the Axe-Fx III has not fully booted, it will timeout when trying
* to enable the audio streaming interface. A more generous timeout is
* used here to detect when the Axe-Fx III has finished booting as the
@@ -1117,8 +1113,6 @@ static int snd_usb_motu_m_series_boot_quirk(struct usb_device *dev)
{
int ret;
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
1, USB_TYPE_VENDOR | USB_RECIP_DEVICE,
0x0, 0, NULL, 0, 1000);
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: himadrispandya@gmail.com, dvyukov@google.com, linux-usb@vger.kernel.org
Cc: perex@perex.cz, tiwai@suse.com, stern@rowland.harvard.ed,
linux-kernel@vger.kernel.org, marcel@holtmann.org,
johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org,
alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Tsoy <alexander@tsoy.me>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH v2 11/11] ALSA: remove calls to usb_pipe_type_check for control endpoints
Date: Mon, 7 Sep 2020 16:51:08 +0200 [thread overview]
Message-ID: <20200907145108.3766613-12-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20200907145108.3766613-1-gregkh@linuxfoundation.org>
A USB device will always haev a bi-directional endpoint 0, that's just
how the devices work, so no need to check for that in a few quirk tests
as it will always pass.
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Alexander Tsoy <alexander@tsoy.me>
Cc: alsa-devel@alsa-project.org
Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2:
- new patch, was not in v1 series, suggested by Alan.
sound/usb/quirks.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index fc3aab04a0bc..35da4aa918c7 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -875,8 +875,6 @@ static int snd_usb_nativeinstruments_boot_quirk(struct usb_device *dev)
{
int ret;
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
0xaf, USB_TYPE_VENDOR | USB_RECIP_DEVICE,
1, 0, NULL, 0, 1000);
@@ -984,8 +982,6 @@ static int snd_usb_axefx3_boot_quirk(struct usb_device *dev)
dev_dbg(&dev->dev, "Waiting for Axe-Fx III to boot up...\n");
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
/* If the Axe-Fx III has not fully booted, it will timeout when trying
* to enable the audio streaming interface. A more generous timeout is
* used here to detect when the Axe-Fx III has finished booting as the
@@ -1117,8 +1113,6 @@ static int snd_usb_motu_m_series_boot_quirk(struct usb_device *dev)
{
int ret;
- if (usb_pipe_type_check(dev, usb_sndctrlpipe(dev, 0)))
- return -EINVAL;
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
1, USB_TYPE_VENDOR | USB_RECIP_DEVICE,
0x0, 0, NULL, 0, 1000);
--
2.28.0
next prev parent reply other threads:[~2020-09-07 14:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 14:50 [PATCH v2 00/11] USB: new USB control message helper functions Greg Kroah-Hartman
2020-09-07 14:50 ` Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 01/11] USB: move snd_usb_pipe_sanity_check into the USB core Greg Kroah-Hartman
2020-09-07 14:50 ` Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 02/11] USB: add usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:50 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 03/11] USB: core: message.c: use usb_control_msg_send() in a few places Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:56 ` Greg Kroah-Hartman
2020-09-07 14:56 ` Greg Kroah-Hartman
2020-09-07 15:48 ` Andy Shevchenko
2020-09-07 15:48 ` Andy Shevchenko
2020-09-07 14:51 ` [PATCH v2 04/11] USB: core: hub.c: " Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 15:08 ` Alan Stern
2020-09-07 15:08 ` Alan Stern
2020-09-14 15:23 ` Greg Kroah-Hartman
2020-09-14 15:23 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 05/11] USB: legousbtower: use usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 06/11] sound: usx2y: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 07/11] sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 08/11] sound: line6: " Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 09/11] sound: hiface: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 10/11] Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman [this message]
2020-09-07 14:51 ` [PATCH v2 11/11] ALSA: remove calls to usb_pipe_type_check for control endpoints Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907145108.3766613-12-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=dvyukov@google.com \
--cc=himadrispandya@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stern@rowland.harvard.ed \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.