All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
	kbuild-all@lists.01.org, David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, Hongbo Yao <yaohongbo@huawei.com>,
	open list <linux-kernel@vger.kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Kalyan Thota <kalyan_t@codeaurora.org>,
	Drew Davenport <ddavenport@chromium.org>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 2/2] drm/msm/dpu: clean up some impossibilities
Date: Tue, 8 Sep 2020 08:27:25 +0800	[thread overview]
Message-ID: <202009080805.JrvEClw7%lkp@intel.com> (raw)
In-Reply-To: <20200907170450.370122-2-robdclark@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6086 bytes --]

Hi Rob,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.9-rc4 next-20200903]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm/drm-next drm-exynos/exynos-drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rob-Clark/drm-msm-dpu-move-vblank-events-to-complete_commit/20200908-020331
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function '_dpu_crtc_setup_cp_blocks':
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:455:23: warning: variable 'lm' set but not used [-Wunused-but-set-variable]
     455 |  struct dpu_hw_mixer *lm;
         |                       ^~
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function 'dpu_crtc_atomic_begin':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:497:21: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
     497 |  struct drm_device *dev;
         |                     ^~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:494:19: warning: variable 'dpu_crtc' set but not used [-Wunused-but-set-variable]
     494 |  struct dpu_crtc *dpu_crtc;
         |                   ^~~~~~~~

# https://github.com/0day-ci/linux/commit/b151bdc57ce4c96820a99dd0c5cec106f227444c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rob-Clark/drm-msm-dpu-move-vblank-events-to-complete_commit/20200908-020331
git checkout b151bdc57ce4c96820a99dd0c5cec106f227444c
vim +/dev +497 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

4259ff7ae509ed Kalyan Thota      2020-03-24  490  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  491  static void dpu_crtc_atomic_begin(struct drm_crtc *crtc,
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  492  		struct drm_crtc_state *old_state)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  493  {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  494  	struct dpu_crtc *dpu_crtc;
9222cdd27e823c Jeykumar Sankaran 2018-09-05  495  	struct dpu_crtc_state *cstate;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  496  	struct drm_encoder *encoder;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 @497  	struct drm_device *dev;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  498  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  499  	if (!crtc->state->enable) {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  500  		DPU_DEBUG("crtc%d -> enable %d, skip atomic_begin\n",
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  501  				crtc->base.id, crtc->state->enable);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  502  		return;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  503  	}
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  504  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  505  	DPU_DEBUG("crtc%d\n", crtc->base.id);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  506  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  507  	dpu_crtc = to_dpu_crtc(crtc);
9222cdd27e823c Jeykumar Sankaran 2018-09-05  508  	cstate = to_dpu_crtc_state(crtc->state);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  509  	dev = crtc->dev;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  510  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  511  	_dpu_crtc_setup_lm_bounds(crtc, crtc->state);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  512  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  513  	/* encoder will trigger pending mask now */
4b8c6279593aa6 Sean Paul         2018-11-16  514  	drm_for_each_encoder_mask(encoder, crtc->dev, crtc->state->encoder_mask)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  515  		dpu_encoder_trigger_kickoff_pending(encoder);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  516  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  517  	/*
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  518  	 * If no mixers have been allocated in dpu_crtc_atomic_check(),
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  519  	 * it means we are trying to flush a CRTC whose state is disabled:
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  520  	 * nothing else needs to be done.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  521  	 */
9222cdd27e823c Jeykumar Sankaran 2018-09-05  522  	if (unlikely(!cstate->num_mixers))
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  523  		return;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  524  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  525  	_dpu_crtc_blend_setup(crtc);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  526  
4259ff7ae509ed Kalyan Thota      2020-03-24  527  	_dpu_crtc_setup_cp_blocks(crtc);
4259ff7ae509ed Kalyan Thota      2020-03-24  528  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  529  	/*
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  530  	 * PP_DONE irq is only used by command mode for now.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  531  	 * It is better to request pending before FLUSH and START trigger
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  532  	 * to make sure no pp_done irq missed.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  533  	 * This is safe because no pp_done will happen before SW trigger
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  534  	 * in command mode.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  535  	 */
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  536  }
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  537  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53198 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] drm/msm/dpu: clean up some impossibilities
Date: Tue, 08 Sep 2020 08:27:25 +0800	[thread overview]
Message-ID: <202009080805.JrvEClw7%lkp@intel.com> (raw)
In-Reply-To: <20200907170450.370122-2-robdclark@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6184 bytes --]

Hi Rob,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.9-rc4 next-20200903]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm/drm-next drm-exynos/exynos-drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rob-Clark/drm-msm-dpu-move-vblank-events-to-complete_commit/20200908-020331
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function '_dpu_crtc_setup_cp_blocks':
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:455:23: warning: variable 'lm' set but not used [-Wunused-but-set-variable]
     455 |  struct dpu_hw_mixer *lm;
         |                       ^~
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function 'dpu_crtc_atomic_begin':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:497:21: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
     497 |  struct drm_device *dev;
         |                     ^~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:494:19: warning: variable 'dpu_crtc' set but not used [-Wunused-but-set-variable]
     494 |  struct dpu_crtc *dpu_crtc;
         |                   ^~~~~~~~

# https://github.com/0day-ci/linux/commit/b151bdc57ce4c96820a99dd0c5cec106f227444c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rob-Clark/drm-msm-dpu-move-vblank-events-to-complete_commit/20200908-020331
git checkout b151bdc57ce4c96820a99dd0c5cec106f227444c
vim +/dev +497 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

4259ff7ae509ed Kalyan Thota      2020-03-24  490  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  491  static void dpu_crtc_atomic_begin(struct drm_crtc *crtc,
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  492  		struct drm_crtc_state *old_state)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  493  {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  494  	struct dpu_crtc *dpu_crtc;
9222cdd27e823c Jeykumar Sankaran 2018-09-05  495  	struct dpu_crtc_state *cstate;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  496  	struct drm_encoder *encoder;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 @497  	struct drm_device *dev;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  498  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  499  	if (!crtc->state->enable) {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  500  		DPU_DEBUG("crtc%d -> enable %d, skip atomic_begin\n",
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  501  				crtc->base.id, crtc->state->enable);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  502  		return;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  503  	}
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  504  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  505  	DPU_DEBUG("crtc%d\n", crtc->base.id);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  506  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  507  	dpu_crtc = to_dpu_crtc(crtc);
9222cdd27e823c Jeykumar Sankaran 2018-09-05  508  	cstate = to_dpu_crtc_state(crtc->state);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  509  	dev = crtc->dev;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  510  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  511  	_dpu_crtc_setup_lm_bounds(crtc, crtc->state);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  512  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  513  	/* encoder will trigger pending mask now */
4b8c6279593aa6 Sean Paul         2018-11-16  514  	drm_for_each_encoder_mask(encoder, crtc->dev, crtc->state->encoder_mask)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  515  		dpu_encoder_trigger_kickoff_pending(encoder);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  516  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  517  	/*
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  518  	 * If no mixers have been allocated in dpu_crtc_atomic_check(),
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  519  	 * it means we are trying to flush a CRTC whose state is disabled:
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  520  	 * nothing else needs to be done.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  521  	 */
9222cdd27e823c Jeykumar Sankaran 2018-09-05  522  	if (unlikely(!cstate->num_mixers))
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  523  		return;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  524  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  525  	_dpu_crtc_blend_setup(crtc);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  526  
4259ff7ae509ed Kalyan Thota      2020-03-24  527  	_dpu_crtc_setup_cp_blocks(crtc);
4259ff7ae509ed Kalyan Thota      2020-03-24  528  
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  529  	/*
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  530  	 * PP_DONE irq is only used by command mode for now.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  531  	 * It is better to request pending before FLUSH and START trigger
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  532  	 * to make sure no pp_done irq missed.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  533  	 * This is safe because no pp_done will happen before SW trigger
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  534  	 * in command mode.
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  535  	 */
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  536  }
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27  537  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 53198 bytes --]

  reply	other threads:[~2020-09-08  0:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 17:04 [PATCH 1/2] drm/msm/dpu: move vblank events to complete_commit() Rob Clark
2020-09-07 17:04 ` Rob Clark
2020-09-07 17:04 ` [PATCH 2/2] drm/msm/dpu: clean up some impossibilities Rob Clark
2020-09-07 17:04   ` Rob Clark
2020-09-08  0:27   ` kernel test robot [this message]
2020-09-08  0:27     ` kernel test robot
2020-09-08 19:44   ` abhinavk
2020-09-08 19:44   ` abhinavk
     [not found]   ` <010101746f3f7667-5ee2e9e4-9b10-41e0-8bbc-65219583cb86-000000@us-west-2.amazonses.com>
2020-09-08 20:11     ` Rob Clark
2020-09-08 20:11       ` Rob Clark
2020-09-08 20:52       ` abhinavk
2020-09-08 20:52       ` abhinavk
2020-09-08 19:06 ` [PATCH 1/2] drm/msm/dpu: move vblank events to complete_commit() abhinavk
2020-09-08 19:06 ` abhinavk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202009080805.JrvEClw7%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=airlied@linux.ie \
    --cc=ddavenport@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kalyan_t@codeaurora.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=tzimmermann@suse.de \
    --cc=yaohongbo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.