Re: [wireless-drivers-next:pending 90/109] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used

[Lee Jones <lee.jones@linaro.org>]

On Tue, 01 Sep 2020, Kalle Valo wrote:

> kernel test robot <lkp@intel.com> writes:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git pending
> > head:   391ddee90739538e99cb73bd26d7a90452d37f30
> > commit: d7f95d9204ca1a73183fde8c5a017f2060763d05 [90/109] brcmsmac: ampdu: Remove a bunch of unused variables
> > config: i386-randconfig-r015-20200901 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > reproduce (this is a W=1 build):
> >         git checkout d7f95d9204ca1a73183fde8c5a017f2060763d05
> >         # save the attached .config to linux build tree
> >         make W=1 ARCH=i386 
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >    In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:21,
> >                     from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18:
> >    drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
> >      786 | } __packed;
> >          | ^
> >    drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In
> > function 'brcms_c_ampdu_dotxstatus_complete':
> >    drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7:
> > warning: variable 'update_rate' set but not used
> > [-Wunused-but-set-variable]
> >      850 |  bool update_rate = true, retry = true;
> >          |       ^~~~~~~~~~~
> >    drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus':
> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1027:20: warning: variable 'scb_ampdu' set but not used [-Wunused-but-set-variable]
> >     1027 |  struct scb_ampdu *scb_ampdu;
> >          |                    ^~~~~~~~~
> 
> Lee, please send a followup patch to fix these issues.

Without looking into these (I will), my guess is that they are
knock-on issues from where other unused variables have been removed.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog