From: "Ján Tomko" <jtomko@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, vgoyal@redhat.com
Subject: Re: [Virtio-fs] [PATCH v2 1/6] virtiofsd: Silence gcc warning
Date: Wed, 9 Sep 2020 13:16:49 +0200 [thread overview]
Message-ID: <20200909111649.GC1377607@lpt> (raw)
In-Reply-To: <20200827153657.111098-2-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On a Thursday in 2020, Dr. David Alan Gilbert (git) wrote:
>From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
>Gcc worries fd might be used unset, in reality it's always set if
>fi is set, and only used if fi is set so it's safe. Initialise it to -1
>just to keep gcc happy for now.
>
>Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Ján Tomko" <jtomko@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: virtio-fs@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
vgoyal@redhat.com
Subject: Re: [PATCH v2 1/6] virtiofsd: Silence gcc warning
Date: Wed, 9 Sep 2020 13:16:49 +0200 [thread overview]
Message-ID: <20200909111649.GC1377607@lpt> (raw)
In-Reply-To: <20200827153657.111098-2-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On a Thursday in 2020, Dr. David Alan Gilbert (git) wrote:
>From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
>Gcc worries fd might be used unset, in reality it's always set if
>fi is set, and only used if fi is set so it's safe. Initialise it to -1
>just to keep gcc happy for now.
>
>Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-09 11:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:36 [Virtio-fs] [PATCH v2 0/6] virtiofsd xattr name mappings Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 1/6] virtiofsd: Silence gcc warning Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-09-09 11:16 ` Ján Tomko [this message]
2020-09-09 11:16 ` Ján Tomko
2020-10-07 10:42 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-07 10:42 ` Dr. David Alan Gilbert
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 2/6] virtiofsd: Add printf checking to fuse_log Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 3/6] tools/virtiofsd: xattr name mappings: Add option Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-09-09 11:20 ` [Virtio-fs] " Ján Tomko
2020-09-09 11:20 ` Ján Tomko
2020-09-10 18:38 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-10 18:38 ` Dr. David Alan Gilbert
2020-09-11 21:13 ` [Virtio-fs] " Vivek Goyal
2020-09-11 21:13 ` Vivek Goyal
2020-09-18 17:38 ` Dr. David Alan Gilbert
2020-09-18 17:38 ` Dr. David Alan Gilbert
2020-10-20 17:20 ` Vivek Goyal
2020-10-06 15:51 ` Christophe de Dinechin
2020-10-06 15:51 ` Christophe de Dinechin
2020-10-14 15:40 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 15:40 ` Dr. David Alan Gilbert
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 4/6] tools/virtiofsd: xattr name mappings: Map client xattr names Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 5/6] tools/virtiofsd: xattr name mappings: Map server " Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-10-06 16:03 ` [Virtio-fs] " Christophe de Dinechin
2020-10-06 16:03 ` Christophe de Dinechin
2020-10-14 16:04 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-14 16:04 ` Dr. David Alan Gilbert
2020-10-06 16:17 ` [Virtio-fs] " Christophe de Dinechin
2020-10-06 16:17 ` Christophe de Dinechin
2020-08-27 15:36 ` [Virtio-fs] [PATCH v2 6/6] tools/virtiofsd: xattr name mapping examples Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` Dr. David Alan Gilbert (git)
2020-09-09 11:35 ` [Virtio-fs] " Ján Tomko
2020-09-09 11:35 ` Ján Tomko
2020-09-10 18:42 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-10 18:42 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909111649.GC1377607@lpt \
--to=jtomko@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.