From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 10 Sep 2020 10:18:14 +0200 [thread overview]
Message-ID: <20200910081814.GB28357@amd> (raw)
In-Reply-To: <CAE+NS35FETQ9ASJeYP=Sa8dm7ohRBcdAwUioCAnHPY2TiD4pNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
Hi!
> > > +enum {
> > > + MT6360_LED_ISNK1 = 0,
> > > + MT6360_LED_ISNK2,
> > > + MT6360_LED_ISNK3,
> > > + MT6360_LED_ISNK4,
> > > + MT6360_LED_FLASH1,
> > > + MT6360_LED_FLASH2,
> >
> > > + MT6360_MAX_LEDS,
> >
> > No comma for terminator entry.
> >
>
> ACK
Actually, that comma is fine. Its absence would be fine, too.
> > > +};
> >
> > ...
> >
> > > +#define MT6360_ISNK_MASK 0x1F
> >
> > GENMASK()
Again, that is fine.
> > > +#define FLED_TORCH_FLAG_MASK 0x0c
> >
> > > +#define FLED_STROBE_FLAG_MASK 0x03
> >
> > GENMASK()
> >
>
> ACK
Again, that is fine.
> > > + return 0;
> > > +}
> > > +
> > > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = {
> > > + { .compatible = "mediatek,mt6360-led", },
> >
> > > + {},
> >
> > No need comma.
>
> ACK
It is also no hurting comma.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
cy_huang@richtek.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
benjamin.chao@mediatek.com, Gene Chen <gene_chen@richtek.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
shufan_lee@richtek.com, Wilma.Wu@mediatek.com,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 10 Sep 2020 10:18:14 +0200 [thread overview]
Message-ID: <20200910081814.GB28357@amd> (raw)
In-Reply-To: <CAE+NS35FETQ9ASJeYP=Sa8dm7ohRBcdAwUioCAnHPY2TiD4pNA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]
Hi!
> > > +enum {
> > > + MT6360_LED_ISNK1 = 0,
> > > + MT6360_LED_ISNK2,
> > > + MT6360_LED_ISNK3,
> > > + MT6360_LED_ISNK4,
> > > + MT6360_LED_FLASH1,
> > > + MT6360_LED_FLASH2,
> >
> > > + MT6360_MAX_LEDS,
> >
> > No comma for terminator entry.
> >
>
> ACK
Actually, that comma is fine. Its absence would be fine, too.
> > > +};
> >
> > ...
> >
> > > +#define MT6360_ISNK_MASK 0x1F
> >
> > GENMASK()
Again, that is fine.
> > > +#define FLED_TORCH_FLAG_MASK 0x0c
> >
> > > +#define FLED_STROBE_FLAG_MASK 0x03
> >
> > GENMASK()
> >
>
> ACK
Again, that is fine.
> > > + return 0;
> > > +}
> > > +
> > > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = {
> > > + { .compatible = "mediatek,mt6360-led", },
> >
> > > + {},
> >
> > No need comma.
>
> ACK
It is also no hurting comma.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
cy_huang@richtek.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
benjamin.chao@mediatek.com, Gene Chen <gene_chen@richtek.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
shufan_lee@richtek.com, Wilma.Wu@mediatek.com,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 10 Sep 2020 10:18:14 +0200 [thread overview]
Message-ID: <20200910081814.GB28357@amd> (raw)
In-Reply-To: <CAE+NS35FETQ9ASJeYP=Sa8dm7ohRBcdAwUioCAnHPY2TiD4pNA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]
Hi!
> > > +enum {
> > > + MT6360_LED_ISNK1 = 0,
> > > + MT6360_LED_ISNK2,
> > > + MT6360_LED_ISNK3,
> > > + MT6360_LED_ISNK4,
> > > + MT6360_LED_FLASH1,
> > > + MT6360_LED_FLASH2,
> >
> > > + MT6360_MAX_LEDS,
> >
> > No comma for terminator entry.
> >
>
> ACK
Actually, that comma is fine. Its absence would be fine, too.
> > > +};
> >
> > ...
> >
> > > +#define MT6360_ISNK_MASK 0x1F
> >
> > GENMASK()
Again, that is fine.
> > > +#define FLED_TORCH_FLAG_MASK 0x0c
> >
> > > +#define FLED_STROBE_FLAG_MASK 0x03
> >
> > GENMASK()
> >
>
> ACK
Again, that is fine.
> > > + return 0;
> > > +}
> > > +
> > > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = {
> > > + { .compatible = "mediatek,mt6360-led", },
> >
> > > + {},
> >
> > No need comma.
>
> ACK
It is also no hurting comma.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-10 8:40 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 10:27 [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-07 10:27 ` [PATCH v3 1/2] " Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-08 14:13 ` Dan Murphy
2020-09-08 14:13 ` Dan Murphy
2020-09-08 14:13 ` Dan Murphy
2020-09-08 22:25 ` Pavel Machek
2020-09-08 22:25 ` Pavel Machek
2020-09-08 22:25 ` Pavel Machek
2020-09-09 23:49 ` Gene Chen
2020-09-09 23:49 ` Gene Chen
2020-09-09 23:49 ` Gene Chen
2020-09-10 12:29 ` Pavel Machek
2020-09-10 12:29 ` Pavel Machek
2020-09-10 12:29 ` Pavel Machek
2020-09-10 20:23 ` Jacek Anaszewski
2020-09-10 20:23 ` Jacek Anaszewski
2020-09-10 20:23 ` Jacek Anaszewski
2020-09-10 20:25 ` Pavel Machek
2020-09-10 20:25 ` Pavel Machek
2020-09-10 20:25 ` Pavel Machek
2020-09-10 20:31 ` Jacek Anaszewski
2020-09-10 20:31 ` Jacek Anaszewski
2020-09-10 20:31 ` Jacek Anaszewski
2020-09-09 13:48 ` Andy Shevchenko
2020-09-09 13:48 ` Andy Shevchenko
2020-09-09 13:48 ` Andy Shevchenko
2020-09-10 0:11 ` Gene Chen
2020-09-10 0:11 ` Gene Chen
2020-09-10 0:11 ` Gene Chen
2020-09-10 8:18 ` Pavel Machek [this message]
2020-09-10 8:18 ` Pavel Machek
2020-09-10 8:18 ` Pavel Machek
2020-09-10 11:34 ` Andy Shevchenko
2020-09-10 11:34 ` Andy Shevchenko
2020-09-10 11:34 ` Andy Shevchenko
2020-09-10 12:28 ` Pavel Machek
2020-09-10 12:28 ` Pavel Machek
2020-09-10 12:28 ` Pavel Machek
2020-09-10 11:46 ` Andy Shevchenko
2020-09-10 11:46 ` Andy Shevchenko
2020-09-10 11:46 ` Andy Shevchenko
2020-09-10 21:42 ` Jacek Anaszewski
2020-09-10 21:42 ` Jacek Anaszewski
2020-09-10 21:42 ` Jacek Anaszewski
2020-09-11 7:05 ` Pavel Machek
2020-09-11 7:05 ` Pavel Machek
2020-09-11 7:05 ` Pavel Machek
2020-09-10 23:24 ` Gene Chen
2020-09-10 23:24 ` Gene Chen
2020-09-10 23:24 ` Gene Chen
2020-09-11 21:21 ` Jacek Anaszewski
2020-09-11 21:21 ` Jacek Anaszewski
2020-09-11 21:21 ` Jacek Anaszewski
2020-09-11 20:56 ` Jacek Anaszewski
2020-09-11 20:56 ` Jacek Anaszewski
2020-09-11 20:56 ` Jacek Anaszewski
2020-09-07 10:27 ` [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-07 10:27 ` Gene Chen
2020-09-08 13:55 ` Dan Murphy
2020-09-08 13:55 ` Dan Murphy
2020-09-08 13:55 ` Dan Murphy
2020-09-08 22:22 ` Pavel Machek
2020-09-08 22:22 ` Pavel Machek
2020-09-08 22:22 ` Pavel Machek
2020-09-15 15:51 ` Rob Herring
2020-09-15 15:51 ` Rob Herring
2020-09-15 15:51 ` Rob Herring
2020-09-08 14:14 ` [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Dan Murphy
2020-09-08 14:14 ` Dan Murphy
2020-09-08 14:14 ` Dan Murphy
2020-09-09 0:00 ` Gene Chen
2020-09-09 0:00 ` Gene Chen
2020-09-09 0:00 ` Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910081814.GB28357@amd \
--to=pavel@ucw.cz \
--cc=Wilma.Wu@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.