From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-nfc@lists.01.org
Subject: [linux-nfc] [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable
Date: Thu, 10 Sep 2020 18:12:15 +0200 [thread overview]
Message-ID: <20200910161219.6237-5-krzk@kernel.org> (raw)
In-Reply-To: 20200910161219.6237-1-krzk@kernel.org
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-nfc@lists.01.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable
Date: Thu, 10 Sep 2020 18:12:15 +0200 [thread overview]
Message-ID: <20200910161219.6237-5-krzk@kernel.org> (raw)
In-Reply-To: <20200910161219.6237-1-krzk@kernel.org>
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-nfc@lists.01.org
Subject: [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable
Date: Thu, 10 Sep 2020 18:12:15 +0200 [thread overview]
Message-ID: <20200910161219.6237-5-krzk@kernel.org> (raw)
In-Reply-To: <20200910161219.6237-1-krzk@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-nfc@lists.01.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable
Date: Thu, 10 Sep 2020 18:12:15 +0200 [thread overview]
Message-ID: <20200910161219.6237-5-krzk@kernel.org> (raw)
In-Reply-To: <20200910161219.6237-1-krzk@kernel.org>
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-09-10 16:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:12 Krzysztof Kozlowski [this message]
2020-09-10 16:12 ` [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2020-09-11 6:08 [linux-nfc] Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-11 6:08 ` Krzysztof Kozlowski
2020-09-11 6:08 ` Krzysztof Kozlowski
2020-09-11 6:08 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 3/8] nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 2/8] dt-bindings: net: " Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 [linux-nfc] [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 22:22 ` David Miller
2020-09-10 22:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910161219.6237-5-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.