All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Guido Günther" <agx@sigxcpu.org>,
	lukas@mntmn.com,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Laurentiu Palcu" <laurentiu.palcu@nxp.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem
Date: Thu, 10 Sep 2020 20:41:41 +0200	[thread overview]
Message-ID: <20200910184141.GD893045@ravnborg.org> (raw)
In-Reply-To: <20200910080432.26dleo5wxybsacvl@fsr-ub1864-141>

Hi Laurentiu

> > > I've tested this together with a hacked up eDP bridge driver stack on
> > > my boards. The testing hasn't been really in-depth, but things seem to
> > > work fine. I have now pushed the whole series into drm-misc-next.
> > 
> > Something doesn't compile too well
> > 
> > ERROR: modpost: "__aeabi_ldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > ERROR: modpost: "__aeabi_uldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> 
> Oops... :/ I guess we need an ARM64 dependency in Kconfig. No
> 32bit NXP SoC uses this particular display controller. So, that should
> fix the compilation issue on 32bit.

Build coverage for ARM64 is an OK short term fix.

Please fix the driver so we can build test it for all architectures.
The chance to miss something when refactoring if only build for ARM64
is too high. The fix can land when it is ready, and is not urgent.

	Sam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: "Daniel Vetter" <daniel@ffwll.ch>,
	devicetree <devicetree@vger.kernel.org>,
	"Laurentiu Palcu" <laurentiu.palcu@nxp.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	lukas@mntmn.com,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem
Date: Thu, 10 Sep 2020 20:41:41 +0200	[thread overview]
Message-ID: <20200910184141.GD893045@ravnborg.org> (raw)
In-Reply-To: <20200910080432.26dleo5wxybsacvl@fsr-ub1864-141>

Hi Laurentiu

> > > I've tested this together with a hacked up eDP bridge driver stack on
> > > my boards. The testing hasn't been really in-depth, but things seem to
> > > work fine. I have now pushed the whole series into drm-misc-next.
> > 
> > Something doesn't compile too well
> > 
> > ERROR: modpost: "__aeabi_ldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > ERROR: modpost: "__aeabi_uldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> 
> Oops... :/ I guess we need an ARM64 dependency in Kconfig. No
> 32bit NXP SoC uses this particular display controller. So, that should
> fix the compilation issue on 32bit.

Build coverage for ARM64 is an OK short term fix.

Please fix the driver so we can build test it for all architectures.
The chance to miss something when refactoring if only build for ARM64
is too high. The fix can land when it is ready, and is not urgent.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Guido Günther" <agx@sigxcpu.org>,
	lukas@mntmn.com,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Laurentiu Palcu" <laurentiu.palcu@nxp.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem
Date: Thu, 10 Sep 2020 20:41:41 +0200	[thread overview]
Message-ID: <20200910184141.GD893045@ravnborg.org> (raw)
In-Reply-To: <20200910080432.26dleo5wxybsacvl@fsr-ub1864-141>

Hi Laurentiu

> > > I've tested this together with a hacked up eDP bridge driver stack on
> > > my boards. The testing hasn't been really in-depth, but things seem to
> > > work fine. I have now pushed the whole series into drm-misc-next.
> > 
> > Something doesn't compile too well
> > 
> > ERROR: modpost: "__aeabi_ldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > ERROR: modpost: "__aeabi_uldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> 
> Oops... :/ I guess we need an ARM64 dependency in Kconfig. No
> 32bit NXP SoC uses this particular display controller. So, that should
> fix the compilation issue on 32bit.

Build coverage for ARM64 is an OK short term fix.

Please fix the driver so we can build test it for all architectures.
The chance to miss something when refactoring if only build for ARM64
is too high. The fix can land when it is ready, and is not urgent.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-09-10 18:43 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  8:18 [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu
2020-07-31  8:18 ` Laurentiu Palcu
2020-07-31  8:18 ` Laurentiu Palcu
2020-07-31  8:18 ` [PATCH v9 1/5] drm/imx: compile imx directory by default Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:46   ` Guido Günther
2020-07-31  8:46     ` Guido Günther
2020-07-31  8:18 ` [PATCH v9 2/5] drm/imx: Add initial support for DCSS on iMX8MQ Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:56   ` Guido Günther
2020-07-31  8:56     ` Guido Günther
2020-07-31  8:18 ` [PATCH v9 3/5] drm/imx/dcss: use drm_bridge_connector API Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:18 ` [PATCH v9 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:48   ` Guido Günther
2020-07-31  8:48     ` Guido Günther
2020-07-31  8:18 ` [PATCH v9 5/5] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:18   ` Laurentiu Palcu
2020-07-31  8:52   ` Guido Günther
2020-07-31  8:52     ` Guido Günther
2020-07-31  8:52     ` Guido Günther
2020-07-31 19:34   ` Rob Herring
2020-07-31 19:34     ` Rob Herring
2020-07-31 19:34     ` Rob Herring
2020-07-31  8:54 ` [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem Guido Günther
2020-07-31  8:54   ` Guido Günther
2020-07-31  8:54   ` Guido Günther
2020-09-05 11:49   ` Guido Günther
2020-09-05 11:49     ` Guido Günther
2020-09-05 11:49     ` Guido Günther
2020-08-28  8:36 ` Laurentiu Palcu
2020-08-28  8:36   ` Laurentiu Palcu
2020-08-28  8:36   ` Laurentiu Palcu
2020-08-29  7:25   ` Sam Ravnborg
2020-08-29  7:25     ` Sam Ravnborg
2020-08-29  7:25     ` Sam Ravnborg
2020-08-31 10:37   ` Lucas Stach
2020-08-31 10:37     ` Lucas Stach
2020-08-31 10:37     ` Lucas Stach
2020-08-31 11:24     ` Laurentiu Palcu
2020-08-31 11:24       ` Laurentiu Palcu
2020-08-31 11:24       ` Laurentiu Palcu
2020-09-09 15:02       ` Lucas Stach
2020-09-09 15:02         ` Lucas Stach
2020-09-09 15:02         ` Lucas Stach
2020-09-10  6:47         ` Daniel Vetter
2020-09-10  6:47           ` Daniel Vetter
2020-09-10  6:47           ` Daniel Vetter
2020-09-10  8:04           ` Laurentiu Palcu
2020-09-10  8:04             ` Laurentiu Palcu
2020-09-10  8:04             ` Laurentiu Palcu
2020-09-10 18:41             ` Sam Ravnborg [this message]
2020-09-10 18:41               ` Sam Ravnborg
2020-09-10 18:41               ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910184141.GD893045@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=agx@sigxcpu.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=laurentiu.palcu@nxp.com \
    --cc=laurentiu.palcu@oss.nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@mntmn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.