From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: khilman@kernel.org, linux@armlinux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] omap3: enable off mode automatically
Date: Fri, 11 Sep 2020 13:33:37 +0300 [thread overview]
Message-ID: <20200911103337.GH7101@atomide.com> (raw)
In-Reply-To: <20200911064924.26281-1-andreas@kemnade.info>
* Andreas Kemnade <andreas@kemnade.info> [200911 09:50]:
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void)
> extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
> extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
>
> -#ifdef CONFIG_PM_DEBUG
> extern u32 enable_off_mode;
> -#else
> -#define enable_off_mode 0
> -#endif
Hmm isn't the above still needed for the other SoCs? Or is omap3 the only
user?
Otherwise looks good to me :)
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: linux-omap@vger.kernel.org, khilman@kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
letux-kernel@openphoenux.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap3: enable off mode automatically
Date: Fri, 11 Sep 2020 13:33:37 +0300 [thread overview]
Message-ID: <20200911103337.GH7101@atomide.com> (raw)
In-Reply-To: <20200911064924.26281-1-andreas@kemnade.info>
* Andreas Kemnade <andreas@kemnade.info> [200911 09:50]:
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void)
> extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
> extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
>
> -#ifdef CONFIG_PM_DEBUG
> extern u32 enable_off_mode;
> -#else
> -#define enable_off_mode 0
> -#endif
Hmm isn't the above still needed for the other SoCs? Or is omap3 the only
user?
Otherwise looks good to me :)
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-11 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 6:49 [PATCH] omap3: enable off mode automatically Andreas Kemnade
2020-09-11 6:49 ` Andreas Kemnade
2020-09-11 10:33 ` Tony Lindgren [this message]
2020-09-11 10:33 ` Tony Lindgren
2020-09-11 14:27 ` Andreas Kemnade
2020-09-11 14:27 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911103337.GH7101@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=khilman@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.