All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean
Date: Fri, 11 Sep 2020 12:00:05 -0700	[thread overview]
Message-ID: <20200911120005.00000178@intel.com> (raw)
In-Reply-To: <20200911075515.6d81066b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Jakub Kicinski wrote:

> On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote:
> > Some of these patches are already sent to Intel Wired Lan, but the rest
> > of the series titled drivers/net/ethernet affects other drivers, not
> > just Intel, but they depend on the first five.
> 
> Great stuff. Much easier to apply one large series than a thousand
> small patches. I haven't read all the comment changes but FWIW:
> 
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Thanks!

> I feel slightly bad for saying this but I think your config did not
> include all the drivers, 'cause I'm still getting some warnings after
> patch 11. Regardless this is impressive effort, thanks!

No worries! I want to get it right, can you share your methodology?

I saw from some other message that you're doing
make CC="ccache gcc" allmodconfig
make CC="ccache gcc" -j 64 W=1 C=1

Is that the right sequence? did you start with a make mrproper as well?
I may have missed some drivers when I did this:
make allyesconfig
make menuconfig
<turn on all "Ethernet Drivers" = m manually>

but I'd like to target the actual job you're running and use that as
the short-term goal.

Also, if you have any comments about the removal of the lvalue from
some of the register read operations, I figure that is the riskiest
part of all this.

WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean
Date: Fri, 11 Sep 2020 12:00:05 -0700	[thread overview]
Message-ID: <20200911120005.00000178@intel.com> (raw)
In-Reply-To: <20200911075515.6d81066b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Jakub Kicinski wrote:

> On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote:
> > Some of these patches are already sent to Intel Wired Lan, but the rest
> > of the series titled drivers/net/ethernet affects other drivers, not
> > just Intel, but they depend on the first five.
> 
> Great stuff. Much easier to apply one large series than a thousand
> small patches. I haven't read all the comment changes but FWIW:
> 
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Thanks!

> I feel slightly bad for saying this but I think your config did not
> include all the drivers, 'cause I'm still getting some warnings after
> patch 11. Regardless this is impressive effort, thanks!

No worries! I want to get it right, can you share your methodology?

I saw from some other message that you're doing
make CC="ccache gcc" allmodconfig
make CC="ccache gcc" -j 64 W=1 C=1

Is that the right sequence? did you start with a make mrproper as well?
I may have missed some drivers when I did this:
make allyesconfig
make menuconfig
<turn on all "Ethernet Drivers" = m manually>

but I'd like to target the actual job you're running and use that as
the short-term goal.

Also, if you have any comments about the removal of the lvalue from
some of the register read operations, I figure that is the riskiest
part of all this.

  reply	other threads:[~2020-09-11 19:00 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  1:23 [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jesse Brandeburg
2020-09-11  1:23 ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-23  2:02   ` [Intel-wired-lan] " Brown, Aaron F
2020-09-23  2:02     ` Brown, Aaron F
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-23  3:12   ` [Intel-wired-lan] " Brown, Aaron F
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-23  3:57   ` [Intel-wired-lan] " Brown, Aaron F
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11 17:43   ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-11 17:43     ` Vinicius Costa Gomes
2020-09-11 23:06     ` Jacob Keller
2020-09-11 23:28     ` Jesse Brandeburg
2020-09-11 23:28       ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11 17:16   ` [Intel-wired-lan] " Edward Cree
2020-09-11 17:16     ` Edward Cree
2020-09-11 23:03   ` [Intel-wired-lan] " Jacob Keller
2020-09-11 23:18     ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11 22:56   ` [Intel-wired-lan] " Jacob Keller
2020-09-11 22:56     ` Jacob Keller
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11 22:59   ` [Intel-wired-lan] " Jacob Keller
2020-09-11 23:25     ` Jesse Brandeburg
2020-09-14 23:06       ` Jacob Keller
2020-09-11  1:23 ` [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg
2020-09-11  1:23   ` Jesse Brandeburg
2020-09-11 17:26   ` [Intel-wired-lan] " Edward Cree
2020-09-11 17:26     ` Edward Cree
2020-09-11 21:42     ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-11 21:42       ` Jesse Brandeburg
2020-09-11 21:55       ` [Intel-wired-lan] " Edward Cree
2020-09-11 21:55         ` Edward Cree
2020-09-11 22:26         ` [Intel-wired-lan] " Jakub Kicinski
2020-09-11 22:26           ` Jakub Kicinski
2020-09-11 23:11           ` [Intel-wired-lan] " Edward Cree
2020-09-11 23:11             ` Edward Cree
2020-09-12  0:49             ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-12  0:49               ` Jesse Brandeburg
2020-09-14  3:04             ` [Intel-wired-lan] " Andrew Lunn
2020-09-14  3:04               ` Andrew Lunn
2020-09-11 14:55 ` [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jakub Kicinski
2020-09-11 14:55   ` Jakub Kicinski
2020-09-11 19:00   ` Jesse Brandeburg [this message]
2020-09-11 19:00     ` Jesse Brandeburg
2020-09-11 20:12     ` [Intel-wired-lan] " Jakub Kicinski
2020-09-11 20:12       ` Jakub Kicinski
2020-09-11 21:34       ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-11 21:34         ` Jesse Brandeburg
2020-09-11 22:16         ` [Intel-wired-lan] " Jakub Kicinski
2020-09-11 22:16           ` Jakub Kicinski
2020-09-11 22:43         ` [Intel-wired-lan] " Vladimir Oltean
2020-09-11 22:43           ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911120005.00000178@intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.