From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy
Date: Fri, 11 Sep 2020 14:05:19 +0200 [thread overview]
Message-ID: <20200911120519.GA9758@ranger.igk.intel.com> (raw)
In-Reply-To: <1599826106-19020-1-git-send-email-magnus.karlsson@gmail.com>
On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some
> reason, we only allowed main VSIs to be used with zero-copy, but
> there is now reason to not allow VMDQs also.
You meant 'to allow' I suppose. And what reason? :)
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 2a1153d..ebe15ca 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -45,7 +45,7 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi,
> bool if_running;
> int err;
>
> - if (vsi->type != I40E_VSI_MAIN)
> + if (!(vsi->type == I40E_VSI_MAIN || vsi->type == I40E_VSI_VMDQ2))
> return -EINVAL;
>
> if (qid >= vsi->num_queue_pairs)
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: magnus.karlsson@intel.com, bjorn.topel@intel.com,
intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, maciejromanfijalkowski@gmail.com
Subject: Re: [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy
Date: Fri, 11 Sep 2020 14:05:19 +0200 [thread overview]
Message-ID: <20200911120519.GA9758@ranger.igk.intel.com> (raw)
In-Reply-To: <1599826106-19020-1-git-send-email-magnus.karlsson@gmail.com>
On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Allow VMDQs to be used with AF_XDP sockets in zero-copy mode. For some
> reason, we only allowed main VSIs to be used with zero-copy, but
> there is now reason to not allow VMDQs also.
You meant 'to allow' I suppose. And what reason? :)
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 2a1153d..ebe15ca 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -45,7 +45,7 @@ static int i40e_xsk_pool_enable(struct i40e_vsi *vsi,
> bool if_running;
> int err;
>
> - if (vsi->type != I40E_VSI_MAIN)
> + if (!(vsi->type == I40E_VSI_MAIN || vsi->type == I40E_VSI_VMDQ2))
> return -EINVAL;
>
> if (qid >= vsi->num_queue_pairs)
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-09-11 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:08 [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy Magnus Karlsson
2020-09-11 12:08 ` Magnus Karlsson
2020-09-11 12:05 ` Maciej Fijalkowski [this message]
2020-09-11 12:05 ` Maciej Fijalkowski
2020-09-11 12:29 ` [Intel-wired-lan] " Magnus Karlsson
2020-09-11 12:29 ` Magnus Karlsson
2020-09-11 13:10 ` [Intel-wired-lan] " Maciej Fijalkowski
2020-09-11 13:10 ` Maciej Fijalkowski
2020-09-11 18:04 ` [Intel-wired-lan] " Samudrala, Sridhar
2020-09-11 18:04 ` Samudrala, Sridhar
2020-09-11 18:41 ` Alexander Duyck
2020-09-11 18:41 ` Alexander Duyck
2020-09-14 10:10 ` Magnus Karlsson
2020-09-14 10:10 ` Magnus Karlsson
2020-09-11 15:33 ` Jakub Kicinski
2020-09-11 15:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911120519.GA9758@ranger.igk.intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.