From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: translate zns errors to blk_status_t
Date: Sat, 12 Sep 2020 08:41:04 +0200 [thread overview]
Message-ID: <20200912064104.GA19223@lst.de> (raw)
In-Reply-To: <CY4PR04MB3751B5CEE2967C1B3B29554CE7240@CY4PR04MB3751.namprd04.prod.outlook.com>
On Fri, Sep 11, 2020 at 09:35:31AM +0000, Damien Le Moal wrote:
> On 2020/09/11 15:10, Christoph Hellwig wrote:
> > On Thu, Sep 10, 2020 at 10:25:24PM +0000, Damien Le Moal wrote:
> >>> I'm not sure this is the best idea, we probably need specific error codes
> >>> if we want file systems to be aware of the limit.
> >>
> >> Do you mean something else than -EBUSY being returned to the user by the block
> >> layer ? Or a different/specific BLK_STS_XXX code which translates into -EBUSY in
> >> blk_status_to_errno() ?
> >
> > My primary aim is a different BLK_STS_ code. But given that I think
> > that we should not map different BLK_STS_ codes to the same errno if
> > we can avoid it, we should probably also use a different errno.
> >
>
> Hmm. Beside EBUSY, I do not see a nice existing errno that we can reuse. May be
> ENOSR (out of stream resources) ? Or do we define a new one ? EZBUSY ?
>
> And indeed if we define a new BLK_STS_ZONE_RESOURCE and map that to EBUSY,
> errno_to_blkstatus() will get confused.
Yes, you need to pick a new error. I don't really care which one,
most of the mappings are pretty odd anyway.
>
>
> --
> Damien Le Moal
> Western Digital Research
---end quoted text---
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-12 6:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:33 [PATCH] nvme: translate zns errors to blk_status_t Keith Busch
2020-09-09 20:52 ` Sagi Grimberg
2020-09-10 0:44 ` Damien Le Moal
2020-09-10 5:26 ` Christoph Hellwig
2020-09-10 14:45 ` Keith Busch
2020-09-10 22:25 ` Damien Le Moal
2020-09-11 6:10 ` Christoph Hellwig
2020-09-11 9:35 ` Damien Le Moal
2020-09-11 18:08 ` Keith Busch
2020-09-12 6:41 ` Christoph Hellwig [this message]
2020-09-14 19:44 ` Keith Busch
2020-09-14 23:25 ` Damien Le Moal
2020-09-15 2:55 ` Keith Busch
2020-09-15 2:57 ` Damien Le Moal
2020-09-15 6:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200912064104.GA19223@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.