All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Christoph Hellwig <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: translate zns errors to blk_status_t
Date: Tue, 15 Sep 2020 08:24:20 +0200	[thread overview]
Message-ID: <20200915062420.GA19022@lst.de> (raw)
In-Reply-To: <20200914194421.GC10507@redsun51.ssa.fujisawa.hgst.com>

On Tue, Sep 15, 2020 at 04:44:21AM +0900, Keith Busch wrote:
> > Yes, you need to pick a new error.  I don't really care which one,
> > most of the mappings are pretty odd anyway.
> 
> Selecting an existing unused errno feels a bit arbitrary for a status
> that is currently specific to NVMe ZNS. Could you provide a little more
> guidance on what you're looking for?

As said before: most of the errno mappins are pretty arbitrary, e.g.
take a look at the -ENOLINK, -EREMOTEIO, -EBADE, -ENODATA, -EILSEQ,
or -EREMCHG mappings.

So I think just picking a value like ECHRNG or EBADSLT or EUSERS
should be perfectly fine.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      parent reply	other threads:[~2020-09-15  6:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 20:33 [PATCH] nvme: translate zns errors to blk_status_t Keith Busch
2020-09-09 20:52 ` Sagi Grimberg
2020-09-10  0:44 ` Damien Le Moal
2020-09-10  5:26 ` Christoph Hellwig
2020-09-10 14:45   ` Keith Busch
2020-09-10 22:25   ` Damien Le Moal
2020-09-11  6:10     ` Christoph Hellwig
2020-09-11  9:35       ` Damien Le Moal
2020-09-11 18:08         ` Keith Busch
2020-09-12  6:41         ` Christoph Hellwig
2020-09-14 19:44           ` Keith Busch
2020-09-14 23:25             ` Damien Le Moal
2020-09-15  2:55               ` Keith Busch
2020-09-15  2:57                 ` Damien Le Moal
2020-09-15  6:24             ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915062420.GA19022@lst.de \
    --to=hch@lst.de \
    --cc=Damien.LeMoal@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.