From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH][next][v2] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer
Date: Mon, 14 Sep 2020 16:24:18 -0700 [thread overview]
Message-ID: <20200914162418.00007393@intel.com> (raw)
In-Reply-To: <1598592392-30673-1-git-send-email-lirongqing@baidu.com>
Li RongQing wrote:
> when changes the rx/tx ring to 4096, kzalloc may fail due to
> a temporary shortage on slab entries.
>
> so using kvmalloc to allocate this memory as there is no need
> that this memory area is physical continuously.
>
> and using __GFP_RETRY_MAYFAIL to allocate from kmalloc as
> far as possible, which can reduce TLB pressure than vmalloc
> as suggested by Eric Dumazet
This change is no good, it's using RETRY_MAYFAIL but still using
v*alloc.
Please see my replies to the i40e version of the patch. I don't think
we should apply these.
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<edumazet@google.com>
Subject: Re: [PATCH][next][v2] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer
Date: Mon, 14 Sep 2020 16:24:18 -0700 [thread overview]
Message-ID: <20200914162418.00007393@intel.com> (raw)
In-Reply-To: <1598592392-30673-1-git-send-email-lirongqing@baidu.com>
Li RongQing wrote:
> when changes the rx/tx ring to 4096, kzalloc may fail due to
> a temporary shortage on slab entries.
>
> so using kvmalloc to allocate this memory as there is no need
> that this memory area is physical continuously.
>
> and using __GFP_RETRY_MAYFAIL to allocate from kmalloc as
> far as possible, which can reduce TLB pressure than vmalloc
> as suggested by Eric Dumazet
This change is no good, it's using RETRY_MAYFAIL but still using
v*alloc.
Please see my replies to the i40e version of the patch. I don't think
we should apply these.
next prev parent reply other threads:[~2020-09-14 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 5:26 [Intel-wired-lan] [PATCH][next][v2] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer Li RongQing
2020-08-28 5:26 ` Li RongQing
2020-09-14 23:24 ` Jesse Brandeburg [this message]
2020-09-14 23:24 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914162418.00007393@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.