All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: imx6ul_tsc - clean up some errors in imx6ul_tsc_resume()
Date: Mon, 14 Sep 2020 17:49:52 +0000	[thread overview]
Message-ID: <20200914174952.GS1665100@dtor-ws> (raw)
In-Reply-To: <20200905124942.GC183976@mwanda>

On Sat, Sep 05, 2020 at 03:49:42PM +0300, Dan Carpenter wrote:
> If imx6ul_tsc_init() fails then we need to clean up the clocks.
> 
> I reversed the "if (input_dev->users) {" condition to make the code a
> bit simpler.
> 
> Fixes: 6cc527b05847 ("Input: imx6ul_tsc - propagate the errors")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thank you.

There is also an opportunity to factor out some common code from
open/close and suspend/resume, I'll send out a patch in a moment.

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: imx6ul_tsc - clean up some errors in imx6ul_tsc_resume()
Date: Mon, 14 Sep 2020 10:49:52 -0700	[thread overview]
Message-ID: <20200914174952.GS1665100@dtor-ws> (raw)
In-Reply-To: <20200905124942.GC183976@mwanda>

On Sat, Sep 05, 2020 at 03:49:42PM +0300, Dan Carpenter wrote:
> If imx6ul_tsc_init() fails then we need to clean up the clocks.
> 
> I reversed the "if (input_dev->users) {" condition to make the code a
> bit simpler.
> 
> Fixes: 6cc527b05847 ("Input: imx6ul_tsc - propagate the errors")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thank you.

There is also an opportunity to factor out some common code from
open/close and suspend/resume, I'll send out a patch in a moment.

Thanks.

-- 
Dmitry

  reply	other threads:[~2020-09-14 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 12:49 [PATCH] Input: imx6ul_tsc - clean up some errors in imx6ul_tsc_resume() Dan Carpenter
2020-09-05 12:49 ` Dan Carpenter
2020-09-14 17:49 ` Dmitry Torokhov [this message]
2020-09-14 17:49   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914174952.GS1665100@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=festevam@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.