[PATCH] misc: hisi_hikey_usb: fix the uninitialized ret

[PATCH] misc: hisi_hikey_usb: fix the uninitialized ret

[Wei Xu]

The uninitialized ret in hisi_hikey_usb_parse_kirin970 is useless.
Simply remove it and return 0 on success to fix the issue reported
by Coverity Scan.

Fixes: d210a0023590 ("misc: hisi_hikey_usb: add support for Hikey 970")
Signed-off-by: Wei Xu <xuwei5@hisilicon.com>
---
 drivers/misc/hisi_hikey_usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c
index 2ddd4072788d..5759e7209023 100644
--- a/drivers/misc/hisi_hikey_usb.c
+++ b/drivers/misc/hisi_hikey_usb.c
@@ -151,7 +151,6 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,
 					 struct hisi_hikey_usb *hisi_hikey_usb)
 {
 	struct regulator *regulator;
-	int ret;
 
 	regulator = devm_regulator_get(&pdev->dev, "hub-vdd");
 	if (IS_ERR(regulator)) {
@@ -172,7 +171,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,
 	if (IS_ERR(hisi_hikey_usb->reset))
 		return PTR_ERR(hisi_hikey_usb->reset);
 
-	return ret;
+	return 0;
 }
 
 static int hisi_hikey_usb_probe(struct platform_device *pdev)
-- 
2.8.1

Re: [PATCH] misc: hisi_hikey_usb: fix the uninitialized ret

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hi Wei,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20200914]
[cannot apply to char-misc/char-misc-testing v5.9-rc5 v5.9-rc4 v5.9-rc3 v5.9-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wei-Xu/misc-hisi_hikey_usb-fix-the-uninitialized-ret/20200915-110654
base:    f965d3ec86fa89285db0fbb983da76ba9c398efa
config: x86_64-randconfig-c004-20200915 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/misc/hisi_hikey_usb.c:171:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36244 bytes --]

[PATCH] misc: hisi_hikey_usb: fix ptr_ret.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/misc/hisi_hikey_usb.c:171:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Wei Xu <xuwei5@hisilicon.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Wei-Xu/misc-hisi_hikey_usb-fix-the-uninitialized-ret/20200915-110654
base:    f965d3ec86fa89285db0fbb983da76ba9c398efa

 hisi_hikey_usb.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/misc/hisi_hikey_usb.c
+++ b/drivers/misc/hisi_hikey_usb.c
@@ -168,10 +168,7 @@ static int hisi_hikey_usb_parse_kirin970
 
 	hisi_hikey_usb->reset = devm_gpiod_get(&pdev->dev, "hub_reset_en_gpio",
 					       GPIOD_OUT_HIGH);
-	if (IS_ERR(hisi_hikey_usb->reset))
-		return PTR_ERR(hisi_hikey_usb->reset);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(hisi_hikey_usb->reset);
 }
 
 static int hisi_hikey_usb_probe(struct platform_device *pdev)