From: Andrew Lunn <andrew@lunn.ch>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean
Date: Tue, 15 Sep 2020 22:43:59 +0200 [thread overview]
Message-ID: <20200915204359.GF3526428@lunn.ch> (raw)
In-Reply-To: <734f0c4595a18ab136263b6e5c97e7f48a93abe1.camel@kernel.org>
> Yes we can have our own gcc options in the Makfile regardless of what
> you put in W command line argument.
>
> Example:
>
> KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter
> KBUILD_CFLAGS += -Wmissing-declarations
> KBUILD_CFLAGS += -Wmissing-format-attribute
> KBUILD_CFLAGS += -Wmissing-prototypes
> KBUILD_CFLAGS += -Wold-style-definition
> KBUILD_CFLAGS += -Wmissing-include-dirs
How about something like this, so we get whatever W=1 means.
Andrew
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 72e18d505d1a..d4e125831d1c 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -3,6 +3,9 @@
# Makefile for the Linux network device drivers.
#
+# Enable W=1 by default
+subdir-ccflags-y := $(KBUILD_CFLAGS_WARN1)
+
#
# Networking Core Drivers
#
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 95e4cdb94fe9..bf0de3502849 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -20,23 +20,26 @@ export KBUILD_EXTRA_WARN
#
# W=1 - warnings which may be relevant and do not occur too often
#
-ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),)
-
-KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter
-KBUILD_CFLAGS += -Wmissing-declarations
-KBUILD_CFLAGS += -Wmissing-format-attribute
-KBUILD_CFLAGS += -Wmissing-prototypes
-KBUILD_CFLAGS += -Wold-style-definition
-KBUILD_CFLAGS += -Wmissing-include-dirs
-KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)
-KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable)
-KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned)
-KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation)
+KBUILD_CFLAGS_WARN1 += -Wextra -Wunused -Wno-unused-parameter
+KBUILD_CFLAGS_WARN1 += -Wmissing-declarations
+KBUILD_CFLAGS_WARN1 += -Wmissing-format-attribute
+KBUILD_CFLAGS_WARN1 += -Wmissing-prototypes
+KBUILD_CFLAGS_WARN1 += -Wold-style-definition
+KBUILD_CFLAGS_WARN1 += -Wmissing-include-dirs
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wunused-but-set-variable)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wunused-const-variable)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wpacked-not-aligned)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wstringop-truncation)
# The following turn off the warnings enabled by -Wextra
-KBUILD_CFLAGS += -Wno-missing-field-initializers
-KBUILD_CFLAGS += -Wno-sign-compare
-KBUILD_CFLAGS += -Wno-type-limits
+KBUILD_CFLAGS_WARN1 += -Wno-missing-field-initializers
+KBUILD_CFLAGS_WARN1 += -Wno-sign-compare
+KBUILD_CFLAGS_WARN1 += -Wno-type-limits
+
+export KBUILD_CFLAGS_WARN1
+
+ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),)
+KBUILD_CFLAGS += $(KBUILD_CFLAGS_WARN1)
KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN1
else
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean
Date: Tue, 15 Sep 2020 22:43:59 +0200 [thread overview]
Message-ID: <20200915204359.GF3526428@lunn.ch> (raw)
In-Reply-To: <734f0c4595a18ab136263b6e5c97e7f48a93abe1.camel@kernel.org>
> Yes we can have our own gcc options in the Makfile regardless of what
> you put in W command line argument.
>
> Example:
>
> KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter
> KBUILD_CFLAGS += -Wmissing-declarations
> KBUILD_CFLAGS += -Wmissing-format-attribute
> KBUILD_CFLAGS += -Wmissing-prototypes
> KBUILD_CFLAGS += -Wold-style-definition
> KBUILD_CFLAGS += -Wmissing-include-dirs
How about something like this, so we get whatever W=1 means.
Andrew
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 72e18d505d1a..d4e125831d1c 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -3,6 +3,9 @@
# Makefile for the Linux network device drivers.
#
+# Enable W=1 by default
+subdir-ccflags-y := $(KBUILD_CFLAGS_WARN1)
+
#
# Networking Core Drivers
#
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 95e4cdb94fe9..bf0de3502849 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -20,23 +20,26 @@ export KBUILD_EXTRA_WARN
#
# W=1 - warnings which may be relevant and do not occur too often
#
-ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),)
-
-KBUILD_CFLAGS += -Wextra -Wunused -Wno-unused-parameter
-KBUILD_CFLAGS += -Wmissing-declarations
-KBUILD_CFLAGS += -Wmissing-format-attribute
-KBUILD_CFLAGS += -Wmissing-prototypes
-KBUILD_CFLAGS += -Wold-style-definition
-KBUILD_CFLAGS += -Wmissing-include-dirs
-KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)
-KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable)
-KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned)
-KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation)
+KBUILD_CFLAGS_WARN1 += -Wextra -Wunused -Wno-unused-parameter
+KBUILD_CFLAGS_WARN1 += -Wmissing-declarations
+KBUILD_CFLAGS_WARN1 += -Wmissing-format-attribute
+KBUILD_CFLAGS_WARN1 += -Wmissing-prototypes
+KBUILD_CFLAGS_WARN1 += -Wold-style-definition
+KBUILD_CFLAGS_WARN1 += -Wmissing-include-dirs
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wunused-but-set-variable)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wunused-const-variable)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wpacked-not-aligned)
+KBUILD_CFLAGS_WARN1 += $(call cc-option, -Wstringop-truncation)
# The following turn off the warnings enabled by -Wextra
-KBUILD_CFLAGS += -Wno-missing-field-initializers
-KBUILD_CFLAGS += -Wno-sign-compare
-KBUILD_CFLAGS += -Wno-type-limits
+KBUILD_CFLAGS_WARN1 += -Wno-missing-field-initializers
+KBUILD_CFLAGS_WARN1 += -Wno-sign-compare
+KBUILD_CFLAGS_WARN1 += -Wno-type-limits
+
+export KBUILD_CFLAGS_WARN1
+
+ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),)
+KBUILD_CFLAGS += $(KBUILD_CFLAGS_WARN1)
KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN1
else
next prev parent reply other threads:[~2020-09-15 20:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 1:44 [Intel-wired-lan] [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 01/10] i40e: prepare flash string in a simpler way Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 02/10] intel-ethernet: clean up W=1 warnings in kdoc Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 03/10] intel: handle unused assignments Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 04/10] drivers/net/ethernet: clean up " Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 9:02 ` [Intel-wired-lan] " Edward Cree
2020-09-15 9:02 ` Edward Cree
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 05/10] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 06/10] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 3:25 ` [Intel-wired-lan] " Saeed Mahameed
2020-09-15 3:25 ` Saeed Mahameed
2020-09-15 16:41 ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-15 16:41 ` Jesse Brandeburg
2020-09-17 20:06 ` [Intel-wired-lan] " Rustad, Mark D
2020-09-17 20:06 ` Rustad, Mark D
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 07/10] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 08/10] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 09/10] sfc: fix kdoc warning Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 9:05 ` [Intel-wired-lan] " Edward Cree
2020-09-15 9:05 ` Edward Cree
2020-09-15 1:44 ` [Intel-wired-lan] [PATCH net-next v2 10/10] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg
2020-09-15 1:44 ` Jesse Brandeburg
2020-09-15 4:24 ` [Intel-wired-lan] [PATCH net-next v2 00/10] make drivers/net/ethernet W=1 clean Saeed Mahameed
2020-09-15 4:24 ` Saeed Mahameed
2020-09-15 14:03 ` [Intel-wired-lan] " Andrew Lunn
2020-09-15 14:03 ` Andrew Lunn
2020-09-15 20:03 ` [Intel-wired-lan] " Saeed Mahameed
2020-09-15 20:03 ` Saeed Mahameed
2020-09-15 20:43 ` Andrew Lunn [this message]
2020-09-15 20:43 ` Andrew Lunn
2020-09-15 22:37 ` [Intel-wired-lan] " David Miller
2020-09-15 22:37 ` David Miller
2020-09-15 15:58 ` [Intel-wired-lan] " Jakub Kicinski
2020-09-15 15:58 ` Jakub Kicinski
2020-09-15 17:11 ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-15 17:11 ` Jesse Brandeburg
2020-09-15 20:31 ` [Intel-wired-lan] " David Miller
2020-09-15 20:31 ` David Miller
2020-09-15 21:00 ` [Intel-wired-lan] " Jesse Brandeburg
2020-09-15 21:00 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915204359.GF3526428@lunn.ch \
--to=andrew@lunn.ch \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.