From: Lee Jones <lee.jones@linaro.org>
To: Allen Pais <allen.cryptic@gmail.com>
Cc: Allen Pais <allen.lkml@gmail.com>,
kune@deine-taler.de, chunkeey@googlemail.com,
jirislaby@kernel.org, brcm80211-dev-list@cypress.com,
pkshih@realtek.com, b43-dev@lists.infradead.org, dsd@gentoo.org,
ath11k@lists.infradead.org, stas.yakovlev@gmail.com,
mickflemm@gmail.com, keescook@chromium.org, kuba@kernel.org,
kvalo@codeaurora.org, brcm80211-dev-list.pdl@broadcom.com,
yhchuang@realtek.com, netdev@vger.kernel.org,
helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org,
Romain Perier <romain.perier@gmail.com>,
Larry.Finger@lwfinger.net
Subject: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API
Date: Wed, 16 Sep 2020 14:44:55 +0100 [thread overview]
Message-ID: <20200916134455.GD4678@dell> (raw)
In-Reply-To: <20200817090637.26887-11-allen.cryptic@gmail.com>
On Mon, 17 Aug 2020, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly
> and remove .data field.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++---------
> drivers/net/wireless/intersil/orinoco/main.c | 7 +++----
> drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++----
> 3 files changed, 16 insertions(+), 17 deletions(-)
This patch seems to cause several warnings along the lines of:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ?prism2_init_local_data?:
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ?void (*)(struct tasklet_struct *)? to ?void (*)(long unsigned int)? [-Wcast-function-type]
3185 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } | ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3187:2: note: in expansion of macro ?HOSTAP_TASKLET_INIT?
3187 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ?void (*)(struct tasklet_struct *)? to ?void (*)(long unsigned int)? [-Wcast-function-type]
--
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Allen Pais <allen.cryptic@gmail.com>
Cc: Allen Pais <allen.lkml@gmail.com>,
kune@deine-taler.de, chunkeey@googlemail.com,
jirislaby@kernel.org, brcm80211-dev-list@cypress.com,
pkshih@realtek.com, b43-dev@lists.infradead.org, dsd@gentoo.org,
ath11k@lists.infradead.org, stas.yakovlev@gmail.com,
mickflemm@gmail.com, keescook@chromium.org, kuba@kernel.org,
kvalo@codeaurora.org, brcm80211-dev-list.pdl@broadcom.com,
yhchuang@realtek.com, netdev@vger.kernel.org,
helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org,
Romain Perier <romain.perier@gmail.com>,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API
Date: Wed, 16 Sep 2020 14:44:55 +0100 [thread overview]
Message-ID: <20200916134455.GD4678@dell> (raw)
In-Reply-To: <20200817090637.26887-11-allen.cryptic@gmail.com>
On Mon, 17 Aug 2020, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly
> and remove .data field.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++---------
> drivers/net/wireless/intersil/orinoco/main.c | 7 +++----
> drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++----
> 3 files changed, 16 insertions(+), 17 deletions(-)
This patch seems to cause several warnings along the lines of:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’:
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
3185 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } | ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3187:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’
3187 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Allen Pais <allen.cryptic@gmail.com>
Cc: kvalo@codeaurora.org, kuba@kernel.org, jirislaby@kernel.org,
mickflemm@gmail.com, mcgrof@kernel.org, chunkeey@googlemail.com,
Larry.Finger@lwfinger.net, stas.yakovlev@gmail.com,
helmut.schaa@googlemail.com, pkshih@realtek.com,
yhchuang@realtek.com, dsd@gentoo.org, kune@deine-taler.de,
keescook@chromium.org, ath11k@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, b43-dev@lists.infradead.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API
Date: Wed, 16 Sep 2020 14:44:55 +0100 [thread overview]
Message-ID: <20200916134455.GD4678@dell> (raw)
In-Reply-To: <20200817090637.26887-11-allen.cryptic@gmail.com>
On Mon, 17 Aug 2020, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly
> and remove .data field.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++---------
> drivers/net/wireless/intersil/orinoco/main.c | 7 +++----
> drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++----
> 3 files changed, 16 insertions(+), 17 deletions(-)
This patch seems to cause several warnings along the lines of:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’:
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
3185 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } | ^
drivers/net/wireless/intersil/hostap/hostap_hw.c:3187:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’
3187 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-09-16 13:44 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:06 [PATCH 00/16] wirless: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-27 10:15 ` Kalle Valo
2020-08-27 10:15 ` Kalle Valo
2020-08-27 10:15 ` Kalle Valo
[not found] ` <20200827101540.6589BC433CB@smtp.codeaurora.org>
2020-08-27 10:44 ` Allen Pais
2020-08-27 10:44 ` Allen Pais
2020-08-27 10:44 ` Allen Pais
2020-09-07 16:32 ` Kalle Valo
2020-09-07 16:32 ` Kalle Valo
2020-09-07 16:32 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 02/16] wireless: ath9k: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-27 10:16 ` Kalle Valo
2020-08-27 10:16 ` Kalle Valo
2020-08-27 10:16 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 03/16] wireless: ath: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 19:12 ` Christian Lamparter
2020-08-27 10:21 ` Kalle Valo
2020-08-27 10:21 ` Kalle Valo
2020-08-27 10:21 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 04/16] wireless: ath11k: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-31 15:14 ` Kalle Valo
2020-08-31 15:14 ` Kalle Valo
2020-08-31 15:14 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 05/16] wireless: atmel: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-27 13:23 ` [05/16] " Kalle Valo
2020-08-27 18:17 ` Kees Cook
2020-08-27 18:17 ` Kees Cook
2020-08-27 18:17 ` Kees Cook
2020-08-27 13:23 ` Kalle Valo
2020-08-27 13:23 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 06/16] wireless: b43legacy: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 07/16] wireless: brcm80211: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 10:15 ` Arend Van Spriel
2020-08-17 10:15 ` Arend Van Spriel
2020-08-17 10:15 ` Arend Van Spriel
2020-08-17 9:06 ` [PATCH 08/16] wireless: ipw2x00: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 09/16] wireless: iwlegacy: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 10/16] wireless: intersil: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 13:00 ` kernel test robot
2020-09-16 13:44 ` Lee Jones [this message]
2020-09-16 13:44 ` Lee Jones
2020-09-16 13:44 ` Lee Jones
2020-08-17 9:06 ` [PATCH 11/16] wireless: marvell: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 12/16] wireless: mediatek: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-09-01 9:25 ` Kalle Valo
2020-09-01 9:25 ` Kalle Valo
2020-09-01 9:25 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 13/16] wireless: quantenna: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 14/16] wireless: ralink: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` [PATCH 15/16] wireless: realtek: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 14:55 ` kernel test robot
2020-08-17 9:06 ` [PATCH 16/16] wireless: zydas: " Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 9:06 ` Allen Pais
2020-08-17 17:17 ` kernel test robot
2020-08-18 5:44 ` [PATCH 00/16] wirless: convert tasklets to use new tasklet_setup() Jiri Slaby
2020-08-18 5:44 ` Jiri Slaby
2020-08-18 5:44 ` Jiri Slaby
2020-08-18 9:14 ` Allen
2020-08-18 9:14 ` Allen
2020-08-18 9:14 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916134455.GD4678@dell \
--to=lee.jones@linaro.org \
--cc=Larry.Finger@lwfinger.net \
--cc=allen.cryptic@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chunkeey@googlemail.com \
--cc=dsd@gentoo.org \
--cc=helmut.schaa@googlemail.com \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kune@deine-taler.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=romain.perier@gmail.com \
--cc=stas.yakovlev@gmail.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.