* [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
@ 2020-09-16 14:32 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-09-16 14:32 UTC (permalink / raw)
To: intel-wired-lan
The "failure" variable is used without being initialized. It should be
set to false.
Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 6acede0acdca..567fd67e900e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
unsigned int total_rx_bytes = 0, total_rx_packets = 0;
u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
unsigned int xdp_res, xdp_xmit = 0;
+ bool failure = false;
struct sk_buff *skb;
- bool failure;
while (likely(total_rx_packets < (unsigned int)budget)) {
union i40e_rx_desc *rx_desc;
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
@ 2020-09-16 14:32 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-09-16 14:32 UTC (permalink / raw)
To: kernel-janitors
The "failure" variable is used without being initialized. It should be
set to false.
Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 6acede0acdca..567fd67e900e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
unsigned int total_rx_bytes = 0, total_rx_packets = 0;
u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
unsigned int xdp_res, xdp_xmit = 0;
+ bool failure = false;
struct sk_buff *skb;
- bool failure;
while (likely(total_rx_packets < (unsigned int)budget)) {
union i40e_rx_desc *rx_desc;
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
2020-09-16 14:32 ` Dan Carpenter
@ 2020-09-16 15:49 ` Björn Töpel
-1 siblings, 0 replies; 5+ messages in thread
From: =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= @ 2020-09-16 15:49 UTC (permalink / raw)
To: intel-wired-lan
On 2020-09-16 16:32, Dan Carpenter wrote:
> The "failure" variable is used without being initialized. It should be
> set to false.
>
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan!
Acked-by: Bj?rn T?pel <bjorn.topel@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 6acede0acdca..567fd67e900e 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
> unsigned int total_rx_bytes = 0, total_rx_packets = 0;
> u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
> unsigned int xdp_res, xdp_xmit = 0;
> + bool failure = false;
> struct sk_buff *skb;
> - bool failure;
>
> while (likely(total_rx_packets < (unsigned int)budget)) {
> union i40e_rx_desc *rx_desc;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
@ 2020-09-16 15:49 ` Björn Töpel
0 siblings, 0 replies; 5+ messages in thread
From: Björn Töpel @ 2020-09-16 15:49 UTC (permalink / raw)
To: kernel-janitors
On 2020-09-16 16:32, Dan Carpenter wrote:
> The "failure" variable is used without being initialized. It should be
> set to false.
>
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan!
Acked-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 6acede0acdca..567fd67e900e 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
> unsigned int total_rx_bytes = 0, total_rx_packets = 0;
> u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
> unsigned int xdp_res, xdp_xmit = 0;
> + bool failure = false;
> struct sk_buff *skb;
> - bool failure;
>
> while (likely(total_rx_packets < (unsigned int)budget)) {
> union i40e_rx_desc *rx_desc;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
2020-09-16 14:32 ` Dan Carpenter
(?)
(?)
@ 2020-10-13 10:26 ` Kuruvinakunnel, George
-1 siblings, 0 replies; 5+ messages in thread
From: Kuruvinakunnel, George @ 2020-10-13 10:26 UTC (permalink / raw)
To: intel-wired-lan
-----Original Message-----
From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Dan Carpenter
Sent: Wednesday, September 16, 2020 8:02 PM
To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
Cc: intel-wired-lan at lists.osuosl.org; kernel-janitors at vger.kernel.org; Topel, Bjorn <bjorn.topel@intel.com>
Subject: [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()
The "failure" variable is used without being initialized. It should be set to false.
Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com<mailto:dan.carpenter@oracle.com>>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20201013/ee128d11/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-13 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-16 14:32 [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc() Dan Carpenter
2020-09-16 14:32 ` Dan Carpenter
2020-09-16 15:49 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-09-16 15:49 ` Björn Töpel
2020-10-13 10:26 ` [Intel-wired-lan] " Kuruvinakunnel, George
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.