From: Jonathan Cameron <jic23@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent
Date: Wed, 16 Sep 2020 19:17:56 +0100 [thread overview]
Message-ID: <20200916191756.6f53853a@archlinux> (raw)
In-Reply-To: <20200915192621.13202-1-martin.blumenstingl@googlemail.com>
On Tue, 15 Sep 2020 21:26:21 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Use only one line for the closing bracket of the last entry and the
> opening bracket for the next one to keep the style across the whole
> array consistent. Also add a "sentinel" comment to the last entry and
> remove the comma to ensure that there won't be any entry after it.
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/meson_saradc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 95bd187de1cb..e03988698755 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> {
> .compatible = "amlogic,meson8-saradc",
> .data = &meson_sar_adc_meson8_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8b-saradc",
> .data = &meson_sar_adc_meson8b_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8m2-saradc",
> .data = &meson_sar_adc_meson8m2_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson-gxbb-saradc",
> .data = &meson_sar_adc_gxbb_data,
> }, {
> @@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> .compatible = "amlogic,meson-g12a-saradc",
> .data = &meson_sar_adc_g12a_data,
> },
> - {},
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match);
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-iio@vger.kernel.org,
lars@metafoo.de, pmeerw@pmeerw.net,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent
Date: Wed, 16 Sep 2020 19:17:56 +0100 [thread overview]
Message-ID: <20200916191756.6f53853a@archlinux> (raw)
In-Reply-To: <20200915192621.13202-1-martin.blumenstingl@googlemail.com>
On Tue, 15 Sep 2020 21:26:21 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Use only one line for the closing bracket of the last entry and the
> opening bracket for the next one to keep the style across the whole
> array consistent. Also add a "sentinel" comment to the last entry and
> remove the comma to ensure that there won't be any entry after it.
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/meson_saradc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 95bd187de1cb..e03988698755 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> {
> .compatible = "amlogic,meson8-saradc",
> .data = &meson_sar_adc_meson8_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8b-saradc",
> .data = &meson_sar_adc_meson8b_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8m2-saradc",
> .data = &meson_sar_adc_meson8m2_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson-gxbb-saradc",
> .data = &meson_sar_adc_gxbb_data,
> }, {
> @@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> .compatible = "amlogic,meson-g12a-saradc",
> .data = &meson_sar_adc_g12a_data,
> },
> - {},
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match);
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent
Date: Wed, 16 Sep 2020 19:17:56 +0100 [thread overview]
Message-ID: <20200916191756.6f53853a@archlinux> (raw)
In-Reply-To: <20200915192621.13202-1-martin.blumenstingl@googlemail.com>
On Tue, 15 Sep 2020 21:26:21 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Use only one line for the closing bracket of the last entry and the
> opening bracket for the next one to keep the style across the whole
> array consistent. Also add a "sentinel" comment to the last entry and
> remove the comma to ensure that there won't be any entry after it.
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/meson_saradc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 95bd187de1cb..e03988698755 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> {
> .compatible = "amlogic,meson8-saradc",
> .data = &meson_sar_adc_meson8_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8b-saradc",
> .data = &meson_sar_adc_meson8b_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8m2-saradc",
> .data = &meson_sar_adc_meson8m2_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson-gxbb-saradc",
> .data = &meson_sar_adc_gxbb_data,
> }, {
> @@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> .compatible = "amlogic,meson-g12a-saradc",
> .data = &meson_sar_adc_g12a_data,
> },
> - {},
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 19:26 [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent Martin Blumenstingl
2020-09-15 19:26 ` Martin Blumenstingl
2020-09-15 19:26 ` Martin Blumenstingl
2020-09-16 18:17 ` Jonathan Cameron [this message]
2020-09-16 18:17 ` Jonathan Cameron
2020-09-16 18:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916191756.6f53853a@archlinux \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.