From: Mike Rapoport <rppt@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Pitre <nico@fluxnic.net>, Stefan Agner <stefan@agner.ch>,
Peter Smith <Peter.Smith@arm.com>, Marc Zyngier <maz@kernel.org>,
Will Deacon <will@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Jian Cai <jiancai@google.com>,
song.bao.hua@hisilicon.com,
Anders Roxell <anders.roxell@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH 00/12] ARM: use adr_l/ldr_l macros for PC-relative references
Date: Thu, 17 Sep 2020 08:19:45 +0300 [thread overview]
Message-ID: <20200917051945.GM2142832@kernel.org> (raw)
In-Reply-To: <CAKwvOd=CmiZ72yVmhX6LubObC6nUxjhwHhexjzW25j_8bpn_KA@mail.gmail.com>
(added Mike K.)
On Wed, Sep 16, 2020 at 05:16:32PM -0700, Nick Desaulniers wrote:
> On Wed, Sep 16, 2020 at 2:25 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
...
> Maybe this is: https://lore.kernel.org/linux-next/20200916140437.GL2142832@kernel.org/
> ? That looks arm64 specific though. Maybe 32b ARM needs the same or a
> similar fix? Oh man, this boots, total shot in the dark:
The CMA change is the problem IMO and it's now removed from -mm and
-next trees.
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 45f9d5ec2360..7118b98c1f5f 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -226,9 +226,6 @@ void __init arm_memblock_init(const struct
> machine_desc *mdesc)
> early_init_fdt_reserve_self();
> early_init_fdt_scan_reserved_mem();
>
> - /* reserve memory for DMA contiguous allocations */
> - dma_contiguous_reserve(arm_dma_limit);
> -
> arm_memblock_steal_permitted = false;
> memblock_dump_all();
> }
> @@ -248,6 +245,9 @@ void __init bootmem_init(void)
> */
> sparse_init();
>
> + /* reserve memory for DMA contiguous allocations */
> + dma_contiguous_reserve(arm_dma_limit);
> +
This might be too late for ARM because in paging_init() it calls
dma_contiguous_remap() which presumes that the CMA area is already
reserved.
dma_contiguous_remap() might be NOP, so your fix will boot until it
fails eventually :)
> /*
> * Now free the memory - free_area_init needs
> * the sparse mem_map arrays initialized by sparse_init()
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: song.bao.hua@hisilicon.com, linux-efi <linux-efi@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
Nicolas Pitre <nico@fluxnic.net>, Marc Zyngier <maz@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Stefan Agner <stefan@agner.ch>, Peter Smith <Peter.Smith@arm.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Jian Cai <jiancai@google.com>, Will Deacon <will@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH 00/12] ARM: use adr_l/ldr_l macros for PC-relative references
Date: Thu, 17 Sep 2020 08:19:45 +0300 [thread overview]
Message-ID: <20200917051945.GM2142832@kernel.org> (raw)
In-Reply-To: <CAKwvOd=CmiZ72yVmhX6LubObC6nUxjhwHhexjzW25j_8bpn_KA@mail.gmail.com>
(added Mike K.)
On Wed, Sep 16, 2020 at 05:16:32PM -0700, Nick Desaulniers wrote:
> On Wed, Sep 16, 2020 at 2:25 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
...
> Maybe this is: https://lore.kernel.org/linux-next/20200916140437.GL2142832@kernel.org/
> ? That looks arm64 specific though. Maybe 32b ARM needs the same or a
> similar fix? Oh man, this boots, total shot in the dark:
The CMA change is the problem IMO and it's now removed from -mm and
-next trees.
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 45f9d5ec2360..7118b98c1f5f 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -226,9 +226,6 @@ void __init arm_memblock_init(const struct
> machine_desc *mdesc)
> early_init_fdt_reserve_self();
> early_init_fdt_scan_reserved_mem();
>
> - /* reserve memory for DMA contiguous allocations */
> - dma_contiguous_reserve(arm_dma_limit);
> -
> arm_memblock_steal_permitted = false;
> memblock_dump_all();
> }
> @@ -248,6 +245,9 @@ void __init bootmem_init(void)
> */
> sparse_init();
>
> + /* reserve memory for DMA contiguous allocations */
> + dma_contiguous_reserve(arm_dma_limit);
> +
This might be too late for ARM because in paging_init() it calls
dma_contiguous_remap() which presumes that the CMA area is already
reserved.
dma_contiguous_remap() might be NOP, so your fix will boot until it
fails eventually :)
> /*
> * Now free the memory - free_area_init needs
> * the sparse mem_map arrays initialized by sparse_init()
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 5:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 9:56 [PATCH 00/12] ARM: use adr_l/ldr_l macros for PC-relative references Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-14 9:56 ` [PATCH 01/12] ARM: assembler: introduce adr_l, ldr_l and str_l macros Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-15 7:35 ` Ard Biesheuvel
2020-09-15 7:35 ` Ard Biesheuvel
2020-09-15 17:51 ` Nick Desaulniers
2020-09-15 17:51 ` Nick Desaulniers
2020-09-14 9:56 ` [PATCH 02/12] ARM: efistub: replace adrl pseudo-op with adr_l macro invocation Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-14 9:56 ` [PATCH 03/12] ARM: module: add support for place relative relocations Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-14 13:35 ` Nicolas Pitre
2020-09-14 13:35 ` Nicolas Pitre
2020-09-14 16:11 ` Russell King - ARM Linux admin
2020-09-14 16:11 ` Russell King - ARM Linux admin
2020-09-14 9:56 ` [PATCH 04/12] ARM: head-common.S: use PC-relative insn sequence for __proc_info Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-14 9:56 ` [PATCH 05/12] ARM: head-common.S: use PC-relative insn sequence for idmap creation Ard Biesheuvel
2020-09-14 9:56 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 06/12] ARM: head.S: use PC-relative insn sequence for secondary_data Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 07/12] ARM: kernel: use relative references for UP/SMP alternatives Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 08/12] ARM: head: use PC-relative insn sequence for __smp_alt Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 09/12] ARM: sleep.S: use PC-relative insn sequence for sleep_save_sp/mpidr_hash Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 10/12] ARM: head.S: use PC-relative insn sequences for __fixup_pv_table Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 11/12] ARM: head.S: use PC relative insn sequence to calculate PHYS_OFFSET Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 9:57 ` [PATCH 12/12] ARM: kvm: replace open coded VA->PA calculations with adr_l call Ard Biesheuvel
2020-09-14 9:57 ` Ard Biesheuvel
2020-09-14 14:06 ` [PATCH 00/12] ARM: use adr_l/ldr_l macros for PC-relative references Nicolas Pitre
2020-09-14 14:06 ` Nicolas Pitre
2020-09-15 19:32 ` Nick Desaulniers
2020-09-15 19:32 ` Nick Desaulniers
2020-09-15 21:29 ` Ard Biesheuvel
2020-09-15 21:29 ` Ard Biesheuvel
2020-09-15 23:31 ` Nick Desaulniers
2020-09-15 23:31 ` Nick Desaulniers
2020-09-16 5:54 ` Ard Biesheuvel
2020-09-16 5:54 ` Ard Biesheuvel
2020-09-16 19:53 ` Nick Desaulniers
2020-09-16 19:53 ` Nick Desaulniers
2020-09-16 20:45 ` Ard Biesheuvel
2020-09-16 20:45 ` Ard Biesheuvel
2020-09-16 21:25 ` Nick Desaulniers
2020-09-16 21:25 ` Nick Desaulniers
2020-09-17 0:16 ` Nick Desaulniers
2020-09-17 0:16 ` Nick Desaulniers
2020-09-17 5:19 ` Mike Rapoport [this message]
2020-09-17 5:19 ` Mike Rapoport
2020-09-17 6:01 ` Ard Biesheuvel
2020-09-17 6:01 ` Ard Biesheuvel
2020-09-18 20:03 ` Nick Desaulniers
2020-09-18 20:03 ` Nick Desaulniers
2020-09-18 20:44 ` Ard Biesheuvel
2020-09-18 20:44 ` Ard Biesheuvel
2020-09-18 21:06 ` Nick Desaulniers
2020-09-18 21:06 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917051945.GM2142832@kernel.org \
--to=rppt@kernel.org \
--cc=Peter.Smith@arm.com \
--cc=anders.roxell@linaro.org \
--cc=ardb@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=jiancai@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=naresh.kamboju@linaro.org \
--cc=ndesaulniers@google.com \
--cc=nico@fluxnic.net \
--cc=song.bao.hua@hisilicon.com \
--cc=stefan@agner.ch \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.