From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, rdunlap@infradead.org, daniel@ffwll.ch,
yuanmingbuaa@gmail.com, w@1wt.eu, nopitydays@gmail.com,
zhangyunhai@nsfocus.com, luto@amacapital.net,
torvalds@linux-foundation.org
Subject: Re: [PATCH v3] docs: fb: Remove framebuffer scrollback boot option
Date: Thu, 17 Sep 2020 13:41:58 +0530 [thread overview]
Message-ID: <20200917081158.GA19903@OpenSuse> (raw)
In-Reply-To: <20200917074747.GA3332340@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]
On 09:47 Thu 17 Sep 2020, Greg KH wrote:
>On Thu, Sep 17, 2020 at 04:31:50AM +0530, Bhaskar Chowdhury wrote:
>> This patch remove reference to this option in this document and
>> renumbered the sections. This is related to below commits.
>>
>> Commit 973c096f6a85(vgacon: remove software scrollback support)
>> Commit 50145474f6ef(fbcon: remove soft scrollback code)
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> This version try to correct the previous errors, proper changelog text, subject
>> Trying to incorporate Willy's & Greg's suggestions
>
>Better, but...
>
>This should be a patch series, properly numbered and threaded, right?
>
>The text above still has the commit ids not properly referenced, and you
>have trailing whitespace in the text too.
>
I will certainly fix that in the upcoming version.
>Writing the changelog is often times the hardest part of a patch, as you
>are finding out.
>
Yes..true.
>How about this example, for this specific patch, as a changelog text:
>
>---------
>In commit 50145474f6ef ("fbcon: remove soft scrollback code"), the
>framebuffer scrollback mode was removed, but the documentation was not
>updated. Properly update the documentation by removing the option that
>is no longer present, and update the section numbering because of the
>removal.
>---------
Just like an pointed arrow ..perfect...cut to the cheese!
>
>Doesn't that make more sense about what is happening here, and provide
>enough information that when someone 10+ years from now goes and tries
>to find out why a boot option went away, what exactly happened and why?
>
Absolutely.
>Can you make this type of change to all 4 of these patches and resend
>them, with the proper change information below the --- line as a v4
>series?
>
Certain thing...will incorporate your suggestions in V4 and send.
>thanks,
Indebted for your and others patience for standing this long ..thank you!
>
>greg k-h
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, rdunlap@infradead.org, daniel@ffwll.ch,
yuanmingbuaa@gmail.com, w@1wt.eu, nopitydays@gmail.com,
zhangyunhai@nsfocus.com, luto@amacapital.net,
torvalds@linux-foundation.org
Subject: Re: [PATCH v3] docs: fb: Remove framebuffer scrollback boot option
Date: Thu, 17 Sep 2020 08:23:58 +0000 [thread overview]
Message-ID: <20200917081158.GA19903@OpenSuse> (raw)
In-Reply-To: <20200917074747.GA3332340@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]
On 09:47 Thu 17 Sep 2020, Greg KH wrote:
>On Thu, Sep 17, 2020 at 04:31:50AM +0530, Bhaskar Chowdhury wrote:
>> This patch remove reference to this option in this document and
>> renumbered the sections. This is related to below commits.
>>
>> Commit 973c096f6a85(vgacon: remove software scrollback support)
>> Commit 50145474f6ef(fbcon: remove soft scrollback code)
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> This version try to correct the previous errors, proper changelog text, subject
>> Trying to incorporate Willy's & Greg's suggestions
>
>Better, but...
>
>This should be a patch series, properly numbered and threaded, right?
>
>The text above still has the commit ids not properly referenced, and you
>have trailing whitespace in the text too.
>
I will certainly fix that in the upcoming version.
>Writing the changelog is often times the hardest part of a patch, as you
>are finding out.
>
Yes..true.
>How about this example, for this specific patch, as a changelog text:
>
>---------
>In commit 50145474f6ef ("fbcon: remove soft scrollback code"), the
>framebuffer scrollback mode was removed, but the documentation was not
>updated. Properly update the documentation by removing the option that
>is no longer present, and update the section numbering because of the
>removal.
>---------
Just like an pointed arrow ..perfect...cut to the cheese!
>
>Doesn't that make more sense about what is happening here, and provide
>enough information that when someone 10+ years from now goes and tries
>to find out why a boot option went away, what exactly happened and why?
>
Absolutely.
>Can you make this type of change to all 4 of these patches and resend
>them, with the proper change information below the --- line as a v4
>series?
>
Certain thing...will incorporate your suggestions in V4 and send.
>thanks,
Indebted for your and others patience for standing this long ..thank you!
>
>greg k-h
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-17 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 23:01 [PATCH v3] docs: fb: Remove framebuffer scrollback boot option Bhaskar Chowdhury
2020-09-16 23:13 ` Bhaskar Chowdhury
2020-09-17 7:47 ` Greg KH
2020-09-17 7:47 ` Greg KH
2020-09-17 8:11 ` Bhaskar Chowdhury [this message]
2020-09-17 8:23 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917081158.GA19903@OpenSuse \
--to=unixbhaskar@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nopitydays@gmail.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
--cc=yuanmingbuaa@gmail.com \
--cc=zhangyunhai@nsfocus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.