[GIT FIXES FOR v5.9] Remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag

[GIT FIXES FOR v5.9] Remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag

[Hans Verkuil]

From the commit log of the patch:

--------------------------------------------------------------------
The patch partially reverts some of the UAPI bits of the buffer
cache management hints. Namely, the queue consistency (memory
coherency) user-space hint because, as it turned out, the kernel
implementation of this feature was misusing DMA_ATTR_NON_CONSISTENT.

The patch revers both kernel and user space parts: removes the
DMA consistency attr functions, rolls back changes to v4l2_requestbuffers,
v4l2_create_buffers structures and corresponding UAPI functions
(plus compat32 layer) and cleans up the documentation.
--------------------------------------------------------------------

The intention is that this feature will return once proper low-level support
for this has been sorted. A patch to revert the v4l-utils changes is ready
to be merged once this patch made it's way to our master branch:

https://patchwork.linuxtv.org/project/linux-media/patch/20200911030952.74468-1-sergey.senozhatsky@gmail.com/

I've tested this with the test-media script.

Regards,

	Hans

The following changes since commit 93c16fabdb74a9c1a427402fc1fe588a45130c5b:

  media: ov8856: Add support for 3264x2448 mode (2020-09-10 14:29:35 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.9-mem

for you to fetch changes up to d36642b40255022dda1cfcaebe82e40a592d4ee8:

  media/v4l2: remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag (2020-09-11 12:26:54 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Sergey Senozhatsky (1):
      media/v4l2: remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag

 Documentation/userspace-api/media/v4l/buffer.rst             | 17 -----------------
 Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst |  6 +-----
 Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst     | 12 ++----------
 drivers/media/common/videobuf2/videobuf2-core.c              | 46 ++++++----------------------------------------
 drivers/media/common/videobuf2/videobuf2-dma-contig.c        | 19 -------------------
 drivers/media/common/videobuf2/videobuf2-dma-sg.c            |  3 +--
 drivers/media/common/videobuf2/videobuf2-v4l2.c              | 18 ++----------------
 drivers/media/dvb-core/dvb_vb2.c                             |  2 +-
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c                | 10 ++--------
 drivers/media/v4l2-core/v4l2-ioctl.c                         |  5 ++++-
 include/media/videobuf2-core.h                               |  7 ++-----
 include/uapi/linux/videodev2.h                               | 13 ++-----------
 12 files changed, 23 insertions(+), 135 deletions(-)

Re: [GIT FIXES FOR v5.9] Remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag (#66890)

[Jenkins]

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/9347220a-a039-93ff-5dd7-f35613631a29@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/67842/
Build time: 00:19:57
Link: https://lore.kernel.org/linux-media/9347220a-a039-93ff-5dd7-f35613631a29@xs4all.nl

gpg: Signature made Fri 11 Sep 2020 10:38:11 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: got 1/1 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-v4l2-remove-V4L2_FLAG_MEMORY_NON_CONSISTENT-fl.patch:

    allyesconfig: return code #0:
	../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: ../drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:703 is_pipe_valid_to_current_run_mode() warn: ignoring unreachable code.
	../drivers/staging/media/atomisp/pci/sh_css.c:1685:16: warning: assignment left-hand side might be a candidate for a format attribute [-Wsuggest-attribute=format]

    allyesconfig: return code #0:
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds


Error #512 when building PDF docs

Re: [GIT FIXES FOR v5.9] Remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag

[Mauro Carvalho Chehab]

Em Fri, 11 Sep 2020 12:52:57 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> From the commit log of the patch:
> 
> --------------------------------------------------------------------
> The patch partially reverts some of the UAPI bits of the buffer
> cache management hints. Namely, the queue consistency (memory
> coherency) user-space hint because, as it turned out, the kernel
> implementation of this feature was misusing DMA_ATTR_NON_CONSISTENT.
> 
> The patch revers both kernel and user space parts: removes the
> DMA consistency attr functions, rolls back changes to v4l2_requestbuffers,
> v4l2_create_buffers structures and corresponding UAPI functions
> (plus compat32 layer) and cleans up the documentation.
> --------------------------------------------------------------------
> 
> The intention is that this feature will return once proper low-level support
> for this has been sorted. A patch to revert the v4l-utils changes is ready
> to be merged once this patch made it's way to our master branch:
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20200911030952.74468-1-sergey.senozhatsky@gmail.com/
> 
> I've tested this with the test-media script.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 93c16fabdb74a9c1a427402fc1fe588a45130c5b:
> 
>   media: ov8856: Add support for 3264x2448 mode (2020-09-10 14:29:35 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.9-mem
> 
> for you to fetch changes up to d36642b40255022dda1cfcaebe82e40a592d4ee8:
> 
>   media/v4l2: remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag (2020-09-11 12:26:54 +0200)

This caused a warning when building the html books. Not sure why the robot
didn't warn. I'll be posting a fix at the ML.

Thanks,
Mauro