All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Rob Herring <robh@kernel.org>
Cc: "Andreas Kemnade" <andreas@kemnade.info>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
	"Stephan Gerhold" <stephan@gerhold.net>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Mark Brown" <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org,
	"Linux PWM List" <linux-pwm@vger.kernel.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
	<linux-rtc@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Josua Mayer" <josua.mayer@jm0.eu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Daniel Palmer" <daniel@0x0f.com>
Subject: Re: [PATCH v2 04/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC
Date: Thu, 17 Sep 2020 13:58:48 +0200	[thread overview]
Message-ID: <20200917115848.GH3306@latitude> (raw)
In-Reply-To: <CAL_JsqL=gQxiU5uK-AEJtG3daOy83aS_D6G2Jo8_-dzKH70NkQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Tue, Sep 15, 2020 at 08:31:55AM -0600, Rob Herring wrote:
> On Tue, Sep 15, 2020 at 12:24 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> > On Mon, 14 Sep 2020 18:54:43 -0600 Rob Herring <robh@kernel.org> wrote:
[...]
> > > Just move this to the parent and make the parent a pwm provider. There's
> > > no need for child nodes for this or the rtc.
> > >
> > hmm, there are apparently devices without rtc. If there is a child node
> > for the rtc, the corresponding devicetrees could disable rtc by not
> > having that node.
> > But maybe using the controller version is also feasible for that task.
> 
> If not probeable, then the compatible string should distinguish that.

Okay.

It's even simpler in some cases: The firmware version reported by the EC
should tell us if it's one that is known to have no RTC.

That said, I don't have a good overview of the different variants of
this device.


Thanks,
Jonathan Neuschäfer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Rob Herring <robh@kernel.org>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Linux PWM List" <linux-pwm@vger.kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
	<linux-rtc@vger.kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Daniel Palmer" <daniel@0x0f.com>,
	"Andreas Kemnade" <andreas@kemnade.info>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	devicetree@vger.kernel.org,
	"Stephan Gerhold" <stephan@gerhold.net>,
	allen <allen.chen@ite.com.tw>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Mark Brown" <broonie@kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
	"Josua Mayer" <josua.mayer@jm0.eu>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 04/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC
Date: Thu, 17 Sep 2020 13:58:48 +0200	[thread overview]
Message-ID: <20200917115848.GH3306@latitude> (raw)
In-Reply-To: <CAL_JsqL=gQxiU5uK-AEJtG3daOy83aS_D6G2Jo8_-dzKH70NkQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 957 bytes --]

On Tue, Sep 15, 2020 at 08:31:55AM -0600, Rob Herring wrote:
> On Tue, Sep 15, 2020 at 12:24 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> > On Mon, 14 Sep 2020 18:54:43 -0600 Rob Herring <robh@kernel.org> wrote:
[...]
> > > Just move this to the parent and make the parent a pwm provider. There's
> > > no need for child nodes for this or the rtc.
> > >
> > hmm, there are apparently devices without rtc. If there is a child node
> > for the rtc, the corresponding devicetrees could disable rtc by not
> > having that node.
> > But maybe using the controller version is also feasible for that task.
> 
> If not probeable, then the compatible string should distinguish that.

Okay.

It's even simpler in some cases: The firmware version reported by the EC
should tell us if it's one that is known to have no RTC.

That said, I don't have a good overview of the different variants of
this device.


Thanks,
Jonathan Neuschäfer

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-17 12:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 13:32 [PATCH v2 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers Jonathan Neuschäfer
2020-09-05 13:32 ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 01/10] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-15  0:43   ` Rob Herring
2020-09-15  0:43     ` Rob Herring
2020-09-05 13:32 ` [PATCH v2 02/10] dt-bindings: mfd: Add binding for Netronix's embedded controller Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-15  0:50   ` Rob Herring
2020-09-15  0:50     ` Rob Herring
2020-09-17 11:12     ` Jonathan Neuschäfer
2020-09-17 11:12       ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 03/10] mfd: Add base driver for Netronix " Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-08 13:29   ` Lee Jones
2020-09-08 13:29     ` Lee Jones
2020-09-10 12:04     ` Jonathan Neuschäfer
2020-09-10 12:04       ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 04/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-15  0:54   ` Rob Herring
2020-09-15  0:54     ` Rob Herring
2020-09-15  6:23     ` Andreas Kemnade
2020-09-15  6:23       ` Andreas Kemnade
2020-09-15 14:31       ` Rob Herring
2020-09-15 14:31         ` Rob Herring
2020-09-17 11:58         ` Jonathan Neuschäfer [this message]
2020-09-17 11:58           ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 05/10] pwm: ntxec: Add driver " Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-05 18:08   ` Andy Shevchenko
2020-09-08  8:14     ` Lee Jones
2020-09-08  8:14       ` Lee Jones
2020-09-08  8:47       ` Andy Shevchenko
2020-09-08  8:47         ` Andy Shevchenko
2020-09-08  9:35         ` Lee Jones
2020-09-08  9:35           ` Lee Jones
2020-09-10 19:13           ` Jonathan Neuschäfer
2020-09-10 19:13             ` Jonathan Neuschäfer
2020-09-10 19:09     ` Jonathan Neuschäfer
2020-09-10 19:09       ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 06/10] dt-bindings: rtc: Add bindings for Netronix embedded controller RTC Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-05 13:32 ` [PATCH v2 07/10] rtc: Introduce RTC_TIMESTAMP_END_2255 Jonathan Neuschäfer
2020-09-05 13:32   ` Jonathan Neuschäfer
2020-09-08  9:39   ` Alexandre Belloni
2020-09-08  9:39     ` Alexandre Belloni
2020-09-10 19:21     ` Jonathan Neuschäfer
2020-09-10 19:21       ` Jonathan Neuschäfer
2020-09-05 14:45 ` [PATCH v2 08/10] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2020-09-05 14:45   ` Jonathan Neuschäfer
2020-09-05 17:56   ` Andy Shevchenko
2020-09-10 19:42     ` Jonathan Neuschäfer
2020-09-10 19:42       ` Jonathan Neuschäfer
2020-09-05 14:45 ` [PATCH v2 09/10] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2020-09-05 14:45   ` Jonathan Neuschäfer
2020-09-05 14:45 ` [PATCH v2 10/10] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
2020-09-05 14:45   ` Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917115848.GH3306@latitude \
    --to=j.neuschaefer@gmx.net \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allen.chen@ite.com.tw \
    --cc=andreas@kemnade.info \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=josua.mayer@jm0.eu \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=shawnguo@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.