[PATCH RFC 0/8] Introduce warming in thermal framework

[PATCH RFC 0/8] Introduce warming in thermal framework

[Thara Gopinath]

Thermal framework today supports monitoring for rising temperatures and
subsequently initiating cooling action in case of a thermal trip point
being crossed. There are scenarios where a SoC need warming mitigating
action to be activated if the temperature falls below a cetain permissible
limit.  Since warming action can be considered mirror opposite of cooling
action, most of the thermal framework can be re-used to achieve this. The
key assumption in this patch series is that a device can act either as a
warming device or a cooling device and not as both.

In order to support warming three extensions are needed in the thermal
framework.

1. Indication that a trip point is being monitored for falling temperature
and not rising temperature. We discussed two different ways to achieve this
during LPC. First option is to introduce a new trip type to indicate that a
trip is a cold trip(THERMAL_TRIP_COLD). The second option is to introduce a
new property for trip point that will indicate whether a trip point is
being monitored for rising temperature or falling temperature. The patch
series(patches 1-4) chooses the second approach since it allows trip points
of any type to be monitored for rising or falling temperature.Also this was
the preferred approach when discussed during LPC. The approach that
introduces a new cold trip type was posted on the list earlier as a RFC and
can be found at [1].

2. Extend the exisitng governors to handle monitoring of falling
temperature. The patch series(patches 5 & 6) extends the step wise governor
to monitor the falling temperature.Other governors return doing nothing if
the trip point they are being called for is being monitored for falling
temperature. The governors' mitigate function is called "throttle" in the
thermal framework and with this patch series it is a misnomer as the
function is called for both throttling and warming up. Ideally
"throttle" should be renamed to "mitigate" to improve readability of code.
The renaming is not part of this series.

3. Finally, the cooling device framework itself can be reused for a warming
device. As stated before a device can act either as a warming device or a
cooling device and not as both.  With this the cooling state in the
framework can be considered as mitigating state with 0 as the state with no
thermal mitigation and higher the number higher the thermal mitigation.
Again what affects the code readability and comprehension is the term
"cooling" which is a misnomer here. Ideally the term "cooling" should be
renamed to "mitigating" and hence thermal_cooling_device will become
thermal_mitgating_device. The renaming is not part of the patch series as
even though the renaming is a simple search-replace, it will change a lot
of files.  The patch series(patches 7 & 8) instead introduces a minimal set
of _warming_device_ apis to register and unregister warming devices which
internally is identical to the _cooling_device_ counterpart.

1. https://lkml.org/lkml/2020/7/10/639

Thara Gopinath (8):
  dt-bindings: thermal: Introduce monitor-falling parameter to thermal
    trip point binding
  thermal: Introduce new property monitor_type for trip point.
  thermal: thermal_of: Extend thermal dt driver to support
    bi-directional monitoring of a thermal trip point.
  thermal:core:Add genetlink notifications for monitoring falling
    temperature
  thermal: gov_step_wise: Extend thermal step-wise governor to monitor
    falling temperature.
  thermal: Modify thermal governors to do nothing for trip points being
    monitored for falling temperature
  thermal:core: Add is_warming_dev and supporting warming device api's
    to the cooling dev framework.
  soc:qcom:qcom_aoss: Change cooling_device_register to
    warming_device_register

 .../bindings/thermal/thermal-zones.yaml       |   7 ++
 drivers/soc/qcom/qcom_aoss.c                  |   6 +-
 drivers/thermal/gov_bang_bang.c               |  12 ++
 drivers/thermal/gov_fair_share.c              |  12 ++
 drivers/thermal/gov_power_allocator.c         |  12 ++
 drivers/thermal/gov_step_wise.c               |  62 +++++++---
 drivers/thermal/thermal_core.c                | 113 +++++++++++++++---
 drivers/thermal/thermal_core.h                |   2 +
 drivers/thermal/thermal_of.c                  |  22 ++++
 include/linux/thermal.h                       |   9 ++
 include/uapi/linux/thermal.h                  |   5 +
 11 files changed, 226 insertions(+), 36 deletions(-)

-- 
2.25.1

[PATCH RFC 1/8] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding

[Thara Gopinath]

Introduce a new binding parameter to thermal trip point description
to indicate whether the temperature level specified by the trip point
is monitored for a rise or fall in temperature.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 .../devicetree/bindings/thermal/thermal-zones.yaml         | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
index 3ec9cc87ec50..cc1332ad6c16 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -161,6 +161,13 @@ patternProperties:
                   The active trip type can be used to control other HW to
                   help in cooling e.g. fans can be sped up or slowed down
 
+              monitor-falling:
+                description: |
+                  boolean, If true, the trip point is being monitored for
+                  falling temperature. If false/absent/default, the trip
+                  point is being monitored for rising temperature.
+                type: boolean
+
             required:
               - temperature
               - hysteresis
-- 
2.25.1

Re: [PATCH RFC 1/8] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding

[Rob Herring]

On Wed, Sep 16, 2020 at 11:22:19PM -0400, Thara Gopinath wrote:
> Introduce a new binding parameter to thermal trip point description
> to indicate whether the temperature level specified by the trip point
> is monitored for a rise or fall in temperature.
> 
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
>  .../devicetree/bindings/thermal/thermal-zones.yaml         | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> index 3ec9cc87ec50..cc1332ad6c16 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> @@ -161,6 +161,13 @@ patternProperties:
>                    The active trip type can be used to control other HW to
>                    help in cooling e.g. fans can be sped up or slowed down
>  
> +              monitor-falling:
> +                description: |
> +                  boolean, If true, the trip point is being monitored for
> +                  falling temperature. If false/absent/default, the trip
> +                  point is being monitored for rising temperature.
> +                type: boolean

What if you wanted to monitor for both?

> +
>              required:
>                - temperature
>                - hysteresis
> -- 
> 2.25.1
> 

Re: [PATCH RFC 1/8] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding

[Thara Gopinath]

Hi Rob,
Thanks for the review.

On 9/23/20 12:03 PM, Rob Herring wrote:
> On Wed, Sep 16, 2020 at 11:22:19PM -0400, Thara Gopinath wrote:
>> Introduce a new binding parameter to thermal trip point description
>> to indicate whether the temperature level specified by the trip point
>> is monitored for a rise or fall in temperature.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>>   .../devicetree/bindings/thermal/thermal-zones.yaml         | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> index 3ec9cc87ec50..cc1332ad6c16 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> @@ -161,6 +161,13 @@ patternProperties:
>>                     The active trip type can be used to control other HW to
>>                     help in cooling e.g. fans can be sped up or slowed down
>>   
>> +              monitor-falling:
>> +                description: |
>> +                  boolean, If true, the trip point is being monitored for
>> +                  falling temperature. If false/absent/default, the trip
>> +                  point is being monitored for rising temperature.
>> +                type: boolean
> 
> What if you wanted to monitor for both?

You usually don't want to. At really low temperature trip (5 degree C or 
0 degree C) you care about starting to monitor when the temperature 
falls below the trip. At high temp trip points, you care about starting 
to monitor when the temperature rises above the trip point. The thermal 
framework takes care of stopping the monitoring (dependent on type of 
monitoring, hysteresis etc.)
> 
>> +
>>               required:
>>                 - temperature
>>                 - hysteresis
>> -- 
>> 2.25.1
>>

-- 
Warm Regards
Thara

[PATCH RFC 2/8] thermal: Introduce new property monitor_type for trip point.

[Thara Gopinath]

Thermal trip points can be defined to indicate whether a
temperature rise or a temperature fall is to be monitored. This
property can now be defined in the DT bindings for a trip point.
To support this following three changes are introduced to thermal
core and sysfs code.
1. Define a new variable in thermal_trip to capture the monitor
   rising/falling information from trip point DT bindings.
2. Define a new ops in thermal_zone_device_ops that can be populated
   to indicate whether a trip is being monitored for rising or falling
   temperature. If the ops is not populated or if the binding is missing
   in the DT, it is assumed that the trip is being monitored for rising
   temperature. (default behavior today)

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/thermal_core.h | 2 ++
 include/linux/thermal.h        | 2 ++
 include/uapi/linux/thermal.h   | 5 +++++
 3 files changed, 9 insertions(+)

diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index e00fc5585ea8..c56addfe2284 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -77,12 +77,14 @@ int power_actor_set_power(struct thermal_cooling_device *cdev,
  * @temperature: temperature value in miliCelsius
  * @hysteresis: relative hysteresis in miliCelsius
  * @type: trip point type
+ * @monitor_type: trip point monitor type
  */
 struct thermal_trip {
 	struct device_node *np;
 	int temperature;
 	int hysteresis;
 	enum thermal_trip_type type;
+	enum thermal_trip_monitor_type monitor_type;
 };
 
 int get_tz_trend(struct thermal_zone_device *tz, int trip);
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 42ef807e5d84..a50ed958d0bd 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -72,6 +72,8 @@ struct thermal_zone_device_ops {
 	int (*set_trip_temp) (struct thermal_zone_device *, int, int);
 	int (*get_trip_hyst) (struct thermal_zone_device *, int, int *);
 	int (*set_trip_hyst) (struct thermal_zone_device *, int, int);
+	int (*get_trip_mon_type)(struct thermal_zone_device *, int,
+				     enum thermal_trip_monitor_type *);
 	int (*get_crit_temp) (struct thermal_zone_device *, int *);
 	int (*set_emul_temp) (struct thermal_zone_device *, int);
 	int (*get_trend) (struct thermal_zone_device *, int,
diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
index c105054cbb57..d3bb4e4fad69 100644
--- a/include/uapi/linux/thermal.h
+++ b/include/uapi/linux/thermal.h
@@ -16,6 +16,11 @@ enum thermal_trip_type {
 	THERMAL_TRIP_CRITICAL,
 };
 
+enum thermal_trip_monitor_type {
+	THERMAL_TRIP_MONITOR_RISING = 0,
+	THERMAL_TRIP_MONITOR_FALLING
+};
+
 /* Adding event notification support elements */
 #define THERMAL_GENL_FAMILY_NAME		"thermal"
 #define THERMAL_GENL_VERSION			0x01
-- 
2.25.1

[PATCH RFC 3/8] thermal: thermal_of: Extend thermal dt driver to support bi-directional monitoring of a thermal trip point.

[Thara Gopinath]

Introduce of_thermal_get_trip_monitor_type to return the direction
of monitoring of a thermal trip point. Also translate the DT information
regarding trip point monitor direction into the thermal framework.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/thermal_of.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
index 69ef12f852b7..5bc7f5bab772 100644
--- a/drivers/thermal/thermal_of.c
+++ b/drivers/thermal/thermal_of.c
@@ -328,6 +328,20 @@ static int of_thermal_get_trip_hyst(struct thermal_zone_device *tz, int trip,
 	return 0;
 }
 
+static int of_thermal_get_trip_monitor_type
+				(struct thermal_zone_device *tz, int trip,
+				 enum thermal_trip_monitor_type *type)
+{
+	struct __thermal_zone *data = tz->devdata;
+
+	if (trip >= data->ntrips || trip < 0)
+		return -EDOM;
+
+	*type = data->trips[trip].monitor_type;
+
+	return 0;
+}
+
 static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,
 				    int hyst)
 {
@@ -363,6 +377,7 @@ static struct thermal_zone_device_ops of_thermal_ops = {
 	.set_trip_temp = of_thermal_set_trip_temp,
 	.get_trip_hyst = of_thermal_get_trip_hyst,
 	.set_trip_hyst = of_thermal_set_trip_hyst,
+	.get_trip_mon_type = of_thermal_get_trip_monitor_type,
 	.get_crit_temp = of_thermal_get_crit_temp,
 
 	.bind = of_thermal_bind,
@@ -801,6 +816,7 @@ static int thermal_of_populate_trip(struct device_node *np,
 {
 	int prop;
 	int ret;
+	bool is_monitor_falling;
 
 	ret = of_property_read_u32(np, "temperature", &prop);
 	if (ret < 0) {
@@ -822,6 +838,12 @@ static int thermal_of_populate_trip(struct device_node *np,
 		return ret;
 	}
 
+	ret = of_property_read_bool(np, "monitor-falling");
+	if (is_monitor_falling)
+		trip->monitor_type = THERMAL_TRIP_MONITOR_FALLING;
+	else
+		trip->monitor_type = THERMAL_TRIP_MONITOR_RISING;
+
 	/* Required for cooling map matching */
 	trip->np = np;
 	of_node_get(np);
-- 
2.25.1

[PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature

[Thara Gopinath]

Add notification calls for trip points that are being monitored for
falling temperatures.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/thermal_core.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 72bf159bcecc..bfd436379408 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -417,6 +417,7 @@ static void handle_critical_trips(struct thermal_zone_device *tz,
 static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
 {
 	enum thermal_trip_type type;
+	enum thermal_trip_monitor_type mon_type;
 	int trip_temp, hyst = 0;
 
 	/* Ignore disabled trip points */
@@ -428,13 +429,25 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
 	if (tz->ops->get_trip_hyst)
 		tz->ops->get_trip_hyst(tz, trip, &hyst);
 
+	if (tz->ops->get_trip_mon_type)
+		tz->ops->get_trip_mon_type(tz, trip, &mon_type);
+
 	if (tz->last_temperature != THERMAL_TEMP_INVALID) {
-		if (tz->last_temperature < trip_temp &&
-		    tz->temperature >= trip_temp)
-			thermal_notify_tz_trip_up(tz->id, trip);
-		if (tz->last_temperature >= trip_temp &&
-		    tz->temperature < (trip_temp - hyst))
-			thermal_notify_tz_trip_down(tz->id, trip);
+		if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
+			if (tz->last_temperature > trip_temp &&
+			    tz->temperature <= trip_temp)
+				thermal_notify_tz_trip_down(tz->id, trip);
+			if (tz->last_temperature <= trip_temp &&
+			    tz->temperature > (trip_temp + hyst))
+				thermal_notify_tz_trip_up(tz->id, trip);
+		} else {
+			if (tz->last_temperature < trip_temp &&
+			    tz->temperature >= trip_temp)
+				thermal_notify_tz_trip_up(tz->id, trip);
+			if (tz->last_temperature >= trip_temp &&
+			    tz->temperature < (trip_temp - hyst))
+				thermal_notify_tz_trip_down(tz->id, trip);
+		}
 	}
 
 	if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
-- 
2.25.1

Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 6456 bytes --]

Hi Thara,

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.

# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359c9d1f7f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c

0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  417  static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  418  {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  419  	enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  420  	enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  421  	int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  422  
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  423  	/* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  424  	if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  425  		return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  426  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  427  	tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  428  	tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  429  	if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  430  		tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  431  
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  432  	if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  433  		tz->ops->get_trip_mon_type(tz, trip, &mon_type);
                                                                                                                             ^^^^^^^^^
Unintialized on else path

602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  434  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  435  	if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436  		if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
                                                                                            ^^^^^^^^

602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  437  			if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  438  			    tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  439  				thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  440  			if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  441  			    tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  442  				thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  443  		} else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  444  			if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  445  			    tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  446  				thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  447  			if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  448  			    tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  449  				thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  450  		}
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  451  	}
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  452  
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  453  	if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  454  		handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  455  	else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba    2018-10-15  456  		handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  457  	/*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  458  	 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  459  	 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  460  	 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  461  	monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  462  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30048 bytes --]

Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 6456 bytes --]

Hi Thara,

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.

# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359c9d1f7f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c

0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  417  static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  418  {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  419  	enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  420  	enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  421  	int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  422  
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  423  	/* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  424  	if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  425  		return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  426  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  427  	tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  428  	tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  429  	if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  430  		tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  431  
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  432  	if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  433  		tz->ops->get_trip_mon_type(tz, trip, &mon_type);
                                                                                                                             ^^^^^^^^^
Unintialized on else path

602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  434  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  435  	if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436  		if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
                                                                                            ^^^^^^^^

602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  437  			if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  438  			    tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  439  				thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  440  			if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  441  			    tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  442  				thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  443  		} else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  444  			if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  445  			    tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  446  				thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  447  			if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  448  			    tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  449  				thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  450  		}
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  451  	}
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  452  
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  453  	if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  454  		handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  455  	else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba    2018-10-15  456  		handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  457  	/*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  458  	 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  459  	 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  460  	 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  461  	monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  462  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30048 bytes --]

[PATCH RFC 5/8] thermal: gov_step_wise: Extend thermal step-wise governor to monitor falling temperature.

[Thara Gopinath]

From the step wise governor point of view, the policy decisions
that has to taken on a thermal trip point that is defined to be monitored
for falling temperature is the mirror opposite of the decisions it has
to take on a trip point that is monitored for rising temperature.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/gov_step_wise.c | 62 +++++++++++++++++++++++++--------
 1 file changed, 47 insertions(+), 15 deletions(-)

diff --git a/drivers/thermal/gov_step_wise.c b/drivers/thermal/gov_step_wise.c
index 2ae7198d3067..c036ff7b4fb2 100644
--- a/drivers/thermal/gov_step_wise.c
+++ b/drivers/thermal/gov_step_wise.c
@@ -35,7 +35,8 @@
  *       deactivate the thermal instance
  */
 static unsigned long get_target_state(struct thermal_instance *instance,
-				enum thermal_trend trend, bool throttle)
+				enum thermal_trend trend, bool throttle,
+				enum thermal_trip_monitor_type type)
 {
 	struct thermal_cooling_device *cdev = instance->cdev;
 	unsigned long cur_state;
@@ -65,11 +66,24 @@ static unsigned long get_target_state(struct thermal_instance *instance,
 
 	switch (trend) {
 	case THERMAL_TREND_RAISING:
-		if (throttle) {
-			next_target = cur_state < instance->upper ?
-				    (cur_state + 1) : instance->upper;
-			if (next_target < instance->lower)
-				next_target = instance->lower;
+		if (type == THERMAL_TRIP_MONITOR_FALLING) {
+			if (cur_state <= instance->lower) {
+				if (!throttle)
+					next_target = THERMAL_NO_TARGET;
+			} else {
+				if (!throttle) {
+					next_target = cur_state - 1;
+					if (next_target > instance->upper)
+						next_target = instance->upper;
+				}
+			}
+		} else {
+			if (throttle) {
+				next_target = cur_state < instance->upper ?
+					    (cur_state + 1) : instance->upper;
+				if (next_target < instance->lower)
+					next_target = instance->lower;
+			}
 		}
 		break;
 	case THERMAL_TREND_RAISE_FULL:
@@ -77,14 +91,23 @@ static unsigned long get_target_state(struct thermal_instance *instance,
 			next_target = instance->upper;
 		break;
 	case THERMAL_TREND_DROPPING:
-		if (cur_state <= instance->lower) {
-			if (!throttle)
-				next_target = THERMAL_NO_TARGET;
+		if (type == THERMAL_TRIP_MONITOR_FALLING) {
+			if (throttle) {
+				next_target = cur_state < instance->upper ?
+					    (cur_state + 1) : instance->upper;
+				if (next_target < instance->lower)
+					next_target = instance->lower;
+			}
 		} else {
-			if (!throttle) {
-				next_target = cur_state - 1;
-				if (next_target > instance->upper)
-					next_target = instance->upper;
+			if (cur_state <= instance->lower) {
+				if (!throttle)
+					next_target = THERMAL_NO_TARGET;
+			} else {
+				if (!throttle) {
+					next_target = cur_state - 1;
+					if (next_target > instance->upper)
+						next_target = instance->upper;
+				}
 			}
 		}
 		break;
@@ -117,6 +140,8 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 {
 	int trip_temp;
 	enum thermal_trip_type trip_type;
+	enum thermal_trip_monitor_type monitor_type =
+					THERMAL_TRIP_MONITOR_RISING;
 	enum thermal_trend trend;
 	struct thermal_instance *instance;
 	bool throttle = false;
@@ -130,9 +155,15 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 		tz->ops->get_trip_type(tz, trip, &trip_type);
 	}
 
+	if (tz->ops->get_trip_mon_type)
+		tz->ops->get_trip_mon_type(tz, trip, &monitor_type);
+
 	trend = get_tz_trend(tz, trip);
 
-	if (tz->temperature >= trip_temp) {
+	if (((monitor_type == THERMAL_TRIP_MONITOR_RISING) &&
+	     (tz->temperature >= trip_temp)) ||
+	     ((monitor_type == THERMAL_TRIP_MONITOR_FALLING) &&
+	     (tz->temperature <= trip_temp))) {
 		throttle = true;
 		trace_thermal_zone_trip(tz, trip, trip_type);
 	}
@@ -147,7 +178,8 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 			continue;
 
 		old_target = instance->target;
-		instance->target = get_target_state(instance, trend, throttle);
+		instance->target = get_target_state(instance, trend,
+						    throttle, monitor_type);
 		dev_dbg(&instance->cdev->device, "old_target=%d, target=%d\n",
 					old_target, (int)instance->target);
 
-- 
2.25.1

[PATCH RFC 6/8] thermal: Modify thermal governors to do nothing for trip points being monitored for falling temperature

[Thara Gopinath]

For now, thermal governors other than step wise governorr do not support
monitoring of falling temperature. Hence, in case of calls to the governor
for trip points marked as THERMAL_TRIP_MONITOR_FALLING, return doing
nothing.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/gov_bang_bang.c       | 12 ++++++++++++
 drivers/thermal/gov_fair_share.c      | 12 ++++++++++++
 drivers/thermal/gov_power_allocator.c | 12 ++++++++++++
 3 files changed, 36 insertions(+)

diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index 991a1c54296d..a662047e5961 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -99,6 +99,18 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 static int bang_bang_control(struct thermal_zone_device *tz, int trip)
 {
 	struct thermal_instance *instance;
+	enum thermal_trip_monitor_type monitor_type =
+						THERMAL_TRIP_MONITOR_RISING;
+
+	/*
+	 * Return doing nothing if the trip point is monitored for
+	 * falling temperature
+	 */
+	if (tz->ops->get_trip_mon_type) {
+		tz->ops->get_trip_mon_type(tz, trip, &monitor_type);
+		if (monitor_type == THERMAL_TRIP_MONITOR_FALLING)
+			return 0;
+	}
 
 	thermal_zone_trip_update(tz, trip);
 
diff --git a/drivers/thermal/gov_fair_share.c b/drivers/thermal/gov_fair_share.c
index aaa07180ab48..064ad6ed67ad 100644
--- a/drivers/thermal/gov_fair_share.c
+++ b/drivers/thermal/gov_fair_share.c
@@ -81,6 +81,18 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
 	int total_weight = 0;
 	int total_instance = 0;
 	int cur_trip_level = get_trip_level(tz);
+	enum thermal_trip_monitor_type monitor_type =
+						THERMAL_TRIP_MONITOR_RISING;
+
+	/*
+	 * Return doing nothing if the trip point is monitored for
+	 * falling temperature
+	 */
+	if (tz->ops->get_trip_mon_type) {
+		tz->ops->get_trip_mon_type(tz, trip, &monitor_type);
+		if (monitor_type == THERMAL_TRIP_MONITOR_FALLING)
+			return 0;
+	}
 
 	list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
 		if (instance->trip != trip)
diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 5cb518d8f156..0f674cd1b9b8 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -606,6 +606,8 @@ static int power_allocator_throttle(struct thermal_zone_device *tz, int trip)
 {
 	int ret;
 	int switch_on_temp, control_temp;
+	enum thermal_trip_monitor_type monitor_type =
+						THERMAL_TRIP_MONITOR_RISING;
 	struct power_allocator_params *params = tz->governor_data;
 
 	/*
@@ -615,6 +617,16 @@ static int power_allocator_throttle(struct thermal_zone_device *tz, int trip)
 	if (trip != params->trip_max_desired_temperature)
 		return 0;
 
+	/*
+	 * Return doing nothing if the trip point is monitored for
+	 * falling temperature
+	 */
+	if (tz->ops->get_trip_mon_type) {
+		tz->ops->get_trip_mon_type(tz, trip, &monitor_type);
+		if (monitor_type == THERMAL_TRIP_MONITOR_FALLING)
+			return 0;
+	}
+
 	ret = tz->ops->get_trip_temp(tz, params->trip_switch_on,
 				     &switch_on_temp);
 	if (!ret && (tz->temperature < switch_on_temp)) {
-- 
2.25.1

[PATCH RFC 7/8] thermal:core: Add is_warming_dev and supporting warming device api's to the cooling dev framework.

[Thara Gopinath]

Introduce a variable is_warming_dev to indicate if a "cooling" device is
actually a warming device or not. Also introduce api's to register and
unregister warming device.

This is a temporary patch. If we agree to replace the term "cooling" with
"mitigating" (or any other appropriate term) in the thermal framework, this
patch can be dropped. Also I have not added warming_device_register api for
all the versions of cooling_device_register because
devm_thermal_of_warming_device_register is the only api needed in the
kernel today as is evident by the next patch in this series.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/thermal/thermal_core.c | 88 +++++++++++++++++++++++++++++-----
 include/linux/thermal.h        |  7 +++
 2 files changed, 83 insertions(+), 12 deletions(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index bfd436379408..4aae48a80e00 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1101,7 +1101,8 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
  */
 static struct thermal_cooling_device *
 __thermal_cooling_device_register(struct device_node *np,
-				  const char *type, void *devdata,
+				  const char *type, bool is_warming_dev,
+				  void *devdata,
 				  const struct thermal_cooling_device_ops *ops)
 {
 	struct thermal_cooling_device *cdev;
@@ -1134,6 +1135,7 @@ __thermal_cooling_device_register(struct device_node *np,
 	cdev->updated = false;
 	cdev->device.class = &thermal_class;
 	cdev->devdata = devdata;
+	cdev->is_warming_dev = is_warming_dev;
 	thermal_cooling_device_setup_sysfs(cdev);
 	dev_set_name(&cdev->device, "cooling_device%d", cdev->id);
 	result = device_register(&cdev->device);
@@ -1178,7 +1180,7 @@ struct thermal_cooling_device *
 thermal_cooling_device_register(const char *type, void *devdata,
 				const struct thermal_cooling_device_ops *ops)
 {
-	return __thermal_cooling_device_register(NULL, type, devdata, ops);
+	return __thermal_cooling_device_register(NULL, type, false, devdata, ops);
 }
 EXPORT_SYMBOL_GPL(thermal_cooling_device_register);
 
@@ -1202,7 +1204,7 @@ thermal_of_cooling_device_register(struct device_node *np,
 				   const char *type, void *devdata,
 				   const struct thermal_cooling_device_ops *ops)
 {
-	return __thermal_cooling_device_register(np, type, devdata, ops);
+	return __thermal_cooling_device_register(np, type, false, devdata, ops);
 }
 EXPORT_SYMBOL_GPL(thermal_of_cooling_device_register);
 
@@ -1242,7 +1244,7 @@ devm_thermal_of_cooling_device_register(struct device *dev,
 	if (!ptr)
 		return ERR_PTR(-ENOMEM);
 
-	tcd = __thermal_cooling_device_register(np, type, devdata, ops);
+	tcd = __thermal_cooling_device_register(np, type, false, devdata, ops);
 	if (IS_ERR(tcd)) {
 		devres_free(ptr);
 		return tcd;
@@ -1255,6 +1257,49 @@ devm_thermal_of_cooling_device_register(struct device *dev,
 }
 EXPORT_SYMBOL_GPL(devm_thermal_of_cooling_device_register);
 
+/**
+ * devm_thermal_of_warming_device_register() - register an OF thermal warming
+ *					       device
+ * @dev:	a valid struct device pointer of a sensor device.
+ * @np:		a pointer to a device tree node.
+ * @type:	the thermal cooling device type.
+ * @devdata:	device private data.
+ * @ops:	standard thermal cooling devices callbacks.
+ *
+ * This function will register a warming device with device tree node reference.
+ * This interface function adds a new thermal warming device (fan/processor/...)
+ * to /sys/class/thermal/ folder as cooling_device[0-*]. It tries to bind itself
+ * to all the thermal zone devices registered at the same time.
+ *
+ * Return: a pointer to the created struct thermal_cooling_device or an
+ * ERR_PTR. Caller must check return value with IS_ERR*() helpers.
+ */
+struct thermal_cooling_device *
+devm_thermal_of_warming_device_register(struct device *dev,
+					struct device_node *np,
+					char *type, void *devdata,
+					const struct thermal_cooling_device_ops *ops)
+{
+	struct thermal_cooling_device **ptr, *tcd;
+
+	ptr = devres_alloc(thermal_cooling_device_release, sizeof(*ptr),
+			   GFP_KERNEL);
+	if (!ptr)
+		return ERR_PTR(-ENOMEM);
+
+	tcd = __thermal_cooling_device_register(np, type, true, devdata, ops);
+	if (IS_ERR(tcd)) {
+		devres_free(ptr);
+		return tcd;
+	}
+
+	*ptr = tcd;
+	devres_add(dev, ptr);
+
+	return tcd;
+}
+EXPORT_SYMBOL_GPL(devm_thermal_of_warming_device_register);
+
 static void __unbind(struct thermal_zone_device *tz, int mask,
 		     struct thermal_cooling_device *cdev)
 {
@@ -1265,14 +1310,8 @@ static void __unbind(struct thermal_zone_device *tz, int mask,
 			thermal_zone_unbind_cooling_device(tz, i, cdev);
 }
 
-/**
- * thermal_cooling_device_unregister - removes a thermal cooling device
- * @cdev:	the thermal cooling device to remove.
- *
- * thermal_cooling_device_unregister() must be called when a registered
- * thermal cooling device is no longer needed.
- */
-void thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)
+static void
+__thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)
 {
 	int i;
 	const struct thermal_zone_params *tzp;
@@ -1319,8 +1358,33 @@ void thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)
 	thermal_cooling_device_destroy_sysfs(cdev);
 	put_device(&cdev->device);
 }
+
+/**
+ * thermal_cooling_device_unregister - removes a thermal cooling device
+ * @cdev:	the thermal cooling device to remove.
+ *
+ * thermal_cooling_device_unregister() must be called when a registered
+ * thermal cooling device is no longer needed.
+ */
+void thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)
+{
+	__thermal_cooling_device_unregister(cdev);
+}
 EXPORT_SYMBOL_GPL(thermal_cooling_device_unregister);
 
+/**
+ * thermal_warming_device_unregister - removes a thermal warming  device
+ * @cdev:	the thermal warming device to remove.
+ *
+ * thermal_warming_device_unregister() must be called when a registered
+ * thermal warming device is no longer needed.
+ */
+void thermal_warming_device_unregister(struct thermal_cooling_device *cdev)
+{
+	__thermal_cooling_device_unregister(cdev);
+}
+EXPORT_SYMBOL_GPL(thermal_warming_device_unregister);
+
 static void bind_tz(struct thermal_zone_device *tz)
 {
 	int i, ret;
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index a50ed958d0bd..455120f485dd 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -96,6 +96,7 @@ struct thermal_cooling_device_ops {
 
 struct thermal_cooling_device {
 	int id;
+	bool is_warming_dev;
 	char type[THERMAL_NAME_LENGTH];
 	struct device device;
 	struct device_node *np;
@@ -393,7 +394,13 @@ devm_thermal_of_cooling_device_register(struct device *dev,
 				struct device_node *np,
 				char *type, void *devdata,
 				const struct thermal_cooling_device_ops *ops);
+struct thermal_cooling_device *
+devm_thermal_of_warming_device_register(struct device *dev,
+				struct device_node *np,
+				char *type, void *devdata,
+				const struct thermal_cooling_device_ops *ops);
 void thermal_cooling_device_unregister(struct thermal_cooling_device *);
+void thermal_warming_device_unregister(struct thermal_cooling_device *);
 struct thermal_zone_device *thermal_zone_get_zone_by_name(const char *name);
 int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);
 int thermal_zone_get_slope(struct thermal_zone_device *tz);
-- 
2.25.1

[PATCH RFC 8/8] soc:qcom:qcom_aoss: Change cooling_device_register to warming_device_register

[Thara Gopinath]

Always on subsystem host resources cx and ebi that are used as warming
devices. Use the newly introduce _warming_device_register to register
these devices with the thermal framework.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
 drivers/soc/qcom/qcom_aoss.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index ed2c687c16b3..4f65c03a5def 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -461,7 +461,7 @@ static int qmp_cooling_device_add(struct qmp *qmp,
 	qmp_cdev->qmp = qmp;
 	qmp_cdev->state = !qmp_cdev_max_state;
 	qmp_cdev->name = cdev_name;
-	qmp_cdev->cdev = devm_thermal_of_cooling_device_register
+	qmp_cdev->cdev = devm_thermal_of_warming_device_register
 				(qmp->dev, node,
 				cdev_name,
 				qmp_cdev, &qmp_cooling_device_ops);
@@ -501,7 +501,7 @@ static int qmp_cooling_devices_register(struct qmp *qmp)
 
 unroll:
 	while (--count >= 0)
-		thermal_cooling_device_unregister
+		thermal_warming_device_unregister
 			(qmp->cooling_devs[count].cdev);
 
 	return ret;
@@ -512,7 +512,7 @@ static void qmp_cooling_devices_remove(struct qmp *qmp)
 	int i;
 
 	for (i = 0; i < QMP_NUM_COOLING_RESOURCES; i++)
-		thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev);
+		thermal_warming_device_unregister(qmp->cooling_devs[i].cdev);
 }
 
 static int qmp_probe(struct platform_device *pdev)
-- 
2.25.1

Re: [PATCH RFC 8/8] soc:qcom:qcom_aoss: Change cooling_device_register to warming_device_register

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5196 bytes --]

Hi Thara,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.9-rc5 next-20200916]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r003-20200917 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1321160a26e7e489baf9b10d6de90a342f898960)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/soc/qcom/qcom_aoss.c:464:19: error: implicit declaration of function 'devm_thermal_of_warming_device_register' [-Werror,-Wimplicit-function-declaration]
           qmp_cdev->cdev = devm_thermal_of_warming_device_register
                            ^
   drivers/soc/qcom/qcom_aoss.c:464:19: note: did you mean 'devm_thermal_of_cooling_device_register'?
   include/linux/thermal.h:432:1: note: 'devm_thermal_of_cooling_device_register' declared here
   devm_thermal_of_cooling_device_register(struct device *dev,
   ^
>> drivers/soc/qcom/qcom_aoss.c:464:17: warning: incompatible integer to pointer conversion assigning to 'struct thermal_cooling_device *' from 'int' [-Wint-conversion]
           qmp_cdev->cdev = devm_thermal_of_warming_device_register
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qcom_aoss.c:504:3: error: implicit declaration of function 'thermal_warming_device_unregister' [-Werror,-Wimplicit-function-declaration]
                   thermal_warming_device_unregister
                   ^
   drivers/soc/qcom/qcom_aoss.c:504:3: note: did you mean 'thermal_cooling_device_unregister'?
   include/linux/thermal.h:439:20: note: 'thermal_cooling_device_unregister' declared here
   static inline void thermal_cooling_device_unregister(
                      ^
   drivers/soc/qcom/qcom_aoss.c:515:3: error: implicit declaration of function 'thermal_warming_device_unregister' [-Werror,-Wimplicit-function-declaration]
                   thermal_warming_device_unregister(qmp->cooling_devs[i].cdev);
                   ^
   1 warning and 3 errors generated.

# https://github.com/0day-ci/linux/commit/7c75758cd4b524506f725cb5c62ae90c260f34da
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 7c75758cd4b524506f725cb5c62ae90c260f34da
vim +/devm_thermal_of_warming_device_register +464 drivers/soc/qcom/qcom_aoss.c

   454	
   455	static int qmp_cooling_device_add(struct qmp *qmp,
   456					  struct qmp_cooling_device *qmp_cdev,
   457					  struct device_node *node)
   458	{
   459		char *cdev_name = (char *)node->name;
   460	
   461		qmp_cdev->qmp = qmp;
   462		qmp_cdev->state = !qmp_cdev_max_state;
   463		qmp_cdev->name = cdev_name;
 > 464		qmp_cdev->cdev = devm_thermal_of_warming_device_register
   465					(qmp->dev, node,
   466					cdev_name,
   467					qmp_cdev, &qmp_cooling_device_ops);
   468	
   469		if (IS_ERR(qmp_cdev->cdev))
   470			dev_err(qmp->dev, "unable to register %s cooling device\n",
   471				cdev_name);
   472	
   473		return PTR_ERR_OR_ZERO(qmp_cdev->cdev);
   474	}
   475	
   476	static int qmp_cooling_devices_register(struct qmp *qmp)
   477	{
   478		struct device_node *np, *child;
   479		int count = QMP_NUM_COOLING_RESOURCES;
   480		int ret;
   481	
   482		np = qmp->dev->of_node;
   483	
   484		qmp->cooling_devs = devm_kcalloc(qmp->dev, count,
   485						 sizeof(*qmp->cooling_devs),
   486						 GFP_KERNEL);
   487	
   488		if (!qmp->cooling_devs)
   489			return -ENOMEM;
   490	
   491		for_each_available_child_of_node(np, child) {
   492			if (!of_find_property(child, "#cooling-cells", NULL))
   493				continue;
   494			ret = qmp_cooling_device_add(qmp, &qmp->cooling_devs[count++],
   495						     child);
   496			if (ret)
   497				goto unroll;
   498		}
   499	
   500		return 0;
   501	
   502	unroll:
   503		while (--count >= 0)
 > 504			thermal_warming_device_unregister
   505				(qmp->cooling_devs[count].cdev);
   506	
   507		return ret;
   508	}
   509	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34800 bytes --]

Re: [PATCH RFC 0/8] Introduce warming in thermal framework

[Thara Gopinath]

On Wed, 16 Sep 2020 at 23:22, Thara Gopinath <thara.gopinath@linaro.org> wrote:
>
> Thermal framework today supports monitoring for rising temperatures and
> subsequently initiating cooling action in case of a thermal trip point
> being crossed. There are scenarios where a SoC need warming mitigating
> action to be activated if the temperature falls below a cetain permissible
> limit.  Since warming action can be considered mirror opposite of cooling
> action, most of the thermal framework can be re-used to achieve this. The
> key assumption in this patch series is that a device can act either as a
> warming device or a cooling device and not as both.
>
> In order to support warming three extensions are needed in the thermal
> framework.
>
> 1. Indication that a trip point is being monitored for falling temperature
> and not rising temperature. We discussed two different ways to achieve this
> during LPC. First option is to introduce a new trip type to indicate that a
> trip is a cold trip(THERMAL_TRIP_COLD). The second option is to introduce a
> new property for trip point that will indicate whether a trip point is
> being monitored for rising temperature or falling temperature. The patch
> series(patches 1-4) chooses the second approach since it allows trip points
> of any type to be monitored for rising or falling temperature.Also this was
> the preferred approach when discussed during LPC. The approach that
> introduces a new cold trip type was posted on the list earlier as a RFC and
> can be found at [1].
>
> 2. Extend the exisitng governors to handle monitoring of falling
> temperature. The patch series(patches 5 & 6) extends the step wise governor
> to monitor the falling temperature.Other governors return doing nothing if
> the trip point they are being called for is being monitored for falling
> temperature. The governors' mitigate function is called "throttle" in the
> thermal framework and with this patch series it is a misnomer as the
> function is called for both throttling and warming up. Ideally
> "throttle" should be renamed to "mitigate" to improve readability of code.
> The renaming is not part of this series.
>
> 3. Finally, the cooling device framework itself can be reused for a warming
> device. As stated before a device can act either as a warming device or a
> cooling device and not as both.  With this the cooling state in the
> framework can be considered as mitigating state with 0 as the state with no
> thermal mitigation and higher the number higher the thermal mitigation.
> Again what affects the code readability and comprehension is the term
> "cooling" which is a misnomer here. Ideally the term "cooling" should be
> renamed to "mitigating" and hence thermal_cooling_device will become
> thermal_mitgating_device. The renaming is not part of the patch series as
> even though the renaming is a simple search-replace, it will change a lot
> of files.  The patch series(patches 7 & 8) instead introduces a minimal set
> of _warming_device_ apis to register and unregister warming devices which
> internally is identical to the _cooling_device_ counterpart.

Gentle ping for review..

>
> 1. https://lkml.org/lkml/2020/7/10/639
>
> Thara Gopinath (8):
>   dt-bindings: thermal: Introduce monitor-falling parameter to thermal
>     trip point binding
>   thermal: Introduce new property monitor_type for trip point.
>   thermal: thermal_of: Extend thermal dt driver to support
>     bi-directional monitoring of a thermal trip point.
>   thermal:core:Add genetlink notifications for monitoring falling
>     temperature
>   thermal: gov_step_wise: Extend thermal step-wise governor to monitor
>     falling temperature.
>   thermal: Modify thermal governors to do nothing for trip points being
>     monitored for falling temperature
>   thermal:core: Add is_warming_dev and supporting warming device api's
>     to the cooling dev framework.
>   soc:qcom:qcom_aoss: Change cooling_device_register to
>     warming_device_register
>
>  .../bindings/thermal/thermal-zones.yaml       |   7 ++
>  drivers/soc/qcom/qcom_aoss.c                  |   6 +-
>  drivers/thermal/gov_bang_bang.c               |  12 ++
>  drivers/thermal/gov_fair_share.c              |  12 ++
>  drivers/thermal/gov_power_allocator.c         |  12 ++
>  drivers/thermal/gov_step_wise.c               |  62 +++++++---
>  drivers/thermal/thermal_core.c                | 113 +++++++++++++++---
>  drivers/thermal/thermal_core.h                |   2 +
>  drivers/thermal/thermal_of.c                  |  22 ++++
>  include/linux/thermal.h                       |   9 ++
>  include/uapi/linux/thermal.h                  |   5 +
>  11 files changed, 226 insertions(+), 36 deletions(-)
>
> --
> 2.25.1
>


-- 
Warm Regards
Thara

Re: [PATCH RFC 0/8] Introduce warming in thermal framework

[Daniel Lezcano]

On 19/10/2020 20:42, Thara Gopinath wrote:
> On Wed, 16 Sep 2020 at 23:22, Thara Gopinath <thara.gopinath@linaro.org> wrote:
>>
>> Thermal framework today supports monitoring for rising temperatures and
>> subsequently initiating cooling action in case of a thermal trip point
>> being crossed. There are scenarios where a SoC need warming mitigating
>> action to be activated if the temperature falls below a cetain permissible
>> limit.  Since warming action can be considered mirror opposite of cooling
>> action, most of the thermal framework can be re-used to achieve this. The
>> key assumption in this patch series is that a device can act either as a
>> warming device or a cooling device and not as both.
>>
>> In order to support warming three extensions are needed in the thermal
>> framework.
>>
>> 1. Indication that a trip point is being monitored for falling temperature
>> and not rising temperature. We discussed two different ways to achieve this
>> during LPC. First option is to introduce a new trip type to indicate that a
>> trip is a cold trip(THERMAL_TRIP_COLD). The second option is to introduce a
>> new property for trip point that will indicate whether a trip point is
>> being monitored for rising temperature or falling temperature. The patch
>> series(patches 1-4) chooses the second approach since it allows trip points
>> of any type to be monitored for rising or falling temperature.Also this was
>> the preferred approach when discussed during LPC. The approach that
>> introduces a new cold trip type was posted on the list earlier as a RFC and
>> can be found at [1].
>>
>> 2. Extend the exisitng governors to handle monitoring of falling
>> temperature. The patch series(patches 5 & 6) extends the step wise governor
>> to monitor the falling temperature.Other governors return doing nothing if
>> the trip point they are being called for is being monitored for falling
>> temperature. The governors' mitigate function is called "throttle" in the
>> thermal framework and with this patch series it is a misnomer as the
>> function is called for both throttling and warming up. Ideally
>> "throttle" should be renamed to "mitigate" to improve readability of code.
>> The renaming is not part of this series.
>>
>> 3. Finally, the cooling device framework itself can be reused for a warming
>> device. As stated before a device can act either as a warming device or a
>> cooling device and not as both.  With this the cooling state in the
>> framework can be considered as mitigating state with 0 as the state with no
>> thermal mitigation and higher the number higher the thermal mitigation.
>> Again what affects the code readability and comprehension is the term
>> "cooling" which is a misnomer here. Ideally the term "cooling" should be
>> renamed to "mitigating" and hence thermal_cooling_device will become
>> thermal_mitgating_device. The renaming is not part of the patch series as
>> even though the renaming is a simple search-replace, it will change a lot
>> of files.  The patch series(patches 7 & 8) instead introduces a minimal set
>> of _warming_device_ apis to register and unregister warming devices which
>> internally is identical to the _cooling_device_ counterpart.
> 
> Gentle ping for review..

Pong, review before the end of this week.



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 7015 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200917032226.820371-5-thara.gopinath@linaro.org>
References: <20200917032226.820371-5-thara.gopinath@linaro.org>
TO: Thara Gopinath <thara.gopinath@linaro.org>

Hi Thara,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.9-rc5 next-20200916]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.

# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359c9d1f7f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c

0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  416  
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  417  static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  418  {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  419  	enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  420  	enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  421  	int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  422  
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  423  	/* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  424  	if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  425  		return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui      2016-03-18  426  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  427  	tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  428  	tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  429  	if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  430  		tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  431  
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  432  	if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  433  		tz->ops->get_trip_mon_type(tz, trip, &mon_type);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  434  
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  435  	if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436  		if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  437  			if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  438  			    tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  439  				thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  440  			if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  441  			    tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  442  				thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  443  		} else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  444  			if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  445  			    tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  446  				thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  447  			if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  448  			    tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  449  				thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06  450  		}
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16  451  	}
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  452  
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  453  	if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  454  		handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  455  	else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba    2018-10-15  456  		handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  457  	/*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  458  	 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  459  	 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  460  	 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  461  	monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  462  }
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c  Durgadoss R    2012-09-18  463  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30048 bytes --]