All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Glenn Washburn <development@efficientek.com>,
	grub-devel@gnu.org, pmenzel@molgen.mpg.de
Subject: Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.
Date: Thu, 17 Sep 2020 09:34:50 -0700	[thread overview]
Message-ID: <20200917163450.GA2391422@google.com> (raw)
In-Reply-To: <20200917141956.bnmhmocizf4hqb7m@tomti.i.net-space.pl>

On 09/17, Daniel Kiper wrote:
> Adding Jaegeuk and Paul...
> 
> On Fri, Aug 28, 2020 at 06:30:25PM -0500, Glenn Washburn wrote:
> > LODEVICES is not an array variable and should not be accessed as such. This
> > allows the f2fs test to pass as it was failing because a device name had a
> > space prepended to the path.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  tests/util/grub-fs-tester.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> > index bc14a05ca..bfc425e1f 100644
> > --- a/tests/util/grub-fs-tester.in
> > +++ b/tests/util/grub-fs-tester.in
> > @@ -796,7 +796,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
> >  		    MOUNTFS=ext2
> >  		    "mkfs.ext2" -L "$FSLABEL" -q "${MOUNTDEVICE}"  ;;
> >  		xf2fs)
> > -		    "mkfs.f2fs" -l "$FSLABEL" -q "${LODEVICES[0]}" ;;
> > +		    "mkfs.f2fs" -l "$FSLABEL" -q "${MOUNTDEVICE}" ;;
> 
> LGTM...
> 
> Jaegeuk, Paul does this fix work for you?

Thank you. I'm okay and should follow the others.

Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>

> 
> Daniel


  reply	other threads:[~2020-09-17 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28  9:19 Quoting issues in Bash script `grub-fs-tester` causes F2FS test failure Paul Menzel
2020-08-28 23:30 ` [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests Glenn Washburn
2020-09-17 14:19   ` Daniel Kiper
2020-09-17 16:34     ` Jaegeuk Kim [this message]
2020-09-18  7:06   ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917163450.GA2391422@google.com \
    --to=jaegeuk@kernel.org \
    --cc=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.