From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Johan Jonker <jbx6244@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kever Yang <kever.yang@rock-chips.com>,
Vivek Unune <npcomplete13@gmail.com>,
Alexis Ballier <aballier@gentoo.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Anand Moon <linux.amoon@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags
Date: Thu, 17 Sep 2020 20:52:10 +0200 [thread overview]
Message-ID: <20200917185211.5483-1-krzk@kernel.org> (raw)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags without affecting the code:
ACTIVE_HIGH => IRQ_TYPE_NONE
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on HW.
Changes since v1:
1. Correct title
---
arch/arm/boot/dts/rk3188-bqedison2qc.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3188-bqedison2qc.dts b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
index 66a0ff196eb1..b191347894f6 100644
--- a/arch/arm/boot/dts/rk3188-bqedison2qc.dts
+++ b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
@@ -7,6 +7,7 @@
/dts-v1/;
#include <dt-bindings/i2c/i2c.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
#include "rk3188.dtsi"
/ {
@@ -479,7 +480,7 @@
reg = <1>;
compatible = "brcm,bcm4329-fmac";
interrupt-parent = <&gpio3>;
- interrupts = <RK_PD2 GPIO_ACTIVE_HIGH>;
+ interrupts = <RK_PD2 IRQ_TYPE_NONE>;
interrupt-names = "host-wake";
brcm,drive-strength = <5>;
pinctrl-names = "default";
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Johan Jonker <jbx6244@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kever Yang <kever.yang@rock-chips.com>,
Vivek Unune <npcomplete13@gmail.com>,
Alexis Ballier <aballier@gentoo.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Anand Moon <linux.amoon@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags
Date: Thu, 17 Sep 2020 20:52:10 +0200 [thread overview]
Message-ID: <20200917185211.5483-1-krzk@kernel.org> (raw)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags without affecting the code:
ACTIVE_HIGH => IRQ_TYPE_NONE
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on HW.
Changes since v1:
1. Correct title
---
arch/arm/boot/dts/rk3188-bqedison2qc.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3188-bqedison2qc.dts b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
index 66a0ff196eb1..b191347894f6 100644
--- a/arch/arm/boot/dts/rk3188-bqedison2qc.dts
+++ b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
@@ -7,6 +7,7 @@
/dts-v1/;
#include <dt-bindings/i2c/i2c.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
#include "rk3188.dtsi"
/ {
@@ -479,7 +480,7 @@
reg = <1>;
compatible = "brcm,bcm4329-fmac";
interrupt-parent = <&gpio3>;
- interrupts = <RK_PD2 GPIO_ACTIVE_HIGH>;
+ interrupts = <RK_PD2 IRQ_TYPE_NONE>;
interrupt-names = "host-wake";
brcm,drive-strength = <5>;
pinctrl-names = "default";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Johan Jonker <jbx6244@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kever Yang <kever.yang@rock-chips.com>,
Vivek Unune <npcomplete13@gmail.com>,
Alexis Ballier <aballier@gentoo.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Anand Moon <linux.amoon@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags
Date: Thu, 17 Sep 2020 20:52:10 +0200 [thread overview]
Message-ID: <20200917185211.5483-1-krzk@kernel.org> (raw)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags without affecting the code:
ACTIVE_HIGH => IRQ_TYPE_NONE
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on HW.
Changes since v1:
1. Correct title
---
arch/arm/boot/dts/rk3188-bqedison2qc.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3188-bqedison2qc.dts b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
index 66a0ff196eb1..b191347894f6 100644
--- a/arch/arm/boot/dts/rk3188-bqedison2qc.dts
+++ b/arch/arm/boot/dts/rk3188-bqedison2qc.dts
@@ -7,6 +7,7 @@
/dts-v1/;
#include <dt-bindings/i2c/i2c.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
#include "rk3188.dtsi"
/ {
@@ -479,7 +480,7 @@
reg = <1>;
compatible = "brcm,bcm4329-fmac";
interrupt-parent = <&gpio3>;
- interrupts = <RK_PD2 GPIO_ACTIVE_HIGH>;
+ interrupts = <RK_PD2 IRQ_TYPE_NONE>;
interrupt-names = "host-wake";
brcm,drive-strength = <5>;
pinctrl-names = "default";
--
2.17.1
next reply other threads:[~2020-09-17 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:52 Krzysztof Kozlowski [this message]
2020-09-17 18:52 ` [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags Krzysztof Kozlowski
2020-09-17 18:52 ` Krzysztof Kozlowski
2020-09-17 18:52 ` [PATCH v2 2/2] arm64: dts: rk3399: " Krzysztof Kozlowski
2020-09-17 18:52 ` Krzysztof Kozlowski
2020-09-17 18:52 ` Krzysztof Kozlowski
2020-10-02 16:11 ` [PATCH v2 1/2] ARM: dts: rk3188: " Krzysztof Kozlowski
2020-10-02 16:11 ` Krzysztof Kozlowski
2020-10-02 16:11 ` Krzysztof Kozlowski
2020-10-17 12:08 ` Heiko Stübner
2020-10-17 12:08 ` Heiko Stübner
2020-10-17 12:08 ` Heiko Stübner
2022-04-02 16:49 ` Krzysztof Kozlowski
2022-04-02 16:49 ` Krzysztof Kozlowski
2022-04-02 16:49 ` Krzysztof Kozlowski
2022-04-04 8:59 ` Heiko Stuebner
2022-04-04 8:59 ` Heiko Stuebner
2022-04-04 8:59 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917185211.5483-1-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=aballier@gentoo.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=npcomplete13@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.