All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v16 0/2] Add initial support for slimport anx7625
@ 2020-09-17  8:16 ` Xin Ji
  0 siblings, 0 replies; 11+ messages in thread
From: Xin Ji @ 2020-09-17  8:16 UTC (permalink / raw)
  To: devel, Laurent Pinchart, Andrzej Hajda, Nicolas Boichat,
	Sam Ravnborg
  Cc: Jernej Skrabec, Nicolas Boichat, Pi-Hsun Shih, Jonas Karlman,
	David Airlie, Neil Armstrong, linux-kernel, dri-devel, Sheng Pan,
	Hsin-Yi Wang, Sam Ravnborg, Dan Carpenter

Hi all,

The following series add support for the Slimport ANX7625 transmitter, a
ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.


This is the v16 version, any mistakes, please let me know, I will fix it in
the next series.

Change history:
v16: Fix compile error
 - Fix compiling error of incompitible interface of ".mode_valid()"

v15: Fix comments from Sam and Hsin-Yi Wang
 - Remove connector
 - Allocate memory for edid at ".get_edid()"

v14: Fix comments from Sam and Nicolas
 - Check flags at drm_bridge_attach
 - Use panel_bridge instead of drm_panel
 - Fix not correct return value

v13: Fix comments from Launrent Pinchart and Rob Herring
 - Picked up Rob's Reviewed-By
 - Add .detect and .get_edid interface in bridge funcs.

v12: Fix comments from Hsin-Yi Wang
 - Rebase the code on kernel 5.7, fix DRM interface not match issue.

v11: Fix comments from Rob Herring
 - Update commit message.
 - Remove unused label.

v10: Fix comments from Rob Herring, Daniel.
 - Fix dt_binding_check warning.
 - Update description.

v9: Fix comments from Sam, Nicolas, Daniel
 - Remove extcon interface.
 - Remove DPI support.
 - Fix dt_binding_check complains.
 - Code clean up and update description.

v8: Fix comments from Nicolas.
 - Fix several coding format.
 - Update description.

v7:
 - Fix critical timing(eg:odd hfp/hbp) in "mode_fixup" interface,
   enhance MIPI RX tolerance by setting register MIPI_DIGITAL_ADJ_1 to 0x3D.


Xin Ji (2):
  dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter DT schema
  drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

 .../bindings/display/bridge/analogix,anx7625.yaml  |   95 +
 drivers/gpu/drm/bridge/analogix/Kconfig            |    9 +
 drivers/gpu/drm/bridge/analogix/Makefile           |    1 +
 drivers/gpu/drm/bridge/analogix/anx7625.c          | 1849 ++++++++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h          |  390 +++++
 5 files changed, 2344 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c
 create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH v16 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP
@ 2020-09-17 22:18 kernel test robot
  0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2020-09-17 22:18 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4524 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <536a274e38d994817c6d0c118f7f8553e74f73c9.1600324895.git.xji(a)analogixsemi.com>
References: <536a274e38d994817c6d0c118f7f8553e74f73c9.1600324895.git.xji@analogixsemi.com>
TO: Xin Ji <xji@analogixsemi.com>
TO: devel(a)driverdev.osuosl.org
TO: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
TO: Andrzej Hajda <a.hajda@samsung.com>
TO: Nicolas Boichat <drinkcat@google.com>
TO: Sam Ravnborg <sam@ravnborg.org>
CC: Jernej Skrabec <jernej.skrabec@siol.net>
CC: "Pi-Hsun Shih" <pihsun@chromium.org>
CC: Jonas Karlman <jonas@kwiboo.se>
CC: David Airlie <airlied@linux.ie>
CC: Neil Armstrong <narmstrong@baylibre.com>

Hi Xin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc5 next-20200917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xin-Ji/Add-initial-support-for-slimport-anx7625/20200917-163238
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5925fa68fe8244651b3f78a88c4af99190a88f0d
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: mips-randconfig-m031-20200917 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/bridge/analogix/anx7625.c:1289 anx7625_get_edid() warn: possible memory leak of 'edid'

# https://github.com/0day-ci/linux/commit/667ee517c70d2bedafe5bfa0dc5f13fc60d5133d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Ji/Add-initial-support-for-slimport-anx7625/20200917-163238
git checkout 667ee517c70d2bedafe5bfa0dc5f13fc60d5133d
vim +/edid +1289 drivers/gpu/drm/bridge/analogix/anx7625.c

667ee517c70d2be Xin Ji 2020-09-17  1263  
667ee517c70d2be Xin Ji 2020-09-17  1264  static struct edid *anx7625_get_edid(struct anx7625_data *ctx)
667ee517c70d2be Xin Ji 2020-09-17  1265  {
667ee517c70d2be Xin Ji 2020-09-17  1266  	struct device *dev = &ctx->client->dev;
667ee517c70d2be Xin Ji 2020-09-17  1267  	struct s_edid_data *p_edid = &ctx->slimport_edid_p;
667ee517c70d2be Xin Ji 2020-09-17  1268  	int edid_num;
667ee517c70d2be Xin Ji 2020-09-17  1269  	u8 *edid;
667ee517c70d2be Xin Ji 2020-09-17  1270  
667ee517c70d2be Xin Ji 2020-09-17  1271  	edid = kmalloc(FOUR_BLOCK_SIZE, GFP_KERNEL);
667ee517c70d2be Xin Ji 2020-09-17  1272  	if (!edid) {
667ee517c70d2be Xin Ji 2020-09-17  1273  		DRM_DEV_ERROR(dev, "Fail to allocate buffer\n");
667ee517c70d2be Xin Ji 2020-09-17  1274  		return NULL;
667ee517c70d2be Xin Ji 2020-09-17  1275  	}
667ee517c70d2be Xin Ji 2020-09-17  1276  
667ee517c70d2be Xin Ji 2020-09-17  1277  	if (ctx->slimport_edid_p.edid_block_num > 0) {
667ee517c70d2be Xin Ji 2020-09-17  1278  		memcpy(edid, ctx->slimport_edid_p.edid_raw_data,
667ee517c70d2be Xin Ji 2020-09-17  1279  		       FOUR_BLOCK_SIZE);
667ee517c70d2be Xin Ji 2020-09-17  1280  		return (struct edid *)edid;
667ee517c70d2be Xin Ji 2020-09-17  1281  	}
667ee517c70d2be Xin Ji 2020-09-17  1282  
667ee517c70d2be Xin Ji 2020-09-17  1283  	anx7625_low_power_mode_check(ctx, 1);
667ee517c70d2be Xin Ji 2020-09-17  1284  	edid_num = sp_tx_edid_read(ctx, p_edid->edid_raw_data);
667ee517c70d2be Xin Ji 2020-09-17  1285  	anx7625_low_power_mode_check(ctx, 0);
667ee517c70d2be Xin Ji 2020-09-17  1286  
667ee517c70d2be Xin Ji 2020-09-17  1287  	if (edid_num < 1) {
667ee517c70d2be Xin Ji 2020-09-17  1288  		DRM_DEV_ERROR(dev, "Fail to read EDID: %d\n", edid_num);
667ee517c70d2be Xin Ji 2020-09-17 @1289  		return NULL;
667ee517c70d2be Xin Ji 2020-09-17  1290  	}
667ee517c70d2be Xin Ji 2020-09-17  1291  
667ee517c70d2be Xin Ji 2020-09-17  1292  	p_edid->edid_block_num = edid_num;
667ee517c70d2be Xin Ji 2020-09-17  1293  
667ee517c70d2be Xin Ji 2020-09-17  1294  	memcpy(edid, ctx->slimport_edid_p.edid_raw_data, FOUR_BLOCK_SIZE);
667ee517c70d2be Xin Ji 2020-09-17  1295  	return (struct edid *)edid;
667ee517c70d2be Xin Ji 2020-09-17  1296  }
667ee517c70d2be Xin Ji 2020-09-17  1297  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27442 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-09-19  8:47 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-17  8:16 [PATCH v16 0/2] Add initial support for slimport anx7625 Xin Ji
2020-09-17  8:16 ` Xin Ji
2020-09-17  8:18 ` [PATCH v16 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter DT schema Xin Ji
2020-09-17  8:18   ` Xin Ji
2020-09-17  8:23 ` [PATCH v16 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP Xin Ji
2020-09-17  8:23   ` Xin Ji
2020-09-18  8:45   ` Dan Carpenter
2020-09-18  8:45     ` Dan Carpenter
2020-09-18 10:06     ` Xin Ji
2020-09-18 10:06       ` Xin Ji
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17 22:18 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.