From: Rob Herring <robh@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver
Date: Fri, 18 Sep 2020 11:22:13 -0600 [thread overview]
Message-ID: <20200918172213.GA3813066@bogus> (raw)
In-Reply-To: <20200915193109.16034-1-james.quinlan@broadcom.com>
On Tue, Sep 15, 2020 at 03:31:04PM -0400, Jim Quinlan wrote:
> Bindings are added. Only one interrupt is needed because
> we do not yet employ the SCMI p2a channel.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> new file mode 100644
> index 000000000000..c2359f3a2b13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml#
> +
> +title: Broadcom STB SCMI mailbox driver bindings
I thought SCMI was a mailbox consumer, not provider?
> +
> +maintainers:
> + - Jim Quinlan <james.quinlan@broadcom.com>
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,brcmstb-mbox
> +
> + interrupts:
> + items:
> + - description: SCMI a2p return interrupt
> +
> + "#mbox-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - interrupts
> + - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mailbox0: mailbox@0 {
Drop the label and unit-address.
Run 'make dt_binding_check' as it will tell you the latter.
> + compatible = "brcm,brcmstb-mailbox";
> + #mbox-cells = <1>;
> + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver
Date: Fri, 18 Sep 2020 11:22:13 -0600 [thread overview]
Message-ID: <20200918172213.GA3813066@bogus> (raw)
In-Reply-To: <20200915193109.16034-1-james.quinlan@broadcom.com>
On Tue, Sep 15, 2020 at 03:31:04PM -0400, Jim Quinlan wrote:
> Bindings are added. Only one interrupt is needed because
> we do not yet employ the SCMI p2a channel.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> new file mode 100644
> index 000000000000..c2359f3a2b13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml#
> +
> +title: Broadcom STB SCMI mailbox driver bindings
I thought SCMI was a mailbox consumer, not provider?
> +
> +maintainers:
> + - Jim Quinlan <james.quinlan@broadcom.com>
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,brcmstb-mbox
> +
> + interrupts:
> + items:
> + - description: SCMI a2p return interrupt
> +
> + "#mbox-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - interrupts
> + - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mailbox0: mailbox@0 {
Drop the label and unit-address.
Run 'make dt_binding_check' as it will tell you the latter.
> + compatible = "brcm,brcmstb-mailbox";
> + #mbox-cells = <1>;
> + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-18 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 19:31 [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver Jim Quinlan
2020-09-15 19:31 ` Jim Quinlan
2020-09-15 19:31 ` [PATCH v1 2/2] mailbox: Add Broadcom STB " Jim Quinlan
2020-09-15 19:31 ` Jim Quinlan
2020-09-15 19:33 ` Florian Fainelli
2020-09-15 19:33 ` Florian Fainelli
2020-09-18 17:22 ` Rob Herring [this message]
2020-09-18 17:22 ` [PATCH v1 1/2] dt-bindings: Add bindings for BrcmSTB SCMI " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918172213.GA3813066@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.