From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Song Liu <song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Johannes Thumshirn
<johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE
Date: Sat, 19 Sep 2020 08:58:16 +0200 [thread overview]
Message-ID: <20200919065816.GA8237@lst.de> (raw)
In-Reply-To: <20200917095507.GJ7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
On Thu, Sep 17, 2020 at 11:55:07AM +0200, Jan Kara wrote:
> On Thu 10-09-20 16:48:23, Christoph Hellwig wrote:
> > This case isn't ever used.
> >
> > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org>
>
> Are you sure it's never used? As far as I'm reading drdb code the contents
> of the disk_conf structure seems to be received through netlink (that code
> is really a macro hell) and so read_balancing attribute passed to
> remote_due_to_read_balancing() can have any value userspace passed to it.
You are right, looking at how disk_conf is used I can't convince myself
that it is indeed not set through netlink and I've thus dropped the
patch.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Song Liu <song@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Richard Weinberger <richard@nod.at>,
Minchan Kim <minchan@kernel.org>,
linux-mtd@lists.infradead.org, dm-devel@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE
Date: Sat, 19 Sep 2020 08:58:16 +0200 [thread overview]
Message-ID: <20200919065816.GA8237@lst.de> (raw)
In-Reply-To: <20200917095507.GJ7347@quack2.suse.cz>
On Thu, Sep 17, 2020 at 11:55:07AM +0200, Jan Kara wrote:
> On Thu 10-09-20 16:48:23, Christoph Hellwig wrote:
> > This case isn't ever used.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> Are you sure it's never used? As far as I'm reading drdb code the contents
> of the disk_conf structure seems to be received through netlink (that code
> is really a macro hell) and so read_balancing attribute passed to
> remote_due_to_read_balancing() can have any value userspace passed to it.
You are right, looking at how disk_conf is used I can't convince myself
that it is indeed not set through netlink and I've thus dropped the
patch.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Minchan Kim <minchan@kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Song Liu <song@kernel.org>,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
linux-mm@kvack.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE
Date: Sat, 19 Sep 2020 08:58:16 +0200 [thread overview]
Message-ID: <20200919065816.GA8237@lst.de> (raw)
In-Reply-To: <20200917095507.GJ7347@quack2.suse.cz>
On Thu, Sep 17, 2020 at 11:55:07AM +0200, Jan Kara wrote:
> On Thu 10-09-20 16:48:23, Christoph Hellwig wrote:
> > This case isn't ever used.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> Are you sure it's never used? As far as I'm reading drdb code the contents
> of the disk_conf structure seems to be received through netlink (that code
> is really a macro hell) and so read_balancing attribute passed to
> remote_due_to_read_balancing() can have any value userspace passed to it.
You are right, looking at how disk_conf is used I can't convince myself
that it is indeed not set through netlink and I've thus dropped the
patch.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Minchan Kim <minchan@kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Song Liu <song@kernel.org>,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
linux-mm@kvack.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE
Date: Sat, 19 Sep 2020 08:58:16 +0200 [thread overview]
Message-ID: <20200919065816.GA8237@lst.de> (raw)
In-Reply-To: <20200917095507.GJ7347@quack2.suse.cz>
On Thu, Sep 17, 2020 at 11:55:07AM +0200, Jan Kara wrote:
> On Thu 10-09-20 16:48:23, Christoph Hellwig wrote:
> > This case isn't ever used.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> Are you sure it's never used? As far as I'm reading drdb code the contents
> of the disk_conf structure seems to be received through netlink (that code
> is really a macro hell) and so read_balancing attribute passed to
> remote_due_to_read_balancing() can have any value userspace passed to it.
You are right, looking at how disk_conf is used I can't convince myself
that it is indeed not set through netlink and I've thus dropped the
patch.
next prev parent reply other threads:[~2020-09-19 6:58 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 14:48 bdi cleanups v4 Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-10 14:48 ` [PATCH 01/12] fs: remove the unused SB_I_MULTIROOT flag Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-17 9:41 ` Jan Kara
2020-09-17 9:41 ` [Drbd-dev] " Jan Kara
2020-09-17 9:41 ` Jan Kara
2020-09-10 14:48 ` [PATCH 02/12] drbd: remove dead code in device_to_statistics Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-3-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:46 ` Jan Kara
2020-09-17 9:46 ` [Drbd-dev] " Jan Kara
2020-09-17 9:46 ` Jan Kara
2020-09-17 9:46 ` Jan Kara
2020-09-10 14:48 ` [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-17 9:55 ` Jan Kara
2020-09-17 9:55 ` [Drbd-dev] " Jan Kara
2020-09-17 9:55 ` Jan Kara
[not found] ` <20200917095507.GJ7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19 6:58 ` Christoph Hellwig [this message]
2020-09-19 6:58 ` [Drbd-dev] " Christoph Hellwig
2020-09-19 6:58 ` Christoph Hellwig
2020-09-19 6:58 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-5-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:04 ` Jan Kara
2020-09-17 10:04 ` [Drbd-dev] " Jan Kara
2020-09-17 10:04 ` Jan Kara
2020-09-17 10:04 ` Jan Kara
2020-09-19 7:01 ` Christoph Hellwig
2020-09-19 7:01 ` [Drbd-dev] " Christoph Hellwig
2020-09-19 7:01 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 07/12] bdi: remove BDI_CAP_CGROUP_WRITEBACK Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-8-hch-jcswGhMUV9g@public.gmane.org>
2020-09-16 9:28 ` David Sterba
2020-09-16 9:28 ` David Sterba
2020-09-16 9:28 ` David Sterba
2020-09-17 9:36 ` Jan Kara
2020-09-17 9:36 ` [Drbd-dev] " Jan Kara
2020-09-17 9:36 ` Jan Kara
2020-09-17 9:36 ` Jan Kara
2020-09-10 14:48 ` [PATCH 09/12] mm: use SWP_SYNCHRONOUS_IO more intelligently Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-17 9:06 ` Jan Kara
2020-09-17 9:06 ` [Drbd-dev] " Jan Kara
2020-09-17 9:06 ` Jan Kara
2020-09-10 14:48 ` [PATCH 11/12] bdi: invert BDI_CAP_NO_ACCT_WB Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-12-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:27 ` Jan Kara
2020-09-17 9:27 ` [Drbd-dev] " Jan Kara
2020-09-17 9:27 ` Jan Kara
2020-09-17 9:27 ` Jan Kara
2020-09-10 14:48 ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} with a single flag Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK,ACCT_DIRTY} " Christoph Hellwig
[not found] ` <20200910144833.742260-13-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:31 ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} " Jan Kara
2020-09-17 9:31 ` [Drbd-dev] " Jan Kara
2020-09-17 9:31 ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK,ACCT_DIRTY} " Jan Kara
2020-09-17 9:31 ` Jan Kara
2020-09-10 14:48 ` [PATCH 05/12] md: update the optimal I/O size on reshape Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-12 6:17 ` Song Liu
2020-09-12 6:17 ` Song Liu
2020-09-10 14:48 ` [PATCH 06/12] block: lift setting the readahead size into the block layer Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-7-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:35 ` Jan Kara
2020-09-17 10:35 ` [Drbd-dev] " Jan Kara
2020-09-17 10:35 ` Jan Kara
2020-09-17 10:35 ` Jan Kara
2020-09-19 7:31 ` Christoph Hellwig
2020-09-19 7:31 ` [Drbd-dev] " Christoph Hellwig
2020-09-19 7:31 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 08/12] bdi: remove BDI_CAP_SYNCHRONOUS_IO Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
[not found] ` <20200910144833.742260-9-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:36 ` Jan Kara
2020-09-17 9:36 ` [Drbd-dev] " Jan Kara
2020-09-17 9:36 ` Jan Kara
2020-09-17 9:36 ` Jan Kara
2020-09-10 14:48 ` [PATCH 10/12] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
2020-09-10 14:48 ` [Drbd-dev] " Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-10 14:48 ` Christoph Hellwig
2020-09-17 9:25 ` Jan Kara
2020-09-17 9:25 ` [Drbd-dev] " Jan Kara
2020-09-17 9:25 ` Jan Kara
[not found] ` <20200917092524.GC7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19 6:51 ` Christoph Hellwig
2020-09-19 6:51 ` [Drbd-dev] " Christoph Hellwig
2020-09-19 6:51 ` Christoph Hellwig
2020-09-19 6:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-09-15 15:18 bdi cleanups v5 Christoph Hellwig
[not found] ` <20200915151829.1767176-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-15 15:18 ` [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Christoph Hellwig
2020-09-15 15:18 ` Christoph Hellwig
2020-09-15 15:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919065816.GA8237@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=richard-/L3Ra7n9ekc@public.gmane.org \
--cc=song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.