Re: R: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment

From: Andrew Lunn <andrew@lunn.ch>
To: ansuelsmth@gmail.com
Cc: devicetree@vger.kernel.org,
	'Vignesh Raghavendra' <vigneshr@ti.com>,
	'Boris Brezillon' <bbrezillon@kernel.org>,
	'Richard Weinberger' <richard@nod.at>,
	'Russell King' <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, 'Rob Herring' <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	'Miquel Raynal' <miquel.raynal@bootlin.com>,
	'Jakub Kicinski' <kuba@kernel.org>,
	netdev@vger.kernel.org, 'Frank Rowand' <frowand.list@gmail.com>,
	"'David S. Miller'" <davem@davemloft.net>,
	'Heiner Kallweit' <hkallweit1@gmail.com>
Subject: Re: R: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment
Date: Sun, 20 Sep 2020 03:22:16 +0200	[thread overview]
Message-ID: <20200920012216.GE3673389@lunn.ch> (raw)
In-Reply-To: <006301d68ee6$87fcc400$97f64c00$@gmail.com>

On Sun, Sep 20, 2020 at 02:39:39AM +0200, ansuelsmth@gmail.com wrote:
> 
> 
> > -----Messaggio originale-----
> > Da: Andrew Lunn <andrew@lunn.ch>
> > Inviato: domenica 20 settembre 2020 02:31
> > A: Ansuel Smith <ansuelsmth@gmail.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>; Richard Weinberger
> > <richard@nod.at>; Vignesh Raghavendra <vigneshr@ti.com>; Rob Herring
> > <robh+dt@kernel.org>; David S. Miller <davem@davemloft.net>; Jakub
> > Kicinski <kuba@kernel.org>; Heiner Kallweit <hkallweit1@gmail.com>;
> > Russell King <linux@armlinux.org.uk>; Frank Rowand
> > <frowand.list@gmail.com>; Boris Brezillon <bbrezillon@kernel.org>; linux-
> > mtd@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; netdev@vger.kernel.org
> > Oggetto: Re: [PATCH v2 4/4] dt-bindings: net: Document use of mac-
> > address-increment
> > 
> > > +  mac-address-increment:
> > > +    description:
> > > +      The MAC address can optionally be increased (or decreased using
> > > +      negative values) from the original value readed (from a nvmem
> cell
> > 
> > Read is irregular, there is no readed, just read.
> > 
> > > +      for example). This can be used if the mac is readed from a
> dedicated
> > > +      partition and must be increased based on the number of device
> > > +      present in the system.
> > 
> > You should probably add there is no underflow/overflow to other bytes
> > of the MAC address. 00:01:02:03:04:ff + 1 == 00:01:02:03:04:00.
> > 
> > > +    minimum: -255
> > > +    maximum: 255
> > > +
> > > +  mac-address-increment-byte:
> > > +    description:
> > > +      If 'mac-address-increment' is defined, this will tell what byte
> of
> > > +      the mac-address will be increased. If 'mac-address-increment' is
> > > +      not defined, this option will do nothing.
> > > +    default: 5
> > > +    minimum: 0
> > > +    maximum: 5
> > 
> > Is there a real need for this? A value of 0 seems like a bad idea,
> > since a unicast address could easily become a multicast address, which
> > is not valid for an interface address. It also does not seem like a
> > good idea to allow the OUI to be changed. So i think only bytes 3-5
> > should be allowed, but even then, i don't think this is needed, unless
> > you do have a clear use case.
> > 
> >     Andrew
> 
> Honestly the mac-address-increment-byte is added to give user some control
> but I
> don't really have a use case for it. Should I limit it to 3 or just remove
> the function?

If you have no use case, just remove it and document that last byte
will be incremented. I somebody does need it, it can be added in a
backwards compatible way.

     Andrew

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/