From: Pavel Machek <pavel@ucw.cz>
To: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, dan.j.williams@intel.com,
vkoul@kernel.org, ludovic.desroches@microchip.com,
stable@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak
Date: Sun, 20 Sep 2020 10:28:38 +0200 [thread overview]
Message-ID: <20200920082838.GA813@amd> (raw)
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
This fixes memory leak in at_hdmac. Mainline does not have the same
problem.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 86427f6ba78c..0847b2055857 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1714,8 +1714,10 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
atslave->dma_dev = &dmac_pdev->dev;
chan = dma_request_channel(mask, at_dma_filter, atslave);
- if (!chan)
+ if (!chan) {
+ kfree(atslave);
return NULL;
+ }
atchan = to_at_dma_chan(chan);
atchan->per_if = dma_spec->args[0] & 0xff;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, dan.j.williams@intel.com,
vkoul@kernel.org, ludovic.desroches@microchip.com,
stable@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak
Date: Sun, 20 Sep 2020 10:28:38 +0200 [thread overview]
Message-ID: <20200920082838.GA813@amd> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 793 bytes --]
This fixes memory leak in at_hdmac. Mainline does not have the same
problem.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 86427f6ba78c..0847b2055857 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1714,8 +1714,10 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
atslave->dma_dev = &dmac_pdev->dev;
chan = dma_request_channel(mask, at_dma_filter, atslave);
- if (!chan)
+ if (!chan) {
+ kfree(atslave);
return NULL;
+ }
atchan = to_at_dma_chan(chan);
atchan->per_if = dma_spec->args[0] & 0xff;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-09-20 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 8:28 Pavel Machek [this message]
2020-09-20 8:28 ` [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak Pavel Machek
2020-09-23 6:39 ` Ludovic Desroches
2020-09-23 6:39 ` Ludovic Desroches
2020-09-23 8:13 ` Tudor.Ambarus
2020-09-23 8:13 ` Tudor.Ambarus
2020-09-23 8:19 ` Tudor.Ambarus
2020-09-23 8:19 ` Tudor.Ambarus
2021-01-04 11:02 ` Greg KH
2021-01-04 11:02 ` Greg KH
2021-01-05 8:03 ` Tudor.Ambarus
2021-01-05 8:03 ` Tudor.Ambarus
2021-01-06 16:53 ` Greg KH
2021-01-06 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920082838.GA813@amd \
--to=pavel@ucw.cz \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.