From: Shawn Guo <shawnguo@kernel.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Kuldeep Singh <kuldeep.singh@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Varun Sethi <V.Sethi@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board
Date: Mon, 21 Sep 2020 21:03:27 +0800 [thread overview]
Message-ID: <20200921130325.GA25428@dragon> (raw)
In-Reply-To: <AM7PR04MB6885EF94F69D741496AD9C838E3A0@AM7PR04MB6885.eurprd04.prod.outlook.com>
On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Saturday, September 12, 2020 3:19 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li
> > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei
> > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com>
> > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds
> > board
> >
> > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote:
> > > > > + sb_3v3: regulator-sb3v3 {
> > > > > + compatible = "regulator-fixed";
> > > > > + regulator-name = "MC34717-3.3VSB";
> > > > > + regulator-min-microvolt = <3300000>;
> > > > > + regulator-max-microvolt = <3300000>;
> > > > > + regulator-boot-on;
> > > > > + regulator-always-on;
> > > >
> > > > I do not see any point to have regulator-boot-on or
> > > > regulator-always-on for a regulator that doesn't have on/off control.
> > > [Meenakshi Aggarwal] Properties are added to specify that platform
> > > firmware's out of reset configuration enabled the regulator and regulator
> > should never be disabled or change its operative status.
> >
> > What I was wondering if how this regulator is enabled by firmware, by some
> > GPIO control? In that case, 'gpio' property should be there to describe the GPIO
> > control.
> >
> [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board.
> > >
> > > Can you help in understanding why these optional properties cannot be
> > > used together
> >
> > It's totally fine to use these properties together. But if the regulator doesn't
> > have on/off control, neither of them makes sense.
> [Meenakshi Aggarwal] As per documentation, we should keep " regulator-always-on " as per description, we
> Can remove " regulator-boot-on" property from dts.
>
> regulator-always-on:
> description: boolean, regulator should never be disabled
Again, the property is only meaningful for a regulator that can possibly
be disabled.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Varun Sethi <V.Sethi@nxp.com>, Leo Li <leoyang.li@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board
Date: Mon, 21 Sep 2020 21:03:27 +0800 [thread overview]
Message-ID: <20200921130325.GA25428@dragon> (raw)
In-Reply-To: <AM7PR04MB6885EF94F69D741496AD9C838E3A0@AM7PR04MB6885.eurprd04.prod.outlook.com>
On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Saturday, September 12, 2020 3:19 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li
> > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei
> > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com>
> > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds
> > board
> >
> > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote:
> > > > > + sb_3v3: regulator-sb3v3 {
> > > > > + compatible = "regulator-fixed";
> > > > > + regulator-name = "MC34717-3.3VSB";
> > > > > + regulator-min-microvolt = <3300000>;
> > > > > + regulator-max-microvolt = <3300000>;
> > > > > + regulator-boot-on;
> > > > > + regulator-always-on;
> > > >
> > > > I do not see any point to have regulator-boot-on or
> > > > regulator-always-on for a regulator that doesn't have on/off control.
> > > [Meenakshi Aggarwal] Properties are added to specify that platform
> > > firmware's out of reset configuration enabled the regulator and regulator
> > should never be disabled or change its operative status.
> >
> > What I was wondering if how this regulator is enabled by firmware, by some
> > GPIO control? In that case, 'gpio' property should be there to describe the GPIO
> > control.
> >
> [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board.
> > >
> > > Can you help in understanding why these optional properties cannot be
> > > used together
> >
> > It's totally fine to use these properties together. But if the regulator doesn't
> > have on/off control, neither of them makes sense.
> [Meenakshi Aggarwal] As per documentation, we should keep " regulator-always-on " as per description, we
> Can remove " regulator-boot-on" property from dts.
>
> regulator-always-on:
> description: boolean, regulator should never be disabled
Again, the property is only meaningful for a regulator that can possibly
be disabled.
Shawn
next prev parent reply other threads:[~2020-09-21 13:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:13 [PATCH 1/2] dt-bindings: arm64: add compatible for LX2162A QDS Board meenakshi.aggarwal
2020-09-02 15:13 ` meenakshi.aggarwal
2020-09-02 15:13 ` [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board meenakshi.aggarwal
2020-09-02 15:13 ` meenakshi.aggarwal
2020-09-05 7:54 ` Shawn Guo
2020-09-05 7:54 ` Shawn Guo
2020-09-09 7:10 ` Meenakshi Aggarwal
2020-09-09 7:10 ` Meenakshi Aggarwal
2020-09-12 9:49 ` Shawn Guo
2020-09-12 9:49 ` Shawn Guo
2020-09-21 6:00 ` Meenakshi Aggarwal
2020-09-21 6:00 ` Meenakshi Aggarwal
2020-09-21 13:03 ` Shawn Guo [this message]
2020-09-21 13:03 ` Shawn Guo
2020-09-21 13:34 ` Meenakshi Aggarwal
2020-09-21 13:34 ` Meenakshi Aggarwal
2020-09-29 10:01 ` [PATCH v3 0/2] Add device tree support for LX2162AQDS board meenakshi.aggarwal
2020-09-29 10:01 ` meenakshi.aggarwal
2020-09-29 10:01 ` [PATCH v3 1/2] dt-bindings: arm64: add compatible for LX2162A QDS Board meenakshi.aggarwal
2020-09-29 10:01 ` meenakshi.aggarwal
2020-09-29 10:01 ` [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board meenakshi.aggarwal
2020-09-29 10:01 ` meenakshi.aggarwal
2020-10-19 9:00 ` Meenakshi Aggarwal
2020-10-19 9:00 ` Meenakshi Aggarwal
2020-10-26 7:18 ` Shawn Guo
2020-10-26 7:18 ` Shawn Guo
2020-10-26 14:35 ` Leo Li
2020-10-26 14:35 ` Leo Li
2020-10-30 8:59 ` Meenakshi Aggarwal
2020-10-30 8:59 ` Meenakshi Aggarwal
2020-11-02 5:59 ` [PATCH v4 0/2] Add device tree support for LX2162AQDS board meenakshi.aggarwal
2020-11-02 5:59 ` meenakshi.aggarwal
2020-11-02 5:59 ` [PATCH v4 1/2] dt-bindings: arm64: add compatible for LX2162A QDS Board meenakshi.aggarwal
2020-11-02 5:59 ` meenakshi.aggarwal
2020-11-02 5:59 ` [PATCH v4 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board meenakshi.aggarwal
2020-11-02 5:59 ` meenakshi.aggarwal
2020-11-02 23:25 ` [PATCH v4 0/2] Add device tree support for LX2162AQDS board Shawn Guo
2020-11-02 23:25 ` Shawn Guo
2020-09-14 20:23 ` [PATCH 1/2] dt-bindings: arm64: add compatible for LX2162A QDS Board Rob Herring
2020-09-14 20:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921130325.GA25428@dragon \
--to=shawnguo@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuldeep.singh@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshi.aggarwal@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.