Re: [PATCH rdma-core 3/8] verbs: Introduce a new query GID entry API

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, Sep 14, 2020 at 09:34:58AM +0300, Yishai Hadas wrote:
> +static int query_sysfs_gid_ndev_ifindex(struct ibv_context *context,
> +					uint8_t port_num, uint32_t gid_index,
> +					uint32_t *ndev_ifindex)
> +{
> +	struct verbs_device *verbs_device = verbs_get_device(context->device);
> +	char buff[IF_NAMESIZE] = {};

This init is not necessary

> diff --git a/libibverbs/verbs.c b/libibverbs/verbs.c
> index 9507ffd..9427aba 100644
> +++ b/libibverbs/verbs.c
> @@ -240,6 +240,14 @@ LATEST_SYMVER_FUNC(ibv_query_gid, 1_1, "IBVERBS_1.1",
>  	return 0;
>  }
>  
> +int _ibv_query_gid_ex(struct ibv_context *context, uint32_t port_num,
> +		      uint32_t gid_index, struct ibv_gid_entry *entry,
> +		      uint32_t flags, size_t entry_size)
> +{
> +	return ibv_cmd_query_gid_entry(context, port_num, gid_index, entry,
> +				       flags, entry_size);
> +}

This extra function seems unncessary.

We've been creating C files for each object type, the gid stuff could
go in device.c

Jason