From: Jason Gunthorpe <jgg@nvidia.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <maorg@nvidia.com>, <avihaih@nvidia.com>
Subject: Re: [PATCH rdma-core 4/8] verbs: Implement ibv_query_gid and ibv_query_gid_type over ioctl
Date: Mon, 21 Sep 2020 13:53:12 -0300 [thread overview]
Message-ID: <20200921165312.GX3699@nvidia.com> (raw)
In-Reply-To: <20200914063503.192997-5-yishaih@nvidia.com>
On Mon, Sep 14, 2020 at 09:34:59AM +0300, Yishai Hadas wrote:
> diff --git a/libibverbs/verbs.c b/libibverbs/verbs.c
> index 9427aba..9dec4e6 100644
> +++ b/libibverbs/verbs.c
> @@ -216,10 +216,8 @@ LATEST_SYMVER_FUNC(ibv_query_port, 1_1, "IBVERBS_1.1",
> sizeof(*port_attr));
> }
>
> -LATEST_SYMVER_FUNC(ibv_query_gid, 1_1, "IBVERBS_1.1",
> - int,
> - struct ibv_context *context, uint8_t port_num,
> - int index, union ibv_gid *gid)
> +int _ibv_query_gid(struct ibv_context *context, uint8_t port_num, int index,
> + union ibv_gid *gid)
> {
> struct verbs_device *verbs_device = verbs_get_device(context->device);
> char attr[41];
> @@ -240,6 +238,29 @@ LATEST_SYMVER_FUNC(ibv_query_gid, 1_1, "IBVERBS_1.1",
> return 0;
> }
This should be moved to be near query_sysfs_gid_entry() and given a
better name
Jason
next prev parent reply other threads:[~2020-09-21 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 6:34 [PATCH rdma-core 0/8] verbs: Query GID table API Yishai Hadas
2020-09-14 6:34 ` [PATCH rdma-core 1/8] Update kernel headers Yishai Hadas
2020-09-14 6:34 ` [PATCH rdma-core 2/8] verbs: Change the name of enum ibv_gid_type Yishai Hadas
2020-09-14 6:34 ` [PATCH rdma-core 3/8] verbs: Introduce a new query GID entry API Yishai Hadas
2020-09-21 16:49 ` Jason Gunthorpe
2020-09-22 12:47 ` Yishai Hadas
2020-09-14 6:34 ` [PATCH rdma-core 4/8] verbs: Implement ibv_query_gid and ibv_query_gid_type over ioctl Yishai Hadas
2020-09-21 16:53 ` Jason Gunthorpe [this message]
2020-09-22 12:59 ` Yishai Hadas
2020-09-14 6:35 ` [PATCH rdma-core 5/8] verbs: Optimize ibv_query_gid and ibv_query_gid_type Yishai Hadas
2020-09-14 6:35 ` [PATCH rdma-core 6/8] verbs: Introduce a new query GID table API Yishai Hadas
2020-09-14 6:35 ` [PATCH rdma-core 7/8] pyverbs: Add query_gid_table and query_gid_ex methods Yishai Hadas
2020-09-14 6:35 ` [PATCH rdma-core 8/8] tests: Add tests for ibv_query_gid_table and ibv_query_gid_ex Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921165312.GX3699@nvidia.com \
--to=jgg@nvidia.com \
--cc=avihaih@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.