From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/5] staging: vchiq: convert compat create_service
Date: Tue, 22 Sep 2020 02:22:38 +0800 [thread overview]
Message-ID: <202009220240.ELwIpfGS%lkp@intel.com> (raw)
In-Reply-To: <20200918095441.1446041-3-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 8153 bytes --]
Hi Arnd,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/staging-vchiq-rework-compat-handling/20200918-185438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 8436f932d84b1d53d2f4a2fa88c7aacdb0313265
config: arm64-randconfig-s032-20200921 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1509:50: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected int enum vchiq_status ( *callback )( ... ) @@ got void [noderef] __user * @@
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1509:50: sparse: expected int enum vchiq_status ( *callback )( ... )
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1509:50: sparse: got void [noderef] __user *
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1510:50: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *userdata @@ got void [noderef] __user * @@
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1510:50: sparse: expected void *userdata
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1510:50: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1629:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1629:13: sparse: expected void *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1629:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1631:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1631:13: sparse: expected void *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1631:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1706:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct vchiq_completion_data *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1706:13: sparse: expected struct vchiq_completion_data *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1706:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1709:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void **__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1709:13: sparse: expected void **__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1709:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1756:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct vchiq_completion_data *__pu_val @@ got struct vchiq_completion_data [noderef] __user *[assigned] completion @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1756:13: sparse: expected struct vchiq_completion_data *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1756:13: sparse: got struct vchiq_completion_data [noderef] __user *[assigned] completion
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1786:59: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got struct vchiq_header *[addressable] header @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1786:59: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1786:59: sparse: got struct vchiq_header *[addressable] header
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1788:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got void *[addressable] service_userdata @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1788:45: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1788:45: sparse: got void *[addressable] service_userdata
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1790:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got void *[addressable] bulk_userdata @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1790:45: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1790:45: sparse: got void *[addressable] bulk_userdata
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1844:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1844:13: sparse: expected void *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1844:13: sparse: got void [noderef] __user *
# https://github.com/0day-ci/linux/commit/69c0b51efb112af6fa886dca152e2bd3824c126c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Arnd-Bergmann/staging-vchiq-rework-compat-handling/20200918-185438
git checkout 69c0b51efb112af6fa886dca152e2bd3824c126c
vim +1509 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
1489
1490 #define VCHIQ_IOC_CREATE_SERVICE32 \
1491 _IOWR(VCHIQ_IOC_MAGIC, 2, struct vchiq_create_service32)
1492
1493 static long
1494 vchiq_compat_ioctl_create_service(
1495 struct file *file,
1496 unsigned int cmd,
1497 struct vchiq_create_service32 __user *ptrargs32)
1498 {
1499 struct vchiq_create_service args;
1500 struct vchiq_create_service32 args32;
1501 long ret;
1502
1503 if (copy_from_user(&args32, ptrargs32, sizeof(args32)))
1504 return -EFAULT;
1505
1506 args = (struct vchiq_create_service) {
1507 .params = {
1508 .fourcc = args32.params.fourcc,
> 1509 .callback = compat_ptr(args32.params.callback),
> 1510 .userdata = compat_ptr(args32.params.userdata),
1511 .version = args32.params.version,
1512 .version_min = args32.params.version_min,
1513 },
1514 .is_open = args32.is_open,
1515 .is_vchi = args32.is_vchi,
1516 .handle = args32.handle,
1517 };
1518
1519 ret = vchiq_ioc_create_service(file->private_data, &args);
1520 if (ret < 0)
1521 return ret;
1522
1523 if (put_user(args.handle, &ptrargs32->handle)) {
1524 vchiq_remove_service(args.handle);
1525 return -EFAULT;
1526 }
1527
1528 return 0;
1529 }
1530
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33311 bytes --]
next prev parent reply other threads:[~2020-09-21 18:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:54 [PATCH 0/5] staging: vchiq: stop using compat_alloc_user_space Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-18 9:54 ` [PATCH 1/5] staging: vchiq: rework compat handling Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-18 9:54 ` [PATCH 2/5] staging: vchiq: convert compat create_service Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 18:22 ` kernel test robot [this message]
2020-09-18 9:54 ` [PATCH 3/5] staging: vchiq: convert compat dequeue_message Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 19:31 ` kernel test robot
2020-09-18 9:54 ` [PATCH 4/5] staging: vchiq: convert compat bulk transfer Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 20:46 ` kernel test robot
2020-09-18 9:54 ` [PATCH 5/5] staging: vchiq: convert compat await_completion Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 21:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009220240.ELwIpfGS%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.