From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/5] staging: vchiq: convert compat dequeue_message
Date: Tue, 22 Sep 2020 03:31:45 +0800 [thread overview]
Message-ID: <202009220327.aaSt4ACg%lkp@intel.com> (raw)
In-Reply-To: <20200918095441.1446041-4-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 7637 bytes --]
Hi Arnd,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/staging-vchiq-rework-compat-handling/20200918-185438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 8436f932d84b1d53d2f4a2fa88c7aacdb0313265
config: arm64-randconfig-s032-20200921 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1519:50: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected int enum vchiq_status ( *callback )( ... ) @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1519:50: sparse: expected int enum vchiq_status ( *callback )( ... )
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1519:50: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1520:50: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *userdata @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1520:50: sparse: expected void *userdata
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1520:50: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1639:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1639:13: sparse: expected void *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1639:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1641:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1641:13: sparse: expected void *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1641:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1716:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct vchiq_completion_data *__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1716:13: sparse: expected struct vchiq_completion_data *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1716:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1719:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void **__pu_val @@ got void [noderef] __user * @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1719:13: sparse: expected void **__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1719:13: sparse: got void [noderef] __user *
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1766:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct vchiq_completion_data *__pu_val @@ got struct vchiq_completion_data [noderef] __user *[assigned] completion @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1766:13: sparse: expected struct vchiq_completion_data *__pu_val
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1766:13: sparse: got struct vchiq_completion_data [noderef] __user *[assigned] completion
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1796:59: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got struct vchiq_header *[addressable] header @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1796:59: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1796:59: sparse: got struct vchiq_header *[addressable] header
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1798:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got void *[addressable] service_userdata @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1798:45: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1798:45: sparse: got void *[addressable] service_userdata
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1800:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *uptr @@ got void *[addressable] bulk_userdata @@
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1800:45: sparse: expected void [noderef] __user *uptr
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1800:45: sparse: got void *[addressable] bulk_userdata
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1849:45: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *buf @@ got void [noderef] __user * @@
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1849:45: sparse: expected void *buf
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1849:45: sparse: got void [noderef] __user *
# https://github.com/0day-ci/linux/commit/43c2a8584dc3a6fc1d6042cc06e1d1da38001ba4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Arnd-Bergmann/staging-vchiq-rework-compat-handling/20200918-185438
git checkout 43c2a8584dc3a6fc1d6042cc06e1d1da38001ba4
vim +1849 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
1830
1831 #define VCHIQ_IOC_DEQUEUE_MESSAGE32 \
1832 _IOWR(VCHIQ_IOC_MAGIC, 8, struct vchiq_dequeue_message32)
1833
1834 static long
1835 vchiq_compat_ioctl_dequeue_message(struct file *file,
1836 unsigned int cmd,
1837 struct vchiq_dequeue_message32 __user *arg)
1838 {
1839 struct vchiq_dequeue_message32 args32;
1840 struct vchiq_dequeue_message args;
1841
1842 if (copy_from_user(&args32, arg, sizeof(args32)))
1843 return -EFAULT;
1844
1845 args = (struct vchiq_dequeue_message) {
1846 .handle = args32.handle,
1847 .blocking = args32.blocking,
1848 .bufsize = args32.bufsize,
> 1849 .buf = compat_ptr(args32.buf),
1850 };
1851
1852 return vchiq_ioc_dequeue_message(file->private_data, &args);
1853 }
1854
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33311 bytes --]
next prev parent reply other threads:[~2020-09-21 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:54 [PATCH 0/5] staging: vchiq: stop using compat_alloc_user_space Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-18 9:54 ` [PATCH 1/5] staging: vchiq: rework compat handling Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-18 9:54 ` [PATCH 2/5] staging: vchiq: convert compat create_service Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 18:22 ` kernel test robot
2020-09-18 9:54 ` [PATCH 3/5] staging: vchiq: convert compat dequeue_message Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 19:31 ` kernel test robot [this message]
2020-09-18 9:54 ` [PATCH 4/5] staging: vchiq: convert compat bulk transfer Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 20:46 ` kernel test robot
2020-09-18 9:54 ` [PATCH 5/5] staging: vchiq: convert compat await_completion Arnd Bergmann
2020-09-18 9:54 ` Arnd Bergmann
2020-09-21 21:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009220327.aaSt4ACg%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.