From: Christoph Hellwig <hch@lst.de>
To: boris.ostrovsky@oracle.com
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
linux-mm@kvack.org, Peter Zijlstra <peterz@infradead.org>,
intel-gfx@lists.freedesktop.org, x86@kernel.org,
linux-kernel@vger.kernel.org, Minchan Kim <minchan@kernel.org>,
dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Nitin Gupta <ngupta@vflare.org>
Subject: Re: [Intel-gfx] [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc
Date: Tue, 22 Sep 2020 17:27:06 +0200 [thread overview]
Message-ID: <20200922152706.GA30633@lst.de> (raw)
In-Reply-To: <ebd69ba1-fc06-3cc7-348e-3cb0004c2a34@oracle.com>
On Tue, Sep 22, 2020 at 11:24:20AM -0400, boris.ostrovsky@oracle.com wrote:
>
> On 9/22/20 10:58 AM, Christoph Hellwig wrote:
> > On Mon, Sep 21, 2020 at 04:44:10PM -0400, boris.ostrovsky@oracle.com wrote:
> >> This will end up incrementing area->ptes pointer. So perhaps something like
> >>
> >>
> >> pte_t **ptes = area->ptes;
> >>
> >> if (apply_to_page_range(&init_mm, (unsigned long)area->area->addr,
> >> PAGE_SIZE * nr_frames, gnttab_apply, &ptes)) {
> >>
> >> ...
> > Yeah. What do you think of this version?
>
>
> Oh yes, this is way better. This now can actually be read without trying to mentally unwind triple pointers. (You probably want to initialize idx to zero before calling apply_to_page_range(), I am not sure it's guaranteed to be zero).
Both instances are static variables, thus in .bss and initialized.
So unless you insist I don't think we need a manual one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: boris.ostrovsky@oracle.com
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
x86@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org
Subject: Re: [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc
Date: Tue, 22 Sep 2020 17:27:06 +0200 [thread overview]
Message-ID: <20200922152706.GA30633@lst.de> (raw)
In-Reply-To: <ebd69ba1-fc06-3cc7-348e-3cb0004c2a34@oracle.com>
On Tue, Sep 22, 2020 at 11:24:20AM -0400, boris.ostrovsky@oracle.com wrote:
>
> On 9/22/20 10:58 AM, Christoph Hellwig wrote:
> > On Mon, Sep 21, 2020 at 04:44:10PM -0400, boris.ostrovsky@oracle.com wrote:
> >> This will end up incrementing area->ptes pointer. So perhaps something like
> >>
> >>
> >> pte_t **ptes = area->ptes;
> >>
> >> if (apply_to_page_range(&init_mm, (unsigned long)area->area->addr,
> >> PAGE_SIZE * nr_frames, gnttab_apply, &ptes)) {
> >>
> >> ...
> > Yeah. What do you think of this version?
>
>
> Oh yes, this is way better. This now can actually be read without trying to mentally unwind triple pointers. (You probably want to initialize idx to zero before calling apply_to_page_range(), I am not sure it's guaranteed to be zero).
Both instances are static variables, thus in .bss and initialized.
So unless you insist I don't think we need a manual one.
next prev parent reply other threads:[~2020-09-22 15:27 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:37 [Intel-gfx] remove alloc_vm_area Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-18 16:37 ` [Intel-gfx] [PATCH 1/6] zsmalloc: switch from alloc_vm_area to get_vm_area Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-21 17:42 ` [Intel-gfx] " Minchan Kim
2020-09-21 17:42 ` Minchan Kim
2020-09-21 17:42 ` Minchan Kim
2020-09-21 18:17 ` [Intel-gfx] " Christoph Hellwig
2020-09-21 18:17 ` Christoph Hellwig
2020-09-21 18:42 ` [Intel-gfx] " Minchan Kim
2020-09-21 18:42 ` Minchan Kim
2020-09-21 18:42 ` Minchan Kim
2020-09-21 18:43 ` [Intel-gfx] " Christoph Hellwig
2020-09-21 18:43 ` Christoph Hellwig
2020-09-18 16:37 ` [Intel-gfx] [PATCH 2/6] mm: add a vmap_pfn function Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-18 16:37 ` [Intel-gfx] [PATCH 3/6] drm/i915: use vmap in shmem_pin_map Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-21 19:11 ` [Intel-gfx] " Matthew Wilcox
2020-09-21 19:11 ` Matthew Wilcox
2020-09-21 19:11 ` Matthew Wilcox
2020-09-22 6:22 ` [Intel-gfx] " Christoph Hellwig
2020-09-22 6:22 ` Christoph Hellwig
2020-09-22 8:23 ` [Intel-gfx] " Tvrtko Ursulin
2020-09-22 8:23 ` Tvrtko Ursulin
2020-09-22 8:23 ` Tvrtko Ursulin
2020-09-22 14:31 ` Christoph Hellwig
2020-09-22 14:31 ` Christoph Hellwig
2020-09-22 16:13 ` Tvrtko Ursulin
2020-09-22 16:13 ` Tvrtko Ursulin
2020-09-22 16:13 ` Tvrtko Ursulin
2020-09-22 16:33 ` Christoph Hellwig
2020-09-22 16:33 ` Christoph Hellwig
2020-09-22 17:04 ` Tvrtko Ursulin
2020-09-22 17:04 ` Tvrtko Ursulin
2020-09-22 17:04 ` Tvrtko Ursulin
2020-09-23 6:11 ` Christoph Hellwig
2020-09-23 6:11 ` Christoph Hellwig
2020-09-22 11:21 ` Matthew Wilcox
2020-09-22 11:21 ` Matthew Wilcox
2020-09-22 11:21 ` Matthew Wilcox
2020-09-22 14:39 ` [Intel-gfx] " Christoph Hellwig
2020-09-22 14:39 ` Christoph Hellwig
2020-09-22 14:53 ` [Intel-gfx] " Matthew Wilcox
2020-09-22 14:53 ` Matthew Wilcox
2020-09-22 14:53 ` Matthew Wilcox
2020-09-18 16:37 ` [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-23 9:52 ` [Intel-gfx] " Tvrtko Ursulin
2020-09-23 9:52 ` Tvrtko Ursulin
2020-09-23 9:52 ` Tvrtko Ursulin
2020-09-23 13:41 ` Christoph Hellwig
2020-09-23 13:41 ` Christoph Hellwig
2020-09-23 13:58 ` Tvrtko Ursulin
2020-09-23 13:58 ` Tvrtko Ursulin
2020-09-23 13:58 ` Tvrtko Ursulin
2020-09-23 14:44 ` Christoph Hellwig
2020-09-23 14:44 ` Christoph Hellwig
2020-09-24 12:22 ` Tvrtko Ursulin
2020-09-24 12:22 ` Tvrtko Ursulin
2020-09-24 12:22 ` Tvrtko Ursulin
2020-09-24 13:23 ` Christoph Hellwig
2020-09-24 13:23 ` Christoph Hellwig
2020-09-18 16:37 ` [Intel-gfx] [PATCH 5/6] xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-18 16:37 ` [Intel-gfx] [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc Christoph Hellwig
2020-09-18 16:37 ` Christoph Hellwig
2020-09-21 20:44 ` [Intel-gfx] " boris.ostrovsky
2020-09-21 20:44 ` boris.ostrovsky
2020-09-21 20:44 ` boris.ostrovsky
2020-09-22 14:58 ` [Intel-gfx] " Christoph Hellwig
2020-09-22 14:58 ` Christoph Hellwig
2020-09-22 15:24 ` [Intel-gfx] " boris.ostrovsky
2020-09-22 15:24 ` boris.ostrovsky
2020-09-22 15:24 ` boris.ostrovsky
2020-09-22 15:27 ` Christoph Hellwig [this message]
2020-09-22 15:27 ` Christoph Hellwig
2020-09-22 15:34 ` [Intel-gfx] " boris.ostrovsky
2020-09-22 15:34 ` boris.ostrovsky
2020-09-22 15:34 ` boris.ostrovsky
2020-09-18 17:03 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area Patchwork
2020-09-21 17:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev2) Patchwork
2020-09-21 18:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev3) Patchwork
2020-09-22 14:44 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev4) Patchwork
2020-09-22 15:01 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922152706.GA30633@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=sstabellini@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.