From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid"
Date: Tue, 22 Sep 2020 17:57:02 +0200 [thread overview]
Message-ID: <20200922155702.GA5580@kozik-lap> (raw)
In-Reply-To: <20200921174818.15525-1-krzk@kernel.org>
On Mon, Sep 21, 2020 at 07:48:18PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720.
>
> The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in
> Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3.
>
> It changes the order of clock drivers probe: the clkout (Exynos PMU)
> driver is probed before the main clk-exynos4 driver. The clkout driver
> on Exynos4412 depends on clk-exynos4 but it does not support deferred
> probe, therefore this dependency and changed probe order causes probe
> failure.
>
> The usb3503 USB hub on Odroid U3 on the other hand requires clkout
> clock. This can be seen in logs:
>
> [ 5.007442] usb3503 0-0008: unable to request refclk (-517)
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -
Applied.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid"
Date: Tue, 22 Sep 2020 17:57:02 +0200 [thread overview]
Message-ID: <20200922155702.GA5580@kozik-lap> (raw)
In-Reply-To: <20200921174818.15525-1-krzk@kernel.org>
On Mon, Sep 21, 2020 at 07:48:18PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720.
>
> The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in
> Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3.
>
> It changes the order of clock drivers probe: the clkout (Exynos PMU)
> driver is probed before the main clk-exynos4 driver. The clkout driver
> on Exynos4412 depends on clk-exynos4 but it does not support deferred
> probe, therefore this dependency and changed probe order causes probe
> failure.
>
> The usb3503 USB hub on Odroid U3 on the other hand requires clkout
> clock. This can be seen in logs:
>
> [ 5.007442] usb3503 0-0008: unable to request refclk (-517)
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -
Applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-22 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:48 [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid" Krzysztof Kozlowski
2020-09-21 17:48 ` Krzysztof Kozlowski
2020-09-22 15:57 ` Krzysztof Kozlowski [this message]
2020-09-22 15:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922155702.GA5580@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.