All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Cc: netdev@vger.kernel.org, roopa@nvidia.com, davem@davemloft.net,
	bridge@lists.linux-foundation.org,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	Marek Lindner <mareklindner@neomailbox.ch>,
	Antonio Quartulli <a@unstable.cc>
Subject: Re: [PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst
Date: Tue, 22 Sep 2020 19:51:19 +0200	[thread overview]
Message-ID: <20200922175119.GA10212@otheros> (raw)
In-Reply-To: <20200922073027.1196992-7-razor@blackwall.org>

On Tue, Sep 22, 2020 at 10:30:17AM +0300, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> Since now we have src in br_ip, u no longer makes sense so rename
> it to dst. No functional changes.
> 
> v2: fix build with CONFIG_BATMAN_ADV_MCAST

Hi Nikolay,

I don't see a "src" in br_ip in net-next/master at the moment. Or
is that supposed to be added with your IGMPv3 implementation in
the future?

(which btw. is awesome, really looking forward to full IGMPv3(+MLDv2)
support, as source-specific-multicast would allow us to implement
some neat, way more efficient algorithms than with any-source-multicast
for multicast in batman-adv in the future, too)

Regards, Linus

WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <mareklindner@neomailbox.ch>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	Antonio Quartulli <a@unstable.cc>,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	roopa@nvidia.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst
Date: Tue, 22 Sep 2020 19:51:19 +0200	[thread overview]
Message-ID: <20200922175119.GA10212@otheros> (raw)
In-Reply-To: <20200922073027.1196992-7-razor@blackwall.org>

On Tue, Sep 22, 2020 at 10:30:17AM +0300, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> Since now we have src in br_ip, u no longer makes sense so rename
> it to dst. No functional changes.
> 
> v2: fix build with CONFIG_BATMAN_ADV_MCAST

Hi Nikolay,

I don't see a "src" in br_ip in net-next/master at the moment. Or
is that supposed to be added with your IGMPv3 implementation in
the future?

(which btw. is awesome, really looking forward to full IGMPv3(+MLDv2)
support, as source-specific-multicast would allow us to implement
some neat, way more efficient algorithms than with any-source-multicast
for multicast in batman-adv in the future, too)

Regards, Linus

  reply	other threads:[~2020-09-22 17:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  7:30 [Bridge] [PATCH net-next v2 00/16] net: bridge: mcast: IGMPv3/MLDv2 fast-path (part 2) Nikolay Aleksandrov
2020-09-22  7:30 ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 01/16] net: bridge: mdb: use extack in br_mdb_parse() Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 02/16] net: bridge: mdb: move all port and bridge checks to br_mdb_add Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 03/16] net: bridge: mdb: use extack in br_mdb_add() and br_mdb_add_group() Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 04/16] net: bridge: add src field to br_ip Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 05/16] net: bridge: mcast: use br_ip's src for src groups and querier address Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst Nikolay Aleksandrov
2020-09-22  7:30   ` [Bridge] " Nikolay Aleksandrov
2020-09-22 17:51   ` Linus Lüssing [this message]
2020-09-22 17:51     ` Linus Lüssing
2020-09-22 17:55     ` Linus Lüssing
2020-09-22 17:55       ` [Bridge] " Linus Lüssing
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 07/16] net: bridge: mdb: add support to extend add/del commands Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 08/16] net: bridge: mdb: add support for add/del/dump of entries with source Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 09/16] net: bridge: mcast: when igmpv3/mldv2 are enabled lookup (S, G) first, then (*, G) Nikolay Aleksandrov
2020-09-22  7:30   ` [PATCH net-next v2 09/16] net: bridge: mcast: when igmpv3/mldv2 are enabled lookup (S,G) first, then (*,G) Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 10/16] net: bridge: mcast: add rt_protocol field to the port group struct Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 11/16] net: bridge: mcast: add sg_port rhashtable Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 12/16] net: bridge: mcast: install S, G entries automatically based on reports Nikolay Aleksandrov
2020-09-22  7:30   ` [PATCH net-next v2 12/16] net: bridge: mcast: install S,G " Nikolay Aleksandrov
2020-09-23  8:13   ` [PATCH net-next v2 12/16] net: bridge: mcast: install S, G " kernel test robot
2020-09-23  8:20     ` [Bridge] " Nikolay Aleksandrov
2020-09-23  8:20       ` [PATCH net-next v2 12/16] net: bridge: mcast: install S,G " Nikolay Aleksandrov
2020-09-23  8:20       ` [PATCH net-next v2 12/16] net: bridge: mcast: install S, G " Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 13/16] net: bridge: mcast: handle port group filter modes Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 14/16] net: bridge: mcast: add support for blocked port groups Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 15/16] net: bridge: mcast: handle host state Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-22  7:30 ` [Bridge] [PATCH net-next v2 16/16] net: bridge: mcast: when forwarding handle filter mode and blocked flag Nikolay Aleksandrov
2020-09-22  7:30   ` Nikolay Aleksandrov
2020-09-23 20:25 ` [Bridge] [PATCH net-next v2 00/16] net: bridge: mcast: IGMPv3/MLDv2 fast-path (part 2) David Miller
2020-09-23 20:25   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922175119.GA10212@otheros \
    --to=linus.luessing@c0d3.blue \
    --cc=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.