All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios
Date: Tue, 22 Sep 2020 16:39:40 -0600	[thread overview]
Message-ID: <20200922223940.GA3391274@bogus> (raw)
In-Reply-To: <20200911015105.48581-1-jk@codeconstruct.com.au>

On Fri, 11 Sep 2020 09:51:04 +0800, Jeremy Kerr wrote:
> Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
> corresponding to the 80 status bits available in hardware. Each of these
> lines can be configured as either an input or an output.
> 
> However, each of these GPIOs is actually an input *and* an output; we
> actually have 80 inputs plus 80 outputs.
> 
> This change expands the maximum number of GPIOs to 160; the lower half
> of this range are the input-only GPIOs, the upper half are the outputs.
> We fix the GPIO directions to correspond to this mapping.
> 
> This also fixes a bug when setting GPIOs - we were reading from the
> input register, making it impossible to set more than one output GPIO.
> 
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> 
> ---
> v2:
>  - Fix warnings from kbuild test robot
>  - Add comment for input/output GPIO numbering
> ---
>  .../devicetree/bindings/gpio/sgpio-aspeed.txt |   5 +-
>  drivers/gpio/gpio-aspeed-sgpio.c              | 126 ++++++++++++------
>  2 files changed, 87 insertions(+), 44 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	devicetree@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
	linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios
Date: Tue, 22 Sep 2020 16:39:40 -0600	[thread overview]
Message-ID: <20200922223940.GA3391274@bogus> (raw)
In-Reply-To: <20200911015105.48581-1-jk@codeconstruct.com.au>

On Fri, 11 Sep 2020 09:51:04 +0800, Jeremy Kerr wrote:
> Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
> corresponding to the 80 status bits available in hardware. Each of these
> lines can be configured as either an input or an output.
> 
> However, each of these GPIOs is actually an input *and* an output; we
> actually have 80 inputs plus 80 outputs.
> 
> This change expands the maximum number of GPIOs to 160; the lower half
> of this range are the input-only GPIOs, the upper half are the outputs.
> We fix the GPIO directions to correspond to this mapping.
> 
> This also fixes a bug when setting GPIOs - we were reading from the
> input register, making it impossible to set more than one output GPIO.
> 
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> 
> ---
> v2:
>  - Fix warnings from kbuild test robot
>  - Add comment for input/output GPIO numbering
> ---
>  .../devicetree/bindings/gpio/sgpio-aspeed.txt |   5 +-
>  drivers/gpio/gpio-aspeed-sgpio.c              | 126 ++++++++++++------
>  2 files changed, 87 insertions(+), 44 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

  parent reply	other threads:[~2020-09-22 22:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  1:51 [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios Jeremy Kerr
2020-09-11  1:51 ` Jeremy Kerr
2020-09-11  1:51 ` [PATCH v2 2/2] gpio/aspeed-sgpio: don't enable all interrupts by default Jeremy Kerr
2020-09-11  1:51   ` Jeremy Kerr
2020-09-11  2:21   ` Joel Stanley
2020-09-11  2:21     ` Joel Stanley
2020-09-11  3:29   ` Andrew Jeffery
2020-09-11  3:29     ` Andrew Jeffery
2020-09-11  2:20 ` [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios Joel Stanley
2020-09-11  2:20   ` Joel Stanley
2020-09-16  4:51   ` Joel Stanley
2020-09-16  4:51     ` Joel Stanley
2020-09-16 11:09     ` Bartosz Golaszewski
2020-09-16 11:09       ` Bartosz Golaszewski
2020-09-16 12:59       ` Joel Stanley
2020-09-16 12:59         ` Joel Stanley
2020-09-24 13:11         ` Bartosz Golaszewski
2020-09-24 13:11           ` Bartosz Golaszewski
2020-09-11  3:28 ` Andrew Jeffery
2020-09-11  3:28   ` Andrew Jeffery
2020-09-22 22:39 ` Rob Herring [this message]
2020-09-22 22:39   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922223940.GA3391274@bogus \
    --to=robh@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.