From: Tingwei Zhang <tingweiz@codeaurora.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Tingwei Zhang <tingwei@codeaurora.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mao Jinlong <jinlmao@codeaurora.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU
Date: Wed, 23 Sep 2020 12:39:07 +0800 [thread overview]
Message-ID: <20200923043907.GA5146@codeaurora.org> (raw)
In-Reply-To: <87zh5nw8vz.fsf@ashishki-desk.ger.corp.intel.com>
On Fri, Sep 18, 2020 at 08:45:52PM +0800, Alexander Shishkin wrote:
> Tingwei Zhang <tingwei@codeaurora.org> writes:
>
> > @@ -63,6 +65,7 @@ static int __init stm_ftrace_init(void)
> > {
> > int ret;
> >
> > + stm_ftrace.data.nr_chans = num_possible_cpus();
>
> Not a problem with this patch necesarily, but this made me realize that
> .nr_chans may be larger than:
>
> (1) what the policy permits,
> (2) what the stm device can handle.
>
> While (1) the user can fix in the policy, they won't be able to fix (2),
> in which case they won't be able to use stm_ftrace at all. I'm thinking
> if a link-time callback would be good enough.
>
Hi Alex,
I'm not sure if I understand this correct. If the nr_chans requested by
stm_ftrace is larger than policy permits or stm device can handle,
stm_assign_first_policy() returns with error so stm_source_link_add()
will fail. User would notice that when link happens. There's not much
we can do if resource is not enough.
> Another thing is that .nr_chans needs to be a power of 2 at the moment.
>
I'll change to below.
stm_ftrace.data.nr_chans = roundup_pow_of_two(num_possible_cpus());
> Regards,
> --
> Alex
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tingwei Zhang <tingweiz@codeaurora.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Tingwei Zhang <tingwei@codeaurora.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mao Jinlong <jinlmao@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU
Date: Wed, 23 Sep 2020 12:39:07 +0800 [thread overview]
Message-ID: <20200923043907.GA5146@codeaurora.org> (raw)
In-Reply-To: <87zh5nw8vz.fsf@ashishki-desk.ger.corp.intel.com>
On Fri, Sep 18, 2020 at 08:45:52PM +0800, Alexander Shishkin wrote:
> Tingwei Zhang <tingwei@codeaurora.org> writes:
>
> > @@ -63,6 +65,7 @@ static int __init stm_ftrace_init(void)
> > {
> > int ret;
> >
> > + stm_ftrace.data.nr_chans = num_possible_cpus();
>
> Not a problem with this patch necesarily, but this made me realize that
> .nr_chans may be larger than:
>
> (1) what the policy permits,
> (2) what the stm device can handle.
>
> While (1) the user can fix in the policy, they won't be able to fix (2),
> in which case they won't be able to use stm_ftrace at all. I'm thinking
> if a link-time callback would be good enough.
>
Hi Alex,
I'm not sure if I understand this correct. If the nr_chans requested by
stm_ftrace is larger than policy permits or stm device can handle,
stm_assign_first_policy() returns with error so stm_source_link_add()
will fail. User would notice that when link happens. There's not much
we can do if resource is not enough.
> Another thing is that .nr_chans needs to be a power of 2 at the moment.
>
I'll change to below.
stm_ftrace.data.nr_chans = roundup_pow_of_two(num_possible_cpus());
> Regards,
> --
> Alex
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-23 4:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 0:17 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 1/6] stm class: ftrace: change dependency to TRACING Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 2/6] tracing: add flag to control different traces Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 3/6] tracing: add trace_export support for event trace Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 4/6] tracing: add trace_export support for trace_marker Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 5/6] stm class: ftrace: enable supported trace export flag Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-09-03 0:17 ` Tingwei Zhang
2020-09-18 12:45 ` Alexander Shishkin
2020-09-18 12:45 ` Alexander Shishkin
2020-09-23 4:39 ` Tingwei Zhang [this message]
2020-09-23 4:39 ` Tingwei Zhang
2020-09-14 23:27 ` [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-09-14 23:27 ` Tingwei Zhang
2020-09-18 14:26 ` Alexander Shishkin
2020-09-18 14:26 ` Alexander Shishkin
-- strict thread matches above, loose matches on Subject: below --
2020-08-13 1:45 Tingwei Zhang
2020-08-13 1:45 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-08-11 3:57 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-08-11 3:57 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-07-28 1:33 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-07-28 1:33 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923043907.GA5146@codeaurora.org \
--to=tingweiz@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=jinlmao@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.