From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
devicetree@vger.kernel.org, bcousson@baylibre.com,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>,
Trent Piepho <tpiepho@gmail.com>
Subject: Re: [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3
Date: Wed, 23 Sep 2020 09:55:39 +0300 [thread overview]
Message-ID: <20200923065539.GQ7101@atomide.com> (raw)
In-Reply-To: <20200913231557.2063071-1-drew@beagleboard.org>
* Drew Fustini <drew@beagleboard.org> [200913 23:18]:
> pinctrl_spec.args_count can either be 2 when #pinctrl-cells = 1 or
> 3 when #pinctrl-cells = 2.
>
> There is currently only a check to make sure that it is 2 or greater.
> This patch adds a check to make sure it is not greater than 3.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - this is a fix to my prior email where I referred to #pinctrl-cells
> exceeding 3 which is incorrect. It is pinctrl_spec.args_count which
> must be greater than 2 (when #pinctrl-cells = 1) and less than 3 (when
> #pinctrl-cells = 2)
Acked-by: Tony Lindgren <tony@atomide.com>
> https://lore.kernel.org/linux-omap/20200913210825.2022552-1-drew@beagleboard.org/
>
>
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index efe41abc5d47..5cbf0e55087c 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
> if (res)
> return res;
>
> - if (pinctrl_spec.args_count < 2) {
> + if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) {
> dev_err(pcs->dev, "invalid args_count for spec: %i\n",
> pinctrl_spec.args_count);
> break;
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: devicetree@vger.kernel.org, Trent Piepho <tpiepho@gmail.com>,
Jason Kridner <jkridner@beagleboard.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3
Date: Wed, 23 Sep 2020 09:55:39 +0300 [thread overview]
Message-ID: <20200923065539.GQ7101@atomide.com> (raw)
In-Reply-To: <20200913231557.2063071-1-drew@beagleboard.org>
* Drew Fustini <drew@beagleboard.org> [200913 23:18]:
> pinctrl_spec.args_count can either be 2 when #pinctrl-cells = 1 or
> 3 when #pinctrl-cells = 2.
>
> There is currently only a check to make sure that it is 2 or greater.
> This patch adds a check to make sure it is not greater than 3.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - this is a fix to my prior email where I referred to #pinctrl-cells
> exceeding 3 which is incorrect. It is pinctrl_spec.args_count which
> must be greater than 2 (when #pinctrl-cells = 1) and less than 3 (when
> #pinctrl-cells = 2)
Acked-by: Tony Lindgren <tony@atomide.com>
> https://lore.kernel.org/linux-omap/20200913210825.2022552-1-drew@beagleboard.org/
>
>
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index efe41abc5d47..5cbf0e55087c 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
> if (res)
> return res;
>
> - if (pinctrl_spec.args_count < 2) {
> + if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) {
> dev_err(pcs->dev, "invalid args_count for spec: %i\n",
> pinctrl_spec.args_count);
> break;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-23 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 23:15 [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3 Drew Fustini
2020-09-13 23:15 ` Drew Fustini
2020-09-23 6:55 ` Tony Lindgren [this message]
2020-09-23 6:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923065539.GQ7101@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=haojian.zhuang@linaro.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.