From: Thierry Reding <thierry.reding@gmail.com>
To: Simon South <simon@simonsouth.net>
Cc: u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
heiko@sntech.de, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] pwm: rockchip: Keep enabled PWMs running while probing
Date: Wed, 23 Sep 2020 13:41:29 +0200 [thread overview]
Message-ID: <20200923114129.GB1846003@ulmo> (raw)
In-Reply-To: <20200919193306.1023-1-simon@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Sat, Sep 19, 2020 at 03:33:06PM -0400, Simon South wrote:
> Following commit cfc4c189bc70 ("pwm: Read initial hardware state at
> request time") the Rockchip PWM driver can no longer assume a device's
> pwm_state structure has been populated after a call to pwmchip_add().
> Consequently, the test in rockchip_pwm_probe() intended to prevent the
> driver from stopping PWM devices already enabled by the bootloader no
> longer functions reliably and this can lead to the kernel hanging
> during startup, particularly on devices like the Pinebook Pro that use
> a PWM-controlled backlight for their display.
>
> Avoid this by querying the device directly at probe time to determine
> whether or not it is enabled.
>
> Fixes: cfc4c189bc70 ("pwm: Read initial hardware state at request time")
> Signed-off-by: Simon South <simon@simonsouth.net>
> ---
> drivers/pwm/pwm-rockchip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Simon South <simon@simonsouth.net>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pwm: rockchip: Keep enabled PWMs running while probing
Date: Wed, 23 Sep 2020 13:41:29 +0200 [thread overview]
Message-ID: <20200923114129.GB1846003@ulmo> (raw)
In-Reply-To: <20200919193306.1023-1-simon@simonsouth.net>
[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]
On Sat, Sep 19, 2020 at 03:33:06PM -0400, Simon South wrote:
> Following commit cfc4c189bc70 ("pwm: Read initial hardware state at
> request time") the Rockchip PWM driver can no longer assume a device's
> pwm_state structure has been populated after a call to pwmchip_add().
> Consequently, the test in rockchip_pwm_probe() intended to prevent the
> driver from stopping PWM devices already enabled by the bootloader no
> longer functions reliably and this can lead to the kernel hanging
> during startup, particularly on devices like the Pinebook Pro that use
> a PWM-controlled backlight for their display.
>
> Avoid this by querying the device directly at probe time to determine
> whether or not it is enabled.
>
> Fixes: cfc4c189bc70 ("pwm: Read initial hardware state at request time")
> Signed-off-by: Simon South <simon@simonsouth.net>
> ---
> drivers/pwm/pwm-rockchip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Simon South <simon@simonsouth.net>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pwm: rockchip: Keep enabled PWMs running while probing
Date: Wed, 23 Sep 2020 13:41:29 +0200 [thread overview]
Message-ID: <20200923114129.GB1846003@ulmo> (raw)
In-Reply-To: <20200919193306.1023-1-simon@simonsouth.net>
[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]
On Sat, Sep 19, 2020 at 03:33:06PM -0400, Simon South wrote:
> Following commit cfc4c189bc70 ("pwm: Read initial hardware state at
> request time") the Rockchip PWM driver can no longer assume a device's
> pwm_state structure has been populated after a call to pwmchip_add().
> Consequently, the test in rockchip_pwm_probe() intended to prevent the
> driver from stopping PWM devices already enabled by the bootloader no
> longer functions reliably and this can lead to the kernel hanging
> during startup, particularly on devices like the Pinebook Pro that use
> a PWM-controlled backlight for their display.
>
> Avoid this by querying the device directly at probe time to determine
> whether or not it is enabled.
>
> Fixes: cfc4c189bc70 ("pwm: Read initial hardware state at request time")
> Signed-off-by: Simon South <simon@simonsouth.net>
> ---
> drivers/pwm/pwm-rockchip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-23 11:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 19:33 [PATCH v2] pwm: rockchip: Keep enabled PWMs running while probing Simon South
2020-09-19 19:33 ` Simon South
2020-09-19 19:33 ` Simon South
2020-09-21 8:01 ` Uwe Kleine-König
2020-09-21 8:01 ` Uwe Kleine-König
2020-09-21 8:01 ` Uwe Kleine-König
2020-09-23 10:49 ` Heiko Stübner
2020-09-23 10:49 ` Heiko Stübner
2020-09-23 10:49 ` Heiko Stübner
2020-09-23 11:41 ` Thierry Reding [this message]
2020-09-23 11:41 ` Thierry Reding
2020-09-23 11:41 ` Thierry Reding
2020-11-21 1:09 ` Trent Piepho
2020-11-21 1:09 ` Trent Piepho
2020-11-21 1:09 ` Trent Piepho
2020-11-30 0:36 ` Simon South
2020-11-30 0:36 ` Simon South
2020-11-30 0:36 ` Simon South
2020-11-30 0:44 ` [PATCH] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-11-30 0:44 ` Simon South
2020-11-30 0:44 ` Simon South
2020-12-10 17:48 ` Thierry Reding
2020-12-10 17:48 ` Thierry Reding
2020-12-10 17:48 ` Thierry Reding
2020-12-10 21:00 ` Trent Piepho
2020-12-10 21:00 ` Trent Piepho
2020-12-10 21:00 ` Trent Piepho
2020-12-11 10:44 ` Robin Murphy
2020-12-11 10:44 ` Robin Murphy
2020-12-11 10:44 ` Robin Murphy
2020-12-19 20:32 ` Simon South
2020-12-19 20:32 ` Simon South
2020-12-19 20:32 ` Simon South
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923114129.GB1846003@ulmo \
--to=thierry.reding@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=simon@simonsouth.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.