From: "Michael S. Tsirkin" <mst@redhat.com>
To: Leon Romanovsky <leonro@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Eli Cohen <elic@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors
Date: Thu, 24 Sep 2020 05:30:55 -0400 [thread overview]
Message-ID: <20200924052932-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200918082245.GP869610@unreal>
On Fri, Sep 18, 2020 at 11:22:45AM +0300, Leon Romanovsky wrote:
> On Thu, Sep 17, 2020 at 07:35:03PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
> > on VHOST to eliminate build errors.
> >
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
> > mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
> > ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
> > mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
> > mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: Jason Wang <jasowang@redhat.com>
> > Cc: virtualization@lists.linux-foundation.org
> > Cc: Saeed Mahameed <saeedm@nvidia.com>
> > Cc: Leon Romanovsky <leonro@nvidia.com>
> > Cc: netdev@vger.kernel.org
> > ---
> > v2: change from select to depends on VHOST (Saeed)
> > v3: change to depends on VHOST_IOTLB (Jason)
> >
> > drivers/vdpa/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > @@ -31,7 +31,7 @@ config IFCVF
> >
> > config MLX5_VDPA
> > bool "MLX5 VDPA support library for ConnectX devices"
> > - depends on MLX5_CORE
> > + depends on VHOST_IOTLB && MLX5_CORE
> > default n
>
> While we are here, can anyone who apply this patch delete the "default n" line?
> It is by default "n".
>
> Thanks
Hmm other drivers select VHOST_IOTLB, why not do the same?
> > help
> > Support library for Mellanox VDPA drivers. Provides code that is
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Leon Romanovsky <leonro@nvidia.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
virtualization@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>, Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors
Date: Thu, 24 Sep 2020 05:30:55 -0400 [thread overview]
Message-ID: <20200924052932-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200918082245.GP869610@unreal>
On Fri, Sep 18, 2020 at 11:22:45AM +0300, Leon Romanovsky wrote:
> On Thu, Sep 17, 2020 at 07:35:03PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so add a dependency
> > on VHOST to eliminate build errors.
> >
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
> > mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
> > ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
> > mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
> > ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
> > ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
> > mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: Jason Wang <jasowang@redhat.com>
> > Cc: virtualization@lists.linux-foundation.org
> > Cc: Saeed Mahameed <saeedm@nvidia.com>
> > Cc: Leon Romanovsky <leonro@nvidia.com>
> > Cc: netdev@vger.kernel.org
> > ---
> > v2: change from select to depends on VHOST (Saeed)
> > v3: change to depends on VHOST_IOTLB (Jason)
> >
> > drivers/vdpa/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > @@ -31,7 +31,7 @@ config IFCVF
> >
> > config MLX5_VDPA
> > bool "MLX5 VDPA support library for ConnectX devices"
> > - depends on MLX5_CORE
> > + depends on VHOST_IOTLB && MLX5_CORE
> > default n
>
> While we are here, can anyone who apply this patch delete the "default n" line?
> It is by default "n".
>
> Thanks
Hmm other drivers select VHOST_IOTLB, why not do the same?
> > help
> > Support library for Mellanox VDPA drivers. Provides code that is
> >
next prev parent reply other threads:[~2020-09-24 9:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 2:35 [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors Randy Dunlap
2020-09-18 2:35 ` Randy Dunlap
2020-09-18 8:22 ` Leon Romanovsky
2020-09-24 9:30 ` Michael S. Tsirkin [this message]
2020-09-24 9:30 ` Michael S. Tsirkin
2020-09-24 10:24 ` Eli Cohen
2020-09-24 15:47 ` Randy Dunlap
2020-09-24 15:47 ` Randy Dunlap
2020-09-24 16:02 ` Michael S. Tsirkin
2020-09-24 16:02 ` Michael S. Tsirkin
2020-09-25 7:20 ` Leon Romanovsky
2020-09-25 10:19 ` Michael S. Tsirkin
2020-09-25 10:19 ` Michael S. Tsirkin
2020-09-25 11:29 ` Jason Wang
2020-09-25 11:29 ` Jason Wang
2020-09-26 6:53 ` Leon Romanovsky
2020-09-29 7:47 ` Michael S. Tsirkin
2020-09-29 7:47 ` Michael S. Tsirkin
2020-09-25 10:20 ` Michael S. Tsirkin
2020-09-25 10:20 ` Michael S. Tsirkin
2020-09-29 6:01 ` Eli Cohen
2020-09-29 6:10 ` Michael S. Tsirkin
2020-09-29 6:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924052932-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=saeedm@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.